New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: LenslessPiCam: A Hardware and Software Platform for Lensless Computational Imaging with a Raspberry Pi #4747
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@editorialbot remove @antipa from reviewers |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot remove @antipa from reviewers |
@antipa removed from the reviewers list! |
@vboomi, @raolivei13 the review process takes place here. |
Review checklist for @raolivei13Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @raolivei13 thank you for your review. I was wondering if you could elaborate on some of the points you haven't checked? I've left a comment on each point below. Perhaps some of these things were not made clear in the paper, which would be great to receive your feedback on how we can better present / what we should include to fill in the gaps. Thanks! Substantial scholarly effortWhy do you think the work the doesn't meet the scope eligibility described in the JOSS guidelines? Data sharingWe describe in the README where to get the data for our examples. ReproducibilityIt's true that when it comes to hardware, it takes more of an effort to reproduce. To this end, we tried to be as detailed as possible to reproduce our camera though Medium posts. Otherwise in terms of reconstruction, we provided scripts that we hope are straightforward to reproduce the results we present in the paper. FunctionalityAgain, as hardware is involved the functionality for measurement may be difficult to reproduce. But in terms of reconstruction, we hope the following scripts make it straightforward to confirm that side of things: PerformanceThe "Efficient reconstruction" section describes some of our performance claims, which can be reproduced with these scripts:
Automated testsWe provide unit tests in this folder which can be run with |
Review checklist for @vboomiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hello,
there are some points where I made a mistake and will fix it. I will review
the checkpoints at some point this week.
best,
Richard
…On Mon, Oct 17, 2022 at 2:02 AM Eric Bezzam ***@***.***> wrote:
Hi @raolivei13 <https://github.com/raolivei13> thank you for your review.
I was wondering if you could elaborate on some of the points you haven't
checked? I've left a comment on each point below.
Perhaps some of these things were not made clear in the paper, which would
be great to receive your feedback on how we can better present / what we
should include to fill in the gaps. Thanks!
Substantial scholarly effort
Why do you think the work the doesn't meet the scope eligibility described
in the JOSS guidelines?
Data sharing
We describe in the README
<https://github.com/LCAV/LenslessPiCam#data-for-examples-> where to get
the data for our examples.
Reproducibility
It's true that when it comes to hardware, it takes more of an effort to
reproduce. To this end, we tried to be as detailed as possible to reproduce
our camera though Medium posts
***@***.***/a-complete-lensless-imaging-tutorial-hardware-software-and-algorithms-8873fa81a660>.
Otherwise in terms of reconstruction, we provided scripts
<https://github.com/LCAV/LenslessPiCam/tree/main/scripts> that we hope
are straightforward to reproduce the results we present in the paper.
Functionality
Again, as hardware is involved the functionality for measurement may be
difficult to reproduce. But in terms of reconstruction, we hope the
following scripts make it straightforward to confirm that side of things:
- for individual files
<https://github.com/LCAV/LenslessPiCam/tree/main/scripts/recon>
- for a dataset
<https://github.com/LCAV/LenslessPiCam/blob/main/scripts/evaluate_mirflickr_admm.py>
Performance
The "Efficient reconstruction" section describes some of our performance
claims, which can be reproduced with these scripts:
- https://github.com/LCAV/LenslessPiCam/blob/main/profile/admm.py
-
https://github.com/LCAV/LenslessPiCam/blob/main/profile/gradient_descent.py
Automated tests
We provide unit tests in this folder
<https://github.com/LCAV/LenslessPiCam/tree/main/test> which can be run
with pytest
—
Reply to this email directly, view it on GitHub
<#4747 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASLW27KAQJ3OXTTWDKRIELLWDUI33ANCNFSM6AAAAAAQIN7XNU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@raolivei13, @vboomi , how is the review process going? |
@raolivei13 @vboomi could you please provide an update on your review process? |
Hello, Best, |
@raolivei13, thank you for the important comment. |
Hi @raolivei13, thank you for that comment on reproducing the hardware. I agree that it is a bit ambiguous whether the hardware is also meant to be reproduced. Nonetheless, this is something we did strive to achieve (reproducibility of hardware and accessibility of components), and you can find the instructions on building the camera in the blog post that is referenced in the README and the "About" section of the repository. Moreover, I just added another comment in the Setup section. It is also mentioned in Line 80 of the paper. Please let me know if you think there is another way this information could be made clearer. We opted for a Medium article as we found it to be a much more friendlier/interactive way to present the hardware side of things:
But if you feel like more of this info should be place in the README, let us know! |
@editorialbot generate pdf |
I've updated the PDF as there have been developments in the project, most notably:
|
@siddiquesalman, are you able to join this review in place of @vivek? |
@editorialbot generate pdf |
@danasolav, thank you for the detailed and very helpful comments! I've addressed everything in the above generated PDF. Please let me know if I missed anything. Below are some comments on a few of your points:
The purpose is to compare:
to show that reconstructions aren’t as good and limited to grayscale. I’ve done a new measurement with DiffuserCam so that the image is the same for both cameras in Figure 1.
In the Docker compiled version (without line numbers) it renders correctly, example. Could it be an artifact from the peer-reviewed version with line numbers?
I’ve added more description about each metric, their limits, and links/references. In 154-160, I’ve added an interpretation of Figure 6 and Table 2, which motivates the next section on using measured / simulated data. |
Hi @danasolav, just wondering if you had time to look at the changes I made and if they satisfy your points? We'll be presenting LenslessPiCam as demo at a conference next week, and would be great (if possible) to have it published by then. Thanks! |
@editorialbot check references |
|
@ebezzam @raolivei13 @siddiquesalman, Thank you all for your good work and for recommending acceptance of this submission! |
@danasolav, @raolivei13, @siddiquesalman thank you for your input and taking the time to review the work! @danasolav here is the DOI: 10.5281/zenodo.8036869 |
@editorialbot set https://doi.org/10.5281/zenodo.8036869 as archive |
Done! archive is now 10.5281/zenodo.8036869 |
@editorialbot set v1.0.4 as version |
Done! version is now v1.0.4 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4321, then you can now move forward with accepting the submission by compiling again with the command |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@ebezzam I've checked the repository, the paper, the archive link, and this review issue. All seems in order and I will now proceed to process this work for acceptance in JOSS. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@ebezzam congratulations on this publication in JOSS! @danasolav thanks for editing this submission! And a special thanks to the reviewers: @raolivei13, @siddiquesalman !!!!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @ebezzam (Eric Bezzam)
Repository: https://github.com/LCAV/LenslessPiCam
Branch with paper.md (empty if default branch):
Version: v1.0.4
Editor: @danasolav
Reviewers: @raolivei13, @siddiquesalman
Archive: 10.5281/zenodo.8036869
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@antipa & @vboomi & @raolivei13, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danasolav know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @raolivei13
📝 Checklist for @siddiquesalman
The text was updated successfully, but these errors were encountered: