New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: HiPart: Hierarchical divisive clustering toolbox #5024
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Checking the BibTeX entries failed with the following error:
|
|
Wordcount for |
Review checklist for @jjerphanConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
This is the review thread. Firstly, type
to generate your own checklist. In that checklist, there are 23 check items. Whenever you complete the corresponding task, you can check off them. Please write your comments as separate posts and do not modify your checklist descriptions. The review process is interactive so you can always interact with the authors, reviewers, and the editor. You can also create issues and pull requests in the target repo. Please do mention this thread's URL in the issues so we can keep tracking what is going on out of our world. Please do not hesitate to ask me about anything, anytime. Thank you in advance! |
Review checklist for @AP6YCConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot check references |
Checking the BibTeX entries failed with the following error:
|
@editorialbot generate pdf |
I started reviewing the HiPart in the last few days. I am drafting panagiotisanagnostou/HiPart#19 to provide explicit suggestions for the repository. |
Hi @jbytecode, I did a first review and need to find some time to get in the details for the last items which are not checked yet (e.g. reproducing results) and provide comprehensive feedback to authors. To me, I am on track. |
@jjerphan - I am appreciated of your great effort and spending your valuable time for JOSS. Thank you for your quick response. |
You are welcome. Ideally I will finish my review this weekend. |
@jjerphan Sorry for the delay; I am prioritizing my review and suggestions to the authors to be complete this week. |
A remark of Conflict of interestI am one of the maintainers of scikit-learn which is providing reference implementation of clustering algorithms. I do not have any conflict of interest in the favor of the acceptance of the rejection of this paper: scikit-learn contributors and maintainers welcome qualitative third party packages extending scikit-learn in the ecosystem. Last review items' clarificationAs of https://github.com/panagiotisanagnostou/HiPart/tree/f6c0d3785741f752a5a2cecafcef1d1eb03347bb, I have not checked the following 7 items of the 21 items mainly because I have questions, remarks or suggestions to improve of them:
Bellow are my questions, remarks or suggestions for each of them.
It is clear that @panagiotisanagnostou is the main major contributor to HiPart. @stevestavropoulos also has contributed notable to HiPart. To validate this item I would like to know the rationale for other authors' presence given that authors are indicated as having contributed equally.
I think HiPart is rather small as a package with perfectible aspects. To me, HiPart currently do not meet all the criteria for being eligible to be published in JOSS. Yet, I think it is on track and that this submission is appreciable and legitimate. Perfectible aspects of HiPart are:
I unfortunately can't reproduce results (benchmarks and figures) using script in To validate this item, please do check that those scripts work (I think using relative paths might help prevent issues). Moreover, from my reading of the implementations (which are mainly backed by NumPy), I hardly think implementations can be scalable or efficient for the targeted problems. I can't say if HiPart is completely functional, is performant, and if claims are backed by reproducible results.
Guidelines for 2) and 3) are clear to me but guidelines for 1) are missing. Adding a simple contributing guide as
See panagiotisanagnostou/HiPart#23 for remarks for this items. |
@AP6YC: I am not sure if you instead intended to mention @jbytecode. To me, it's fine: you still have at least two weeks left. 🙂 |
|
@panagiotisanagnostou - Could you please try adding missing DOI's as the editorial bot suggests? Addition to this, a single DOI seems to be invalid (you can replace the http header part and just include the DOI info). |
@jbytecode I will apply all the changes as soon as possible, at the same time with the post-review checklist completion. |
@jbytecode I am happy to tell you that the I have done the final checks required by the post review process.
I hope everything is in order now. |
@editorialbot check references |
|
@editorialbot generate pdf |
@editorialbot set v0.3.1 as version |
Done! version is now v0.3.1 |
@editorialbot set 10.5281/zenodo.7814113 as archive |
Done! Archive is now 10.5281/zenodo.7814113 |
@editorialbot recommend-accept |
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4108, then you can now move forward with accepting the submission by compiling again with the command |
|
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@AP6YC, @jjerphan – many thanks for your reviews here and to @jbytecode for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @panagiotisanagnostou – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you for this message and for managing the edition of the JOSS, @arfon. I am relatively glad of this first review. I will try to be a bit more reactive for the subsequent ones, if I have time to review any other submissions. |
@arfon, @jbytecode, @AP6YC, and @jjerphan, thank you for a great review process. I enjoyed working with all of you. I hope, in the future, to have more projects for submission to this journal. |
Submitting author: @panagiotisanagnostou (Panagiotis Anagnostou)
Repository: https://github.com/panagiotisanagnostou/HiPart
Branch with paper.md (empty if default branch): paper
Version: v0.3.1
Editor: @jbytecode
Reviewers: @AP6YC, @jjerphan
Archive: 10.5281/zenodo.7814113
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@AP6YC & @jjerphan, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jjerphan
📝 Checklist for @AP6YC
The text was updated successfully, but these errors were encountered: