Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: PreliZ: A tool-box for prior elicitation #5208

Closed
editorialbot opened this issue Mar 2, 2023 · 31 comments
Closed

[PRE REVIEW]: PreliZ: A tool-box for prior elicitation #5208

editorialbot opened this issue Mar 2, 2023 · 31 comments
Assignees
@djmannion @olexandr-konovalov @jungtaekkim
Labels
Jupyter Notebook pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 2, 2023 •
edited

Submitting author: @aleicazatti (Alejandro Icazatti)
Repository: https://github.com/arviz-devs/preliz
Branch with paper.md (empty if default branch):
Version: v0.2.0
Editor: @olexandr-konovalov
Reviewers: @jungtaekkim, @djmannion
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f1dadc218c75287b631c0313afb64b1f"><img src="https://joss.theoj.org/papers/f1dadc218c75287b631c0313afb64b1f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f1dadc218c75287b631c0313afb64b1f/status.svg)](https://joss.theoj.org/papers/f1dadc218c75287b631c0313afb64b1f)

Author instructions

Thanks for submitting your paper to JOSS @aleicazatti. Currently, there isn't a JOSS editor assigned to your paper.

@aleicazatti if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Mar 2, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.09 s (602.0 files/s, 127522.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          28           1450           1866           4267
Markdown                         8             84              0            221
Jupyter Notebook                 6              0           2690            144
TeX                              1             12              0            140
YAML                             4             14              2            115
TOML                             1              9              0             51
reStructuredText                 2             36             27             36
DOS Batch                        1              8              1             26
make                             1              6              7             13
CSS                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                            53           1619           4593           5016
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 820

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.01143 is OK
- 10.1007/s11104-022-05329-0 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK

MISSING DOIs

- 10.31219/osf.io/fcmun may be a valid DOI for title: Prior Setting in Practice: Strategies and Rationales Used in Choosing Prior Distributions for Bayesian Analysis

INVALID DOIs

- https://doi.org/10.1016/j.envsoft.2013.10.010 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

aleicazatti added a commit to aleicazatti/preliz that referenced this issue Mar 2, 2023
@aleicazatti
Apply suggestions from JOSS editorial bot
3d185bd 
* Add missing doi for sarma:2020
* Fix doi for morris:2014

openjournals/joss-reviews#5208
@aleicazatti aleicazatti mentioned this issue Mar 2, 2023
Merged
aleicazatti added a commit to arviz-devs/preliz that referenced this issue Mar 2, 2023
@aleicazatti
Apply suggestions from JOSS editorial bot (#221)
1a97648 
* Add missing doi for sarma:2020
* Fix doi for morris:2014

openjournals/joss-reviews#5208
@arfon
Copy link
Member

arfon commented Mar 4, 2023

@aleicazatti - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Mar 4, 2023
@aleicazatti
Copy link

@arfon - thank you for notifying us!

@arfon
Copy link
Member

arfon commented Apr 25, 2023

@editorialbot assign @olexandr-konovalov as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @olexandr-konovalov is now the editor

@arfon arfon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Apr 25, 2023
@arfon
Copy link
Member

arfon commented Apr 25, 2023

👋 @aleicazatti – I'm delighted to say that @olexandr-konovalov has kindly agreed to edit this submission. He's a little busy for the next week or so but will be picking this up 🔜

@aleicazatti
Copy link

Thanks for the update, @arfon. And thanks @olexandr-konovalov for accepting to edit this submission. Very much appreciated!

@olexandr-konovalov
Copy link
Member

@lindemann09 @jungtaekkim - would one or both of you be able to review this submission for JOSS, please?

If not, could you possibly recommend someone whom we may approach regarding this?

@lindemann09
Copy link

@olexandr-konovalov

Sorry, that is not my field of expertise and I find it difficult to review. I can therefore also not suggest someone from my professional network.

@jungtaekkim
Copy link

@olexandr-konovalov

I think I can review this paper. Please assign me as a reviewer.

@olexandr-konovalov
Copy link
Member

@editorialbot add @jungtaekkim as reviewer

@jungtaekkim thank you very much! I will start the review as soon as we will know another reviewer.

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@olexandr-konovalov
Copy link
Member

@djmannion @GregoryAshton - would one of you be able to review this submission for JOSS, please?

If not, could you possibly recommend someone whom we may approach regarding this?

@olexandr-konovalov
Copy link
Member

@editorialbot add @jungtaekkim as reviewer

@editorialbot
Copy link
Collaborator Author

@jungtaekkim added to the reviewers list!

@djmannion
Copy link

@djmannion @GregoryAshton - would one of you be able to review this submission for JOSS, please?

Sure, I'd be happy to review it.

@GregoryAshton
Copy link

@djmannion @GregoryAshton - would one of you be able to review this submission for JOSS, please?

If not, could you possibly recommend someone whom we may approach regarding this?

I am sorry, but at this time I can't commit to reviews. My apologies.

@olexandr-konovalov
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@olexandr-konovalov
Copy link
Member

@editorialbot add @djmannion as reviewer

@editorialbot
Copy link
Collaborator Author

@djmannion added to the reviewers list!

@olexandr-konovalov
Copy link
Member

olexandr-konovalov commented May 28, 2023 •
edited

@aleicazatti I have checked the latest article proof - before I will open the review for @djmannion and @jungtaekkim, would you be able to address some suggestions of mine, please?

  • fix references (e.g. all of them in the "Statement of need" are not resolved)
  • the reference to Morris et al. (page 2, line 46) does not have to be in quotes
  • fix markdown (e.g. line 38 p.1) - instead of quotes, it should look like code in line 51, p.3
  • same in line 44, page 2
  • Fix figure captions (repeated word "Figure")
  • check the use of punctuation and capitalisation in Acknowledgements

References:

@aleicazatti aleicazatti mentioned this issue May 29, 2023
Merged
@olexandr-konovalov
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@olexandr-konovalov
Copy link
Member

Thanks for updates @aleicazatti!

@olexandr-konovalov
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djmannion djmannion

@olexandr-konovalov olexandr-konovalov

@jungtaekkim jungtaekkim

Labels
Jupyter Notebook pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@arfon @djmannion @GregoryAshton @lindemann09 @olexandr-konovalov @aleicazatti @jungtaekkim @editorialbot