-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: repytah
: An Open-Source Python Package That Builds Aligned Hierarchies for Sequential Data Streams
#5213
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Dear Reviewers @Rocsg and @ranzhengcode This is the review thread. Firstly, type
to generate your own checklist. In that checklist, there are 23 check items. Whenever you complete the corresponding task, you can check off them. Please write your comments as separate posts and do not modify your checklist descriptions. The review process is interactive so you can always interact with the authors (@kmkinnaird ), reviewers, and the editor (me). You can also create issues and pull requests in the target repo. Please do mention this thread's URL in the issues so we can keep tracking what is going on out of our world. Please do not hesitate to ask me about anything, anytime. Thank you in advance! |
Review checklist for @RocsgConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @ranzhengcodeConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 @jbytecode @ranzhengcode Have a nice week Romain |
@Rocsg - thank you for your comments. @ranzhengcode - It seems you've performed a full check in a relatively short time. thank you. could you please provide your review and thoughts here or in issues in the target repo? thank you in advance. |
@jbytecode Dear jbytecode, I have completely checked and tried repytah on my computer and was able to run all instances properly according to the author's instructions. As I am not an expert in music and data processing, I don't have a more pertinent advice for authors, but I think the work is still very interesting to accept. |
Thank you @Rocsg for your detailed review. We have responded in the issue that you created smith-tinkerlab/repytah#426 Thank you @ranzhengcode for your kind words. Let us know if there is anything additional that you would like us to add or if there are questions that we can answer regarding the changes made in response to @Rocsg's review |
Hello @jbytecode . I did receive the answers and I am planning to fulfill my checklist early next week. I keep both of you in touch. I Wish you all a nice weekend. Romain |
@editorialbot generate pdf |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@editorialbot check references |
|
@editorialbot generate pdf |
@kmkinnaird - I've just sent a pull request that includes some minor changes on both the manuscript and the bibliography: Please review the changes. If you are agreed with them, please merge. Thank you in advance. |
I see both the Post Review Checklist and your comment above. I will complete the checklist and review the changes by May 5th. Thank you! |
Done! archive is now 10.5281/zenodo.7931423 |
@editorialbot check references |
|
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4224, then you can now move forward with accepting the submission by compiling again with the command |
@kmkinnaird - I'm the track editor who will handle the final processing of your submission. I've proofread the draft, and the paper looks fine to me, but some references need work. Specifically, there are a few references that are of type article that should be of type inproceedings, such as Casey & Slaney 2006a, Casey & Slaney 2006b, Casey & Slaney 2007, and Sapp 2005. The conference name should also be written out in these cases, as it is in others already. Please fix these, then ping me here, and I'll continue the process of acceptance and publication. |
@danielskatz - Thanks for your note and for introducing yourself. I believe that I've fixed all the references to include the full conference names as well as consistent presentation for the author names. The current draft is in the One question: are the use of acronyms correct or should I remove them? |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4225, then you can now move forward with accepting the submission by compiling again with the command |
This looks good now - thanks! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @kmkinnaird (Katherine M. Kinnaird) and co-authors!! And thanks to @Rocsg and @ranzhengcode for reviewing, and to @jbytecode for editing! (I'll also note that the DOI doesn't resolve, and it normally should by now - I'll leave this open until it is working.) |
Thank you @Rocsg, @ranzhengcode, @jbytecode, and @danielskatz for all your work during this reviewing process. It was a really great reviewing experience! |
the DOI is now resolving for me - thanks again to everyone! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @kmkinnaird (Katherine M. Kinnaird)
Repository: https://github.com/smith-tinkerlab/repytah
Branch with paper.md (empty if default branch):
Version: v0.1.2
Editor: @jbytecode
Reviewers: @Rocsg, @ranzhengcode
Archive: 10.5281/zenodo.7931423
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@Rocsg & @ranzhengcode, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @Rocsg
📝 Checklist for @ranzhengcode
The text was updated successfully, but these errors were encountered: