Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: Regl-Scatterplot: A Scalable Interactive JavaScript-based Scatter Plot Library #5275

Closed
editorialbot opened this issue Mar 20, 2023 · 70 comments
Assignees
Labels
accepted HTML JavaScript published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 20, 2023

Submitting author: @flekschas (Fritz Lekschas)
Repository: https://github.com/flekschas/regl-scatterplot
Branch with paper.md (empty if default branch):
Version: v1.6.3
Editor: @fabian-s
Reviewers: @Fil, @xiaohk
Archive: 10.5281/zenodo.7796642

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f856311196a1e2977a0109730435f42f"><img src="https://joss.theoj.org/papers/f856311196a1e2977a0109730435f42f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f856311196a1e2977a0109730435f42f/status.svg)](https://joss.theoj.org/papers/f856311196a1e2977a0109730435f42f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Fil & @xioahk, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fabian-s know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @xiaohk

📝 Checklist for @Fil

@editorialbot editorialbot added HTML JavaScript review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Mar 20, 2023
@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.14 s (336.3 files/s, 251157.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             3              0              0          22265
JavaScript                      31           1694            633           8453
Markdown                         3            415              0           1069
HTML                             1             73              0            576
TeX                              1             31              0            246
TypeScript                       1             21             10            186
YAML                             4             10              4             96
F#                               4             18              2             44
-------------------------------------------------------------------------------
SUM:                            48           2262            649          32935
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 851

@fabian-s
Copy link

👋🏼 @flekschas @Fil @xiaohk this is the review thread for the paper. All of our communications will happen here from now on.

As a reviewer, the first step is to create a checklist for your review by entering

@editorialbot generate my checklist

as the top of a new comment in this thread.

These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#5275 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time.

Please feel free to ping me (@fabian-s) if you have any questions/concerns.

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/cgf.13971 is OK
- 10.1145/3334480.3381443 is OK
- 10.1109/TVCG.2021.3114820 is OK
- 10.1145/3491102.3502102 is OK
- 10.1109/TVCG.2022.3209378 is OK
- 10.1109/TVCG.2017.2674978 is OK
- 10.1109/TVCG.2011.185 is OK
- 10.1109/TVCG.2016.2599030 is OK
- 10.48550/ARXIV.1708.07747 is OK
- 10.48550/ARXIV.1802.03426 is OK
- 10.48550/ARXIV.1312.6114 is OK
- 10.1080/14786440109462720 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@xiaohk
Copy link

xiaohk commented Mar 20, 2023

@editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

@xiaohk I can't do that because you are not a reviewer

@fabian-s
Copy link

@editorialbot add @xiaohk as reviewer

@editorialbot
Copy link
Collaborator Author

@xiaohk added to the reviewers list!

@fabian-s
Copy link

.. should work now, I hope @xiaohk
sorry again! 🙈

@fabian-s
Copy link

@editorialbot remove @xioahk as reviewer

@editorialbot
Copy link
Collaborator Author

@xioahk removed from the reviewers list!

@xiaohk
Copy link

xiaohk commented Mar 20, 2023

Review checklist for @xiaohk

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/flekschas/regl-scatterplot?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@flekschas) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@Fil
Copy link

Fil commented Mar 22, 2023

Review checklist for @Fil

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/flekschas/regl-scatterplot?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@flekschas) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@xiaohk
Copy link

xiaohk commented Mar 29, 2023

I finished my review. All items on my check list are checked out. I noticed a minor stying issue in the reference list (flekschas/regl-scatterplot#109). I think the paper is ready to be accepted after that issue is resolved. Thanks!

@xiaohk
Copy link

xiaohk commented Mar 31, 2023

Hi @fabian-s, all my issues were addressed in flekschas/regl-scatterplot#110. I think this paper is ready to go!

@fabian-s
Copy link

fabian-s commented Apr 3, 2023

Thank you all for your quick and constructive collaboration on this!

@fabian-s
Copy link

fabian-s commented Apr 3, 2023

@editorialbot check references

@fabian-s
Copy link

fabian-s commented Apr 3, 2023

@editorialbot generate pdf

@fabian-s
Copy link

@editorialbot recommend-accept

EiCs: note that the "invalid" DOI editorialbot complains about is valid but refers to a document that is not yet published / updated in the DOI.org database

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4109, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Apr 11, 2023
@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/cgf.13971 is OK
- 10.1145/3334480.3381443 is OK
- 10.1109/TVCG.2021.3114820 is OK
- 10.1145/3491102.3502102 is OK
- 10.1109/TVCG.2022.3209378 is OK
- 10.1109/TVCG.2017.2674978 is OK
- 10.1109/TVCG.2011.185 is OK
- 10.1109/TVCG.2016.2599030 is OK
- 10.48550/ARXIV.1708.07747 is OK
- 10.48550/ARXIV.1802.03426 is OK
- 10.48550/ARXIV.1312.6114 is OK
- 10.1080/14786440109462720 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1145/3544548.3581268 is INVALID

@fabian-s
Copy link

@fabian-s Could you make the editorialbot try it again? I've removed the ISBN numbers from two references, which I suspect might have been incorrect. The authors, title, year, journal, publisher, DOI, etc. should suffice.

thx, that seems to have done the trick 👍

@fabian-s
Copy link

EiCs: note that the "invalid" DOI editorialbot complains about is valid but refers to a document that is not yet published / updated in the DOI.org database

@flekschas
Copy link

Thanks for rerunning the editorialbot @fabian-s

@danielskatz
Copy link

@flekschas - As the next step, I'll be proofreading this shortly and will get back with any needed actions

@danielskatz
Copy link

@flekschas - there's a references heading missing - flekschas/regl-scatterplot#115 will fix it

@flekschas
Copy link

@danielskatz Thanks for proofreading and putting together the PR! I've merged the it.

@danielskatz
Copy link

Also, here are a bunch of changes for the bib to fix casing - flekschas/regl-scatterplot#116

@flekschas
Copy link

Merged

@danielskatz
Copy link

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4111, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/cgf.13971 is OK
- 10.1145/3334480.3381443 is OK
- 10.1109/TVCG.2021.3114820 is OK
- 10.1145/3491102.3502102 is OK
- 10.1109/TVCG.2022.3209378 is OK
- 10.1109/TVCG.2017.2674978 is OK
- 10.1109/TVCG.2011.185 is OK
- 10.1109/TVCG.2016.2599030 is OK
- 10.48550/ARXIV.1708.07747 is OK
- 10.48550/ARXIV.1802.03426 is OK
- 10.48550/ARXIV.1312.6114 is OK
- 10.1080/14786440109462720 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1145/3544548.3581268 is INVALID

@danielskatz
Copy link

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Lekschas
  given-names: Fritz
  orcid: "https://orcid.org/0000-0001-8432-4835"
doi: 10.5281/zenodo.7796642
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Lekschas
    given-names: Fritz
    orcid: "https://orcid.org/0000-0001-8432-4835"
  date-published: 2023-04-11
  doi: 10.21105/joss.05275
  issn: 2475-9066
  issue: 84
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 5275
  title: "Regl-Scatterplot: A Scalable Interactive JavaScript-based
    Scatter Plot Library"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.05275"
  volume: 8
title: "Regl-Scatterplot: A Scalable Interactive JavaScript-based
  Scatter Plot Library"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.05275 joss-papers#4112
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05275
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Apr 11, 2023
@flekschas
Copy link

Thanks everyone! DOI seems to work fine and the PDF appears on JOSS! 🎉🌈🦄💃👻🤘

@danielskatz
Copy link

Congratulations to @flekschas on your publication!

And thanks to @Fil and @xiaohk for reviewing, and to @fabian-s for editing!
We couldn't do this without you

@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05275/status.svg)](https://doi.org/10.21105/joss.05275)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05275">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05275/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05275/status.svg
   :target: https://doi.org/10.21105/joss.05275

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@xiaohk
Copy link

xiaohk commented Apr 11, 2023

Congrats!! @flekschas 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted HTML JavaScript published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

6 participants