New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Regl-Scatterplot: A Scalable Interactive JavaScript-based Scatter Plot Library #5275
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
👋🏼 @flekschas @Fil @xiaohk this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@fabian-s) if you have any questions/concerns. |
|
@editorialbot generate my checklist |
@xiaohk I can't do that because you are not a reviewer |
@editorialbot add @xiaohk as reviewer |
@xiaohk added to the reviewers list! |
.. should work now, I hope @xiaohk |
@editorialbot remove @xioahk as reviewer |
@xioahk removed from the reviewers list! |
Review checklist for @xiaohkConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @FilConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I finished my review. All items on my check list are checked out. I noticed a minor stying issue in the reference list (flekschas/regl-scatterplot#109). I think the paper is ready to be accepted after that issue is resolved. Thanks! |
Hi @fabian-s, all my issues were addressed in flekschas/regl-scatterplot#110. I think this paper is ready to go! |
Thank you all for your quick and constructive collaboration on this! |
@editorialbot check references |
@editorialbot generate pdf |
@editorialbot recommend-accept EiCs: note that the "invalid" DOI editorialbot complains about is valid but refers to a document that is not yet published / updated in the DOI.org database |
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4109, then you can now move forward with accepting the submission by compiling again with the command |
|
thx, that seems to have done the trick 👍 |
EiCs: note that the "invalid" DOI editorialbot complains about is valid but refers to a document that is not yet published / updated in the DOI.org database |
Thanks for rerunning the editorialbot @fabian-s |
@flekschas - As the next step, I'll be proofreading this shortly and will get back with any needed actions |
@flekschas - there's a references heading missing - flekschas/regl-scatterplot#115 will fix it |
@danielskatz Thanks for proofreading and putting together the PR! I've merged the it. |
Also, here are a bunch of changes for the bib to fix casing - flekschas/regl-scatterplot#116 |
Merged |
@editorialbot recommend-accept |
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4111, then you can now move forward with accepting the submission by compiling again with the command |
|
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Thanks everyone! DOI seems to work fine and the PDF appears on JOSS! 🎉🌈🦄💃👻🤘 |
Congratulations to @flekschas on your publication! And thanks to @Fil and @xiaohk for reviewing, and to @fabian-s for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Congrats!! @flekschas 🎉 |
Submitting author: @flekschas (Fritz Lekschas)
Repository: https://github.com/flekschas/regl-scatterplot
Branch with paper.md (empty if default branch):
Version: v1.6.3
Editor: @fabian-s
Reviewers: @Fil, @xiaohk
Archive: 10.5281/zenodo.7796642
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@Fil & @xioahk, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fabian-s know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @xiaohk
📝 Checklist for @Fil
The text was updated successfully, but these errors were encountered: