New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: A Python package for homogenization procedures in fiber reinforced polymers #5295
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Hi everybody and thank you for your volunteering. I hope that we together can have a good review experience :) |
Review checklist for @nicoguaroConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@Extraweich, I do not find installation instructions. |
@nicoguaro, you can find them in the docs. Do they need to be in the README in the repository, too? |
I could not find the instruction in the docs. |
Review checklist for @likaskConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Am I right in assuming that you have found them by now? :) |
@likask, @nicoguaro, @lizarett thanks again for your help with this review. Could you provide an update on review progress? Let me know if I can help with anything. Thanks. |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
Review checklist for @lizarettConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
The paper/documentation appears to be well-written in general. The main comments currently are for the authors to describe in more details (in the documentation) the actual limitations of the implemented mathematical formulations, including geometrical shapes of initial material samples, number of materials allowed, relevant characteristics, etc. Some papers on the Mori-Tanaka method indicate a limited range of validity in terms of several parameters. The documentation of HomoPy uses "alternative forms", and it would be helpful to clarify, what kind of limitations are currently in place for the user. This may reiterate the published literature (papers, not code libraries), but, imo, it is worth it. |
@lizarett thank you for your comment. Could you clarify a bit more to what extend you expect a derivation in the docs? The Git repository has a section for each homogenization procedure used in HomoPy in the README. Within these sections, the scope is mentioned and papers are referenced for the interested user to gain further insight into the reasons for limitations. My suggestion would be to add these sections to the docs as well and explicitly state the limitations (shapes, material symmetry, number of inclusions, etc.). |
@lizarett can you get back to @Extraweich on the above ☝️ ? Thanks |
Yes, this sounds good. Thank you. |
I added a "Scope and limitations" section to the docs. I would be happy if you could check it out and see if this suits your suggestions :) |
@lizarett can you check this ☝️ |
@Extraweich @Kevin-Mattheus-Moerman all works for me and explained sufficiently, except the fiberoripy example didn't run, but this is my issue, not yours. i think all is fine |
@lizarett thanks. Let me know if you are happy to formally recommend acceptance. If you do think that example should run I would encourage you to post an issue on that and get that resolved first. Let me know which route you feel is best. Thanks |
The example requires to install another Python package, which is not required in HomoPy directly. |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@Extraweich we will now proceed to process this work towards acceptance in JOSS. Above are the final steps we need to work on. Can you take care of these author tasks? |
@Extraweich side note, I created a PR which is not a requirement for this review but aims to fix a rendering issue with the logo in the README: Extraweich/homopy#24 |
@editorialbot check references |
|
@Kevin-Mattheus-Moerman, I checked all the points on the list. I guess that you need to cross them for me, though. |
@editorialbot set 10.5281/zenodo.8124344 as archive |
Done! archive is now 10.5281/zenodo.8124344 |
|
Hi @Kevin-Mattheus-Moerman, I changed the name of the ZENODO archive to match the paper title.
Edit: I confused contributors with authors. I think it should be correct now. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4392, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@Extraweich congratulations on this JOSS publication! A special thanks to the fantastic reviewers! @likask, @nicoguaro, @lizarett |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you very much everybody for reviewing the paper and providing a valuable input. Special thanks to @Kevin-Mattheus-Moerman for the awesome communication and editorial work. :) |
@editorialbot reaccept |
|
🌈 Paper updated! New PDF and metadata files 👉 openjournals/joss-papers#4483 |
Submitting author: @Extraweich (Nicolas Christ)
Repository: https://github.com/Extraweich/homopy
Branch with paper.md (empty if default branch):
Version: v1.1.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @likask, @nicoguaro, @lizarett
Archive: 10.5281/zenodo.8124344
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@likask & @nicoguaro & @lizarett, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @likask
📝 Checklist for @nicoguaro
📝 Checklist for @lizarett
The text was updated successfully, but these errors were encountered: