New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PINA: Physics-Informed Neural networks for Advance modeling #5352
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@yorkiva, @y-yao, and @akshaysubr - Thanks for agreeing to review this submission. As you can see above, you each should use the command As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if either of you require some more time. We can also use editorialbot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@danielskatz) if you have any questions/concerns. |
Review checklist for @y-yaoConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot @ndem0 I didn't see any formal API documentaion page in the repo. For example, what are the assumptions and constraints of the various API functions. |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot commands |
Hello @y-yao, here are the things you can ask me to do:
|
@y-yao - As you've discovered, |
👋 @yorkiva and @akshaysubr - if you could also generate your checklists as in the instructions above, and at least check off the first two items, I would appreciate it, even if you don't have time to start on the technical parts of the review yet. |
Review checklist for @yorkivaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 @akshaysubr - if you could generate your checklist as in the instructions above, and at least check off the first two items, I would appreciate it, even if you don't have time to start on the technical parts of the review yet. |
Review checklist for @akshaysubrConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 @yorkiva and @akshaysubr - how are your reviews coming? |
👋 @ndem0 & @y-yao - do you think mathLab/PINA#78 is done now, or is more needed? (I'm just wondering if it should be closed or not) |
@danielskatz I think mathLab/PINA#78 can be closed. |
Hi @danielskatz, I will try to get a few more action items looked at this weekend. However, I am going away for a conference next week, so the rest will have to wait till I come back. |
Yes, I'm satisfied with the submission after the changes and can be accepted now. |
@ndem0 - At this point could you:
I can then move forward with recommending acceptance of the submission, which will include me generating a draft and then proofreading it |
Dear @danielskatz, I should have done all the points!
I double checked and everything looks correct to me, but let me know if there are some problem and I'll fix asap! Thanks |
@editorialbot set 10.5281/zenodo.8163732 as archive |
Done! archive is now 10.5281/zenodo.8163732 |
@editorialbot set 0.0.3-joss as version |
Done! version is now 0.0.3-joss |
@ndem0 - in the zenodo repo, the authors are just listed by a single name (surname? github ID?). Please change these to actual names to match the paper's authors. (Note this just requires changing the metadata in the zenodo archive, not creating a new version) |
Yes there were some errors, now the authors string is fine |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4415, then you can now move forward with accepting the submission by compiling again with the command |
@ndem0 - I'm suggesting some minor changes in mathLab/PINA#161 - please merge this, or let me know what you disagree with, then we can proceed to publication |
Sure, I've already merged it! Thanks for the effort! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4416, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @ndem0 (Nicola Demo) and co-authors on your publication!! And thanks to @yorkiva, @y-yao, and @akshaysubr for reviewing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @ndem0 (Nicola Demo)
Repository: https://github.com/mathLab/PINA
Branch with paper.md (empty if default branch):
Version: 0.0.3-joss
Editor: @danielskatz
Reviewers: @yorkiva, @y-yao, @akshaysubr
Archive: 10.5281/zenodo.8163732
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@yorkiva & @y-yao & @akshaysubr, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @yorkiva
📝 Checklist for @y-yao
📝 Checklist for @akshaysubr
The text was updated successfully, but these errors were encountered: