New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: QAOA.jl: Toolkit for the Quantum and Mean-Field Approximate Optimization Algorithms #5364
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@babreu-ncsa, @pkairys, and @Abinashbunty - Thanks for agreeing to review this submission. As you can see above, you each should use the command As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if either of you require some more time. We can also use editorialbot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@danielskatz) if you have any questions/concerns. |
👋 @timbode - Please fix the missing DOI that editorialbot suggests. Please feel free to make changes to your .bib file, then use the command |
Review checklist for @AbinashbuntyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @pkairysConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
For the referenced checklist item, I am going to mark it as ☑️ based on #5347 (comment) and the reaction to it by @danielskatz |
Thanks @Abinashbunty for catching that typo! I'll fix the missing DOI asap. |
@editorialbot generate pdf |
@editorialbot check references |
|
For this item of checklist, my review + #5347 (comment) suffices for this to be marked as checked. 👍🏼 |
Review checklist for @babreu-ncsaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 @babreu-ncsa, @pkairys, @Abinashbunty - Can I get an update from each of you on how your reviews are coming, and what is needed to move them forward? |
@danielskatz Some components I'll have to execute on my machine and then my review will be over. Major part of my review is over. In case things run well, it'll be quicker else I'll advise the author(s) to make the necessary changes. |
@danielskatz thanks for the push, I'm running behind. I'll expedite the review this week. |
Thanks for your efforts - I'll address all shortcomings once you're done. |
@timbode - At this point could you:
I can then move forward with recommending acceptance of the submission. |
@danielskatz I will try doing all of the above from a mobile device. Let’s see if it’s possible. If not, it will have to wait until the week after next. |
The version tag is v1.0.1. |
|
Seems it all worked! |
@editorialbot set v1.0.1 as version |
Done! version is now v1.0.1 |
@editorialbot set 10.5281/zenodo.8086187 as archive |
Done! archive is now 10.5281/zenodo.8086187 |
@editorialbot recommend-accept (I will proofread the version that this produces, and let you know if I see anything that should be changed.) |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4353, then you can now move forward with accepting the submission by compiling again with the command |
👋 @timbode - I'm suggesting some small changes in FZJ-PGI-12/QAOA.jl#31 In addition, there's something wrong with the first reference. The DOI doesn't match the title, while the DOI that does match the title seems to be https://doi.org/10.5281/zenodo.2562111 but the authors don't match this archive, so I'm not sure what should be done to fix this. Please go ahead and merge my PR (or let me know what you disagree with, and fix the first reference, then ping me here and I'll create a new proof. |
@danielskatz I’ve switched to the Zenodo reference you found. I hope it works now in spite of me doing this via mobile. I’ve also merged your corrections in the paper, thanks for that. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4356, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @timbode (Tim Bode) and co-authors on your publication!! And thanks to @babreu-ncsa, @pkairys, and @Abinashbunty for reviewing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @timbode (Tim Bode)
Repository: https://github.com/FZJ-PGI-12/QAOA.jl
Branch with paper.md (empty if default branch):
Version: v1.0.1
Editor: @danielskatz
Reviewers: @babreu-ncsa, @pkairys, @Abinashbunty
Archive: 10.5281/zenodo.8086187
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@babreu-ncsa & @pkairys & @Abinashbunty, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @pkairys
📝 Checklist for @Abinashbunty
📝 Checklist for @babreu-ncsa
The text was updated successfully, but these errors were encountered: