New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PII-Codex: a Python library for PII detection, categorization, and severity assessment #5402
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@gradvohl – This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. Please create your checklist typing:
As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
@gradvohl – as I mentioned in the pre-review thread, would you mind copying your review over into this review thread too to make sure things are all linked up here? |
Review checklist for @gradvohlConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Reviewer report for JOSS paper #5042Paper title: PII-Codex: a Python library for PII detection, categorization, and severity assessment Review criteriaNote: Whenever I marked an item with
Review items
Test environmentWe try to run the software on Rocky Linux X86_64 computer, but the installation fails. Reviewer commentsThe following comments refer to items the author could improve to meet JOSS submission requirements. About authors and their affiliationThe repository needs to clearly show who the authors are and their affiliation in the About the statement of needThe About the Installation InstructionsWhen I followed the installation instructions using the command
After that, when I remove the flag
The installation instructions must work as smoothly as possible. About
|
@editorialbot add @tmickleydoyle as reviewer |
@tmickleydoyle added to the reviewers list! |
@tmickleydoyle – This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. Please create your checklist typing:
As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Hello @gradvohl, Can you clarify where you were hoping for more citations? The README briefly touches on the primary citations used to derive categories and the enum types, but papers associated with the problem space were contained in the paper. The Milne types and the risk continuum levels and our ability to map to those types/levels were the primary conceptual targets, but I’m happy to revisit them. I wanted to make sure I understood expectations ahead of merging the next round of updates. Thanks again for the review and your time! |
Thanks for flagging this @EdyVision. @gradvohl – we don't actually require authors to merge the paper into their main/default branch. This is actually why we support compiling the paper from a non-default branch. @EdyVision – I'm assuming you want the review to be of the code on the |
Thanks for confirming, I was afraid I was missing requirements somewhere. Either branch is fine @arfon , I keep the Thank you both very much! |
Hi @EdyVision, Regarding the paper in the About the authors' names in the README.md file, I consider it important that your name is there. As a user, I think it is essential to know who is the author of that software and who is responsible for that code. I know that this information is in In my view, similar reasoning applies to the community contributions guidelines. I know they are in the Regarding the notebook in Google Collab, I saw that everything is implemented there. However, I am left with the question: which branch should I evaluate? The main or the joss-paper-submission? I haven't received any official information about this. If you or the Editor (@arfon) could be so kind as to tell me which branch I should analyze, it would help me a lot and save me time. Regarding citations, the ones you cite in the README.md file -- Milne et al. (2016) and Schwartz and Solove (2012) -- should be referenced in the Anyway, I don't know if I was able to answer your questions, but I remain at your disposal should you need further clarification. |
Ah thank you @gradvohl, this helps! Ok so in my next pushes, I'll add the author details and point them to the |
👋 @tmickleydoyle – just checking in here to see how you're getting on? |
Also, @EdyVision – do you have any updates on how you're getting on making updates based on @gradvohl's feedback? |
Hey! I have been OOO for the last couple weeks. This is on my agenda for next week 🤞 |
Hello @arfon I've actually committed the changes requested by @gradvohl and updated the branch to contain the elements. I know that the largest item was that, for some reason, it couldn't be tested on the host described, but I cannot reproduce this, so I expanded the readme to include more details for setup. As for the mentions of the other projects, I defend them in a few weeks, so I believe I'll be able to expose those projects soon. I'll need to get confirmation from my advisor. That item aside, we are on track with the changes requested, and they are available in the Thanks! |
⚡ thanks so much @tmickleydoyle! |
Review checklist for @tmickleydoyleConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Thank you @gradvohl |
@editorialbot generate pdf |
👋 @EdyVision – some suggested edits to your paper:
|
@EdyVision – Once you've made the suggested changes above, could you make a new release of this software that includes the changes that have resulted from this review. Then, please make an archive of the software in Zenodo/figshare/other service and update this thread with the DOI of the archive? For the Zenodo/figshare archive, please make sure that:
I can then move forward with accepting the submission. |
I can most certaily do that. I believe the archive is in Zenodo presently but I'll double check that the naming match. I'll ping you promptly. |
@editorialbot generate pdf |
@arfon I've confirmed the Zenodo title matches the paper title. For this reason, the title itself was not updated, but the first sentence in the summary, I made sure that PII is accompanied by Version bumped to GitHub: Zenodo DOI for v0.4.4 (meant to be 0.4.5) (paper specific): https://doi.org/10.5281/zenodo.8053024 Zenodo DOI for all versions: https://doi.org/10.5281/zenodo.7170516 Thanks so much, everyone! The release was almost smooth minus the cff file mixup 😅 |
Congrats! Nice work 🎉 |
@editorialbot set 10.5281/zenodo.8053039 as archive |
Done! archive is now 10.5281/zenodo.8053039 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4323, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Thank you! |
Thank you @arfon 🙏🏽 |
@gradvohl, @tmickleydoyle – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @EdyVision – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @EdyVision (Eidan Rosado)
Repository: https://github.com/EdyVision/pii-codex
Branch with paper.md (empty if default branch): joss-paper-submission
Version: 0.4.3
Editor: @arfon
Reviewers: @gradvohl, @tmickleydoyle
Archive: 10.5281/zenodo.8053039
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gradvohl, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @gradvohl
📝 Checklist for @tmickleydoyle
The text was updated successfully, but these errors were encountered: