Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: PAS: a Python Anesthesia Simulator for drug control #5480

Closed
editorialbot opened this issue May 20, 2023 · 77 comments
Closed

[REVIEW]: PAS: a Python Anesthesia Simulator for drug control #5480

editorialbot opened this issue May 20, 2023 · 77 comments
Assignees
Labels
accepted Jupyter Notebook published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 20, 2023

Submitting author: @BobAubouin (Bob Aubouin--Pairault)
Repository: https://github.com/BobAubouin/Python_Anesthesia_Simulator
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @ppxasjsm
Reviewers: @yumuk1989, @JHartzer
Archive: 10.5281/zenodo.8171326

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/61d34ad9ef855a128509b4279e2c9325"><img src="https://joss.theoj.org/papers/61d34ad9ef855a128509b4279e2c9325/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/61d34ad9ef855a128509b4279e2c9325/status.svg)](https://joss.theoj.org/papers/61d34ad9ef855a128509b4279e2c9325)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@yumuk1989 & @JHartzer, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ppxasjsm know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @JHartzer

📝 Checklist for @yumuk1989

@editorialbot editorialbot added Jupyter Notebook Python review TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels May 20, 2023
@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.07 s (244.3 files/s, 64307.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          10            410            939           1425
TeX                              1             42              0            667
Jupyter Notebook                 3              0            691            341
Markdown                         2             57              0            113
TOML                             1              2              0             28
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            18            512           1634           2592
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for PAS_paper.md is 1743

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1213/00000539-200103000-00020 is OK
- 10.1093/bja/aei259 is OK
- 10.1007/s10928-020-09712-1 is OK
- 10.1097/00000542-200406000-00006 is OK
- 10.1213/ANE.0000000000001372 is OK
- 10.1093/bja/aeh293 is OK
- 10.1007/s42452-021-04885-x is OK
- 10.1016/c2017-0-03401-8 is OK
- 10.1093/bja/aew126 is OK
- 10.1097/ALN.0000000000001634 is OK
- 10.1016/j.bja.2018.01.018 is OK
- 10.1093/bja/67.5.618 is OK
- 10.1109/CDC45484.2021.9683368 is OK
- 10.1109/ACCESS.2020.3037725 is OK
- 10.1186/cc9207 is OK
- 10.1155/2017/7432310 is OK
- 10.1109/ACCESS.2021.3049880 is OK
- 10.1109/TBME.2008.923142 is OK
- 10.1093/bja/aeu553 is OK
- 10.1097/00000542-200102000-00023 is OK
- 10.1097/00000542-200308000-00023 is OK
- 10.1097/00000542-200206000-00033 is OK
- 10.1213/ane.0b013e3181a96f9a is OK
- 10.1038/s41598-018-20062-4 is OK
- 10.1093/bja/67.1.41 is OK
- 10.1016/B978-0-12-815975-0.00013-8 is OK
- 10.1016/j.cnsns.2018.12.015 is OK
- 10.1097/00000542-199701000-00004 is OK
- 10.1097/CCM.0b013e318206d2a3 is OK
- 10.1016/j.compchemeng.2022.107747 is OK
- 10.1016/j.jprocont.2022.07.007 is OK
- 10.1213/ANE.0000000000000769 is OK
- 10.1186/cc10562 is OK
- 10.1016/j.jprocont.2021.12.004 is OK
- 10.1016/j.bspc.2021.102476 is OK
- 10.1097/00000542-199906000-00003 is OK
- 10.1097/00000542-200003000-00017 is OK
- 10.1213/ANE.0000000000000386 is OK
- 10.4103/sja.sja_669_21 is OK
- 10.1111/j.1460-9592.2009.03174.x is OK
- 10.1097/00000542-200002000-00021 is OK
- 10.1213/00000539-199909000-00002 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@ppxasjsm
Copy link

@yumuk1989, @JHartzer you can now get started with your review. If you have any questions in the meantime, please let me know.

@JHartzer
Copy link

JHartzer commented May 20, 2023

Review checklist for @JHartzer

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/BobAubouin/Python_Anesthesia_Simulator?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@BobAubouin) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@yumuk1989
Copy link

yumuk1989 commented May 23, 2023

Review checklist for @yumuk1989

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/BobAubouin/Python_Anesthesia_Simulator?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@BobAubouin) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@JHartzer
Copy link

In addition to the issue above, I also added Issue 17 regarding additional testing and coverage. This could improve the robustness of testing and help indicate the amount of testing coverage.

Lastly, I would suggest linking or mentioning the new ECC 2023 publication in the repository once it is available.

None of these are substantial issues, and I imagine the code quality will only improve moving forward. Therefore, I recommend JOSS acceptance

@BobAubouin
Copy link

Hi @JHartzer, thanks for your review and your suggestions!

I will add the future work into your issue and the citation to the ECC23 into the paper.

About the test framework, I'm not familiar with those, but I will consider it for improvement.

@ppxasjsm
Copy link

@yumuk1989, how are you getting on with your review?

@yumuk1989
Copy link

yumuk1989 commented Jun 20, 2023 via email

@ppxasjsm
Copy link

That's great! Thank you 👍

@ppxasjsm
Copy link

Thank you @JHartzer for your review and I've noted the recommend accept.

@yumuk1989
Copy link

yumuk1989 commented Jun 30, 2023 via email

@BobAubouin
Copy link

Hi Erhan,

You can access the review on github here and edit your comment containing the checklist by clicking on the three dots at the top right of your comment.

@yumuk1989
Copy link

Hello,

I have reviewed the code, documentation and paper. The authors give the statement of need clearly on the paper. However, this section is somewhat lacking in the documentation. They should also give it clearly there. But this is not a big issue. I recommend it to accept in JOSS.

@BobAubouin
Copy link

Hi Erhan,

Thanks for your feedback! I have been working on the documentation, it is now available online here: https://python-anesthesia-simulator.readthedocs.io. It includes the statement of need as introduction and also the examples.

@ppxasjsm
Copy link

ppxasjsm commented Jul 4, 2023

Hi @yumuk1989 thank you for the review!

@ppxasjsm
Copy link

ppxasjsm commented Jul 4, 2023

@BobAubouin can you please check your manuscript and repository one last time. If you are happy with it, I'll have a look too and will proceed with what is needed to move it to recommend accept.

@BobAubouin
Copy link

@ppxasjsm I'm good with the repo and the manuscript! I added a tag v1.0.0 to the current git version since it have changed a bit since the submission.

@ppxasjsm
Copy link

ppxasjsm commented Jul 8, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@ppxasjsm
Copy link

ppxasjsm commented Aug 6, 2023

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1213/00000539-200103000-00020 is OK
- 10.1093/bja/aei259 is OK
- 10.1007/s10928-020-09712-1 is OK
- 10.1097/00000542-200406000-00006 is OK
- 10.1213/ANE.0000000000001372 is OK
- 10.1093/bja/aeh293 is OK
- 10.1007/s42452-021-04885-x is OK
- 10.1016/c2017-0-03401-8 is OK
- 10.1093/bja/aew126 is OK
- 10.1097/ALN.0000000000001634 is OK
- 10.1016/j.bja.2018.01.018 is OK
- 10.1093/bja/67.5.618 is OK
- 10.1109/CDC45484.2021.9683368 is OK
- 10.1109/ACCESS.2020.3037725 is OK
- 10.1186/cc9207 is OK
- 10.1155/2017/7432310 is OK
- 10.1109/ACCESS.2021.3049880 is OK
- 10.1109/TBME.2008.923142 is OK
- 10.1093/bja/aeu553 is OK
- 10.1097/00000542-200102000-00023 is OK
- 10.1097/00000542-200308000-00023 is OK
- 10.1097/00000542-200206000-00033 is OK
- 10.1213/ane.0b013e3181a96f9a is OK
- 10.1038/s41598-018-20062-4 is OK
- 10.1093/bja/67.1.41 is OK
- 10.1016/B978-0-12-815975-0.00013-8 is OK
- 10.1016/j.cnsns.2018.12.015 is OK
- 10.1097/00000542-199701000-00004 is OK
- 10.1097/CCM.0b013e318206d2a3 is OK
- 10.1016/j.compchemeng.2022.107747 is OK
- 10.1016/j.jprocont.2022.07.007 is OK
- 10.1213/ANE.0000000000000769 is OK
- 10.1186/cc10562 is OK
- 10.1016/j.jprocont.2021.12.004 is OK
- 10.1016/j.bspc.2021.102476 is OK
- 10.1097/00000542-199906000-00003 is OK
- 10.1097/00000542-200003000-00017 is OK
- 10.1213/ANE.0000000000000386 is OK
- 10.4103/sja.sja_669_21 is OK
- 10.1111/j.1460-9592.2009.03174.x is OK
- 10.1097/00000542-200002000-00021 is OK
- 10.1213/00000539-199909000-00002 is OK

MISSING DOIs

- 10.23919/ecc57647.2023.10178214 may be a valid DOI for title: Data-Based Pharmacodynamic Modeling for BIS and Mean Arterial Pressure Prediction during General Anesthesia

INVALID DOIs

- None

@ppxasjsm
Copy link

ppxasjsm commented Aug 6, 2023

@BobAubouin, I am sorry this ended up taking much longer than I thought. We are ready to accept, there is just one DOI that should be added to the paper. This is for the title: Data-Based Pharmacodynamic Modeling for BIS and Mean Arterial Pressure Prediction during General Anesthesia

Looking at the link: https://ieeexplore.ieee.org/document/10178214, the DOI suggest and just stated below should be added:
10.23919/ECC57647.2023.10178214

Thanks a lot! As soon as this is done I can recommend-accept.

@BobAubouin
Copy link

Hi @ppxasjsm no problem for the delay!

The DOI have been added to the paper.

@BobAubouin
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@BobAubouin
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1213/00000539-200103000-00020 is OK
- 10.23919/ecc57647.2023.10178214 is OK
- 10.1093/bja/aei259 is OK
- 10.1007/s10928-020-09712-1 is OK
- 10.1097/00000542-200406000-00006 is OK
- 10.1213/ANE.0000000000001372 is OK
- 10.1093/bja/aeh293 is OK
- 10.1007/s42452-021-04885-x is OK
- 10.1016/c2017-0-03401-8 is OK
- 10.1093/bja/aew126 is OK
- 10.1097/ALN.0000000000001634 is OK
- 10.1016/j.bja.2018.01.018 is OK
- 10.1093/bja/67.5.618 is OK
- 10.1109/CDC45484.2021.9683368 is OK
- 10.1109/ACCESS.2020.3037725 is OK
- 10.1186/cc9207 is OK
- 10.1155/2017/7432310 is OK
- 10.1109/ACCESS.2021.3049880 is OK
- 10.1109/TBME.2008.923142 is OK
- 10.1093/bja/aeu553 is OK
- 10.1097/00000542-200102000-00023 is OK
- 10.1097/00000542-200308000-00023 is OK
- 10.1097/00000542-200206000-00033 is OK
- 10.1213/ane.0b013e3181a96f9a is OK
- 10.1038/s41598-018-20062-4 is OK
- 10.1093/bja/67.1.41 is OK
- 10.1016/B978-0-12-815975-0.00013-8 is OK
- 10.1016/j.cnsns.2018.12.015 is OK
- 10.1097/00000542-199701000-00004 is OK
- 10.1097/CCM.0b013e318206d2a3 is OK
- 10.1016/j.compchemeng.2022.107747 is OK
- 10.1016/j.jprocont.2022.07.007 is OK
- 10.1213/ANE.0000000000000769 is OK
- 10.1186/cc10562 is OK
- 10.1016/j.jprocont.2021.12.004 is OK
- 10.1016/j.bspc.2021.102476 is OK
- 10.1097/00000542-199906000-00003 is OK
- 10.1097/00000542-200003000-00017 is OK
- 10.1213/ANE.0000000000000386 is OK
- 10.4103/sja.sja_669_21 is OK
- 10.1111/j.1460-9592.2009.03174.x is OK
- 10.1097/00000542-200002000-00021 is OK
- 10.1213/00000539-199909000-00002 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@ppxasjsm
Copy link

ppxasjsm commented Aug 8, 2023

Perfect thank you!

@ppxasjsm
Copy link

ppxasjsm commented Aug 8, 2023

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1213/00000539-200103000-00020 is OK
- 10.23919/ecc57647.2023.10178214 is OK
- 10.1093/bja/aei259 is OK
- 10.1007/s10928-020-09712-1 is OK
- 10.1097/00000542-200406000-00006 is OK
- 10.1213/ANE.0000000000001372 is OK
- 10.1093/bja/aeh293 is OK
- 10.1007/s42452-021-04885-x is OK
- 10.1016/c2017-0-03401-8 is OK
- 10.1093/bja/aew126 is OK
- 10.1097/ALN.0000000000001634 is OK
- 10.1016/j.bja.2018.01.018 is OK
- 10.1093/bja/67.5.618 is OK
- 10.1109/CDC45484.2021.9683368 is OK
- 10.1109/ACCESS.2020.3037725 is OK
- 10.1186/cc9207 is OK
- 10.1155/2017/7432310 is OK
- 10.1109/ACCESS.2021.3049880 is OK
- 10.1109/TBME.2008.923142 is OK
- 10.1093/bja/aeu553 is OK
- 10.1097/00000542-200102000-00023 is OK
- 10.1097/00000542-200308000-00023 is OK
- 10.1097/00000542-200206000-00033 is OK
- 10.1213/ane.0b013e3181a96f9a is OK
- 10.1038/s41598-018-20062-4 is OK
- 10.1093/bja/67.1.41 is OK
- 10.1016/B978-0-12-815975-0.00013-8 is OK
- 10.1016/j.cnsns.2018.12.015 is OK
- 10.1097/00000542-199701000-00004 is OK
- 10.1097/CCM.0b013e318206d2a3 is OK
- 10.1016/j.compchemeng.2022.107747 is OK
- 10.1016/j.jprocont.2022.07.007 is OK
- 10.1213/ANE.0000000000000769 is OK
- 10.1186/cc10562 is OK
- 10.1016/j.jprocont.2021.12.004 is OK
- 10.1016/j.bspc.2021.102476 is OK
- 10.1097/00000542-199906000-00003 is OK
- 10.1097/00000542-200003000-00017 is OK
- 10.1213/ANE.0000000000000386 is OK
- 10.4103/sja.sja_669_21 is OK
- 10.1111/j.1460-9592.2009.03174.x is OK
- 10.1097/00000542-200002000-00021 is OK
- 10.1213/00000539-199909000-00002 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/bcm-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4459, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Aug 8, 2023
@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Aug 10, 2023

@BobAubouin I have checked this review, the archive, the repository, and the paper and most seems in order. We only have the below minor points that need your attention:

  • Please edit your archive license (currently GNU Affero General Public License v3.0) to match your software license (GNU General Public License v3.0)
  • The name richmond should likely feature a capital letter so be written as Richmond
  • Recommendation: In your affiliations you may spell out Université Grenoble Alpes (no need to use the shortened Univ). Also if 38000 refers to a postal code, you may choose to leave that out.

@BobAubouin
Copy link

Hi @Kevin-Mattheus-Moerman, thanks for this final check!

I just changed the archive license to "GNU General Public License v3.0 only", I'm not sure if this ok but "GNU General Public License v3.0" was not in the list of available licenses.

I also add a capital letter to "Richmond".

About the affiliation, this is the exact sentence imposed by my lab, I prefer to keep it as it is.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- email: bob.aubouin-pairault@gipsa-lab.fr
  family-names: Aubouin--Pairault
  given-names: Bob
  orcid: "https://orcid.org/0000-0003-0029-438X"
- email: mirko.fiacchini@gipsa-lab.fr
  family-names: Fiacchini
  given-names: Mirko
  orcid: "https://orcid.org/0000-0002-3601-0302"
- email: thao.dang@univ-grenoble-alpes.fr
  family-names: Dang
  given-names: Thao
  orcid: "https://orcid.org/0000-0002-3637-1415"
contact:
- email: bob.aubouin-pairault@gipsa-lab.fr
  family-names: Aubouin--Pairault
  given-names: Bob
  orcid: "https://orcid.org/0000-0003-0029-438X"
doi: 10.5281/zenodo.8171326
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - email: bob.aubouin-pairault@gipsa-lab.fr
    family-names: Aubouin--Pairault
    given-names: Bob
    orcid: "https://orcid.org/0000-0003-0029-438X"
  - email: mirko.fiacchini@gipsa-lab.fr
    family-names: Fiacchini
    given-names: Mirko
    orcid: "https://orcid.org/0000-0002-3601-0302"
  - email: thao.dang@univ-grenoble-alpes.fr
    family-names: Dang
    given-names: Thao
    orcid: "https://orcid.org/0000-0002-3637-1415"
  date-published: 2023-08-14
  doi: 10.21105/joss.05480
  issn: 2475-9066
  issue: 88
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 5480
  title: "PAS: a Python Anesthesia Simulator for drug control"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.05480"
  volume: 8
title: "PAS: a Python Anesthesia Simulator for drug control"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.05480 joss-papers#4484
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05480
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Aug 14, 2023
@Kevin-Mattheus-Moerman
Copy link
Member

@BobAubouin congratulations on this publication in JOSS!

Thanks for editing @ppxasjsm !

And a special thanks to the reviewers @yumuk1989 and @JHartzer

@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05480/status.svg)](https://doi.org/10.21105/joss.05480)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05480">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05480/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05480/status.svg
   :target: https://doi.org/10.21105/joss.05480

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@BobAubouin
Copy link

Thank you all for the help and yours feedbacks in this review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Jupyter Notebook published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

6 participants