-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PAS: a Python Anesthesia Simulator for drug control #5480
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@yumuk1989, @JHartzer you can now get started with your review. If you have any questions in the meantime, please let me know. |
Review checklist for @JHartzerConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @yumuk1989Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
In addition to the issue above, I also added Issue 17 regarding additional testing and coverage. This could improve the robustness of testing and help indicate the amount of testing coverage. Lastly, I would suggest linking or mentioning the new ECC 2023 publication in the repository once it is available. None of these are substantial issues, and I imagine the code quality will only improve moving forward. Therefore, I recommend JOSS acceptance |
Hi @JHartzer, thanks for your review and your suggestions! I will add the future work into your issue and the citation to the ECC23 into the paper. About the test framework, I'm not familiar with those, but I will consider it for improvement. |
@yumuk1989, how are you getting on with your review? |
Hello Toni,
Sorry for delay. Yes, I started reviewing it but I have not finished yet. I
will have finished it by the end of June.
Best,
Erhan
20 Haz 2023 Sal 10:54 tarihinde Toni Mey ***@***.***> şunu
yazdı:
… @yumuk1989 <https://github.com/yumuk1989>, how are you getting on with
your review?
—
Reply to this email directly, view it on GitHub
<#5480 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARSHHV43KEJLLGXJUI3JJUTXMFQM3ANCNFSM6AAAAAAYIXOVPY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That's great! Thank you 👍 |
Thank you @JHartzer for your review and I've noted the recommend accept. |
Hello Toni,
I could not see/reach my checklist as a reviewer. I started reviewing it
one month ago. Could you please help me about it? How can reach it?
Erhan YUMUK
Toni Mey ***@***.***>, 23 Haz 2023 Cum, 11:00 tarihinde şunu
yazdı:
… Thank you @JHartzer <https://github.com/JHartzer> for your review and
I've noted the recommend accept.
—
Reply to this email directly, view it on GitHub
<#5480 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARSHHV2BMXTIXCSHDA5ZN33XMVLJPANCNFSM6AAAAAAYIXOVPY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Dr. Erhan YUMUK
Lecturer
Istanbul Technical University
Department of Control and Automation Engineering
|
Hi Erhan, You can access the review on github here and edit your comment containing the checklist by clicking on the three dots at the top right of your comment. |
Hello, I have reviewed the code, documentation and paper. The authors give the statement of need clearly on the paper. However, this section is somewhat lacking in the documentation. They should also give it clearly there. But this is not a big issue. I recommend it to accept in JOSS. |
Hi Erhan, Thanks for your feedback! I have been working on the documentation, it is now available online here: https://python-anesthesia-simulator.readthedocs.io. It includes the statement of need as introduction and also the examples. |
Hi @yumuk1989 thank you for the review! |
@BobAubouin can you please check your manuscript and repository one last time. If you are happy with it, I'll have a look too and will proceed with what is needed to move it to recommend accept. |
@ppxasjsm I'm good with the repo and the manuscript! I added a tag v1.0.0 to the current git version since it have changed a bit since the submission. |
@editorialbot generate pdf |
@editorialbot check references |
|
@BobAubouin, I am sorry this ended up taking much longer than I thought. We are ready to accept, there is just one DOI that should be added to the paper. This is for the title: Data-Based Pharmacodynamic Modeling for BIS and Mean Arterial Pressure Prediction during General Anesthesia Looking at the link: https://ieeexplore.ieee.org/document/10178214, the DOI suggest and just stated below should be added: Thanks a lot! As soon as this is done I can recommend-accept. |
Hi @ppxasjsm no problem for the delay! The DOI have been added to the paper. |
@editorialbot generate pdf |
@editorialbot check references |
|
Perfect thank you! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4459, then you can now move forward with accepting the submission by compiling again with the command |
@BobAubouin I have checked this review, the archive, the repository, and the paper and most seems in order. We only have the below minor points that need your attention:
|
Hi @Kevin-Mattheus-Moerman, thanks for this final check! I just changed the archive license to "GNU General Public License v3.0 only", I'm not sure if this ok but "GNU General Public License v3.0" was not in the list of available licenses. I also add a capital letter to "Richmond". About the affiliation, this is the exact sentence imposed by my lab, I prefer to keep it as it is. |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@BobAubouin congratulations on this publication in JOSS! Thanks for editing @ppxasjsm ! And a special thanks to the reviewers @yumuk1989 and @JHartzer |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you all for the help and yours feedbacks in this review! |
Submitting author: @BobAubouin (Bob Aubouin--Pairault)
Repository: https://github.com/BobAubouin/Python_Anesthesia_Simulator
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @ppxasjsm
Reviewers: @yumuk1989, @JHartzer
Archive: 10.5281/zenodo.8171326
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@yumuk1989 & @JHartzer, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ppxasjsm know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @JHartzer
📝 Checklist for @yumuk1989
The text was updated successfully, but these errors were encountered: