New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: iTensor: An R package for independent component analysis-based matrix/tensor decomposition #5496
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @devaropsConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
DocumentationTestingdocker run --rm -it -v ${PWD}:/workdir ghcr.io/rikenbit/itensor bash
cd /workdir
Rscript -e "devtools::test(stop_on_failure = TRUE)"
Coveragedocker run --rm -it -v ${PWD}:/workdir ghcr.io/rikenbit/itensor bash
cd /workdir
Rscript -e "install.packages(c('covr','DT','htmltools'))"
Rscript tests/testthat/coverage.R
library(covr)
cov <- package_coverage()
print(cov)
zero_coverage(cov)
report(cov, file = file.path("/workdir/tests/coverage-report.html"), browse = FALSE) |
Review checklist for @ritika-giriConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
@ritika-giri Thank you for checking the install process. I replied your comment. |
@kokitsuyuzaki the install works now, thanks for fixing it! |
Thank you for providing me with the opportunity to review the submission. After careful evaluation, I have found that while there are tests in place, they currently only cover approximately 35.8% of the code. In my opinion, this level of coverage is insufficient to adequately verify the functionality of the software. In order to address this issue, I would like to suggest some minor revisions to elevate the test coverage. I propose aiming for a minimum coverage of 50% in each file, or preferably reaching a target of 90% coverage across the entire repository. By increasing the test coverage, we can significantly improve the reliability and robustness of the software, ensuring that potential issues are caught early and reducing the risk of regressions. Please let me know if you have any further questions. |
Thanks a lot for your review @devarops. Your concern about test coverage seems very reasonable. Please let us know when this issue has been addressed, @kokitsuyuzaki. |
@devarops, is this issue addressed in a satisfactory way? If so, could you please update your checklist? Otherwise, please elaborate what the authors need to do further. Thank you. |
@osorensen: |
@editorialbot generate pdf |
@editorialbot check references |
|
@kokitsuyuzaki, both reviewers have now completed their checklist. I will now read through the paper, and let you know if there are any suggested changes from my side. |
Thanks @kokitsuyuzaki.
Once done, please report back to me in this thread. |
Ok, I modified the title. |
@editorialbot set 10.5281/zenodo.8080600 as archive |
Done! archive is now 10.5281/zenodo.8080600 |
@editorialbot generate pdf |
@editorialbot check references |
|
@kokitsuyuzaki, I notice another small thing that needs to be fixed before I can recommend acceptance. See PR in source repo. |
I changed my mind. See comment in PR. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4347, then you can now move forward with accepting the submission by compiling again with the command |
@osorensen Is there anything else I have to do? |
@kokitsuyuzaki, no, we're waiting for the editor-in-chief @openjournals/dsais-eics to read through and make the final decision. |
@kokitsuyuzaki Working on this today (now). Thank you for your patience! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @kokitsuyuzaki (Koki Tsuyuzaki)
Repository: https://github.com/rikenbit/iTensor
Branch with paper.md (empty if default branch):
Version: v1.0.3
Editor: @osorensen
Reviewers: @ritika-giri, @devarops
Archive: 10.5281/zenodo.8080600
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ritika-giri & @devarops, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @devarops
📝 Checklist for @ritika-giri
The text was updated successfully, but these errors were encountered: