Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Zoomerjoin: Superlatively Fast Fuzzy-Joins #5560

Closed
editorialbot opened this issue Jun 14, 2023 · 28 comments
Closed

[PRE REVIEW]: Zoomerjoin: Superlatively Fast Fuzzy-Joins #5560

editorialbot opened this issue Jun 14, 2023 · 28 comments
Assignees
Labels
pre-review R Shell TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jun 14, 2023

Submitting author: @beniaminogreen (Beniamino Green)
Repository: https://github.com/beniaminogreen/zoomerjoin
Branch with paper.md (empty if default branch): joss
Version: 0.1.0
Editor: @samhforbes
Reviewers: @cjbarrie, @wincowgerDEV
Managing EiC: Olivia Guest

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b68ba4bfbce52e56585aea54a5bcba54"><img src="https://joss.theoj.org/papers/b68ba4bfbce52e56585aea54a5bcba54/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b68ba4bfbce52e56585aea54a5bcba54/status.svg)](https://joss.theoj.org/papers/b68ba4bfbce52e56585aea54a5bcba54)

Author instructions

Thanks for submitting your paper to JOSS @beniaminogreen. Currently, there isn't a JOSS editor assigned to your paper.

The AEiC suggestion for the handling editor is @KristinaRiemer.

@beniaminogreen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences labels Jun 14, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.20 s (223.9 files/s, 25178.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         6            230              0            922
HTML                             1             10              2            715
R                               18            189            784            706
Rust                             6            125              9            479
JSON                             1              0              0            189
YAML                             6             35             12            183
TeX                              1              0              0            134
Rmd                              3             67            174             55
TOML                             1              2              0             19
C                                1              2              2              4
Bourne Shell                     1              1              8              2
-------------------------------------------------------------------------------
SUM:                            45            661            991           3408
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1469

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/sequen.1997.666900 is OK
- 10.1017/CBO9781139924801 is OK
- 10.1093/bioinformatics/btz354 is OK
- 10.1145/997817.997857 is OK
- 10.1017/pan.2021.38 is OK
- 10.32614/RJ-2014-011 is OK
- 10.2139/ssrn.3214172 is OK
- 10.1080/01621459.1969.10501049 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@beniaminogreen
Copy link

Thanks! Looking at the list of reviewers I would suggest lmullen, as he has written a package (textreuse) that also uses Locality-Sensitive Hashing which inspired me to make this package. Beyond this no real opinions, although I think pmyteh, cjbarrie, and justinchuntngho might be able to supply good reviews.

@beniaminogreen
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@beniaminogreen
Copy link

beniaminogreen commented Jul 11, 2023

Hi @oliviaguest , just writing to ask if you can confirm whether I have managed to submit all of the materials necessary for a pre-review. Thanks for your time, and please don't hesitate to let me know if there are any other materials that will help you in considering my submission.

Best,
Ben

@oliviaguest
Copy link
Member

@samhforbes do you have capacity for this? ☺️

@oliviaguest
Copy link
Member

@beniaminogreen yes, sorry... summer is a slow period... 😅

@samhforbes
Copy link

@oliviaguest I'm a little over capacity right now, but this looks interesting and I'd be happy to pick it up in a couple of weeks if there's nobody else available.

@oliviaguest
Copy link
Member

@samhforbes summer is very slow, so I suspect this is fine. Thank you! 🌈

@samhforbes
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @samhforbes is now the editor

@samhforbes
Copy link

👋 @lmullen, @cjbarrie would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@cjbarrie
Copy link

Happy to do this!

@lmullen
Copy link

lmullen commented Jul 24, 2023

@samhforbes Apologies, but I can't take this one on.

@samhforbes
Copy link

@editorialbot add @cjbarrie as reviewer

@editorialbot
Copy link
Collaborator Author

@cjbarrie added to the reviewers list!

@samhforbes
Copy link

👋 @wincowgerDEV @simonpcouch would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@wincowgerDEV
Copy link

Hey @samhforbes, thanks for the invite, currently building a lot of R packages and this is right up my ally, count me in!

@samhforbes
Copy link

@editorialbot add @wincowgerDEV as reviewer

@editorialbot
Copy link
Collaborator Author

@wincowgerDEV added to the reviewers list!

@simonpcouch
Copy link

I'm unfortunately unable to make this review happen at the moment. Best of luck!

@samhforbes
Copy link

Great @beniaminogreen I am going to start the review thread now. This one will be closed and we can begin in the new thread.

@samhforbes
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5693.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review R Shell TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences
Projects
None yet
Development

No branches or pull requests

8 participants