Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: A Java Library for Itemset Mining with Choco-solver #5654

Closed
editorialbot opened this issue Jul 13, 2023 · 70 comments
Closed

[REVIEW]: A Java Library for Itemset Mining with Choco-solver #5654

editorialbot opened this issue Jul 13, 2023 · 70 comments
Assignees
Labels
accepted Makefile published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review Shell TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 13, 2023

Submitting author: @ChaVer (Charles Vernerey)
Repository: https://gitlab.com/chaver/choco-mining
Branch with paper.md (empty if default branch):
Version: v1.0.2
Editor: @danielskatz
Reviewers: @skadio, @jgFages
Archive: 10.5281/zenodo.8263971

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/6da58bb06b3f1b163dbe96e8bf63f315"><img src="https://joss.theoj.org/papers/6da58bb06b3f1b163dbe96e8bf63f315/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/6da58bb06b3f1b163dbe96e8bf63f315/status.svg)](https://joss.theoj.org/papers/6da58bb06b3f1b163dbe96e8bf63f315)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@skadio & @jgFages, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @jgFages

📝 Checklist for @skadio

@editorialbot editorialbot added Makefile review Shell TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Jul 13, 2023
@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.09 s (1302.5 files/s, 83740.1 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Java                            102            800           1336           4257
SVG                               2              1             52            284
Maven                             1              8              6            193
TeX                               1              0              0            166
Markdown                          3             57              0            161
Bourne Again Shell                1              0              0              2
Bourne Shell                      1              0              0              2
JSON                              2              0              0              2
make                              1              0              0              2
--------------------------------------------------------------------------------
SUM:                            114            866           1394           5069
--------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1388

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-66158-2_34 is OK
- 10.1137/1.9781611975673.15 is OK
- 10.24963/ijcai.2019/149 is OK
- 10.1016/j.artint.2011.05.002 is OK
- 10.24963/ijcai.2022/261 is OK
- 10.21105/joss.04708 is OK
- 10.1007/978-3-030-67658-2_3 is OK
- 10.1093/bioinformatics/btn490 is OK
- 10.3390/e18050164 is OK
- 10.1016/j.artint.2015.04.003 is OK
- 10.1007/978-3-319-44953-1_22 is OK
- 10.1002/widm.1207 is OK
- 10.14257/ijhit.2013.6.6.30 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

@skadio and @jgFages - Thanks for agreeing to review this submission.
This is the review thread for the paper. All of our communications will happen here from now on.

As you can see above, you each should use the command @editorialbot generate my checklist to create your review checklist. @editorialbot commands need to be the first thing in a new comment.

As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#5654 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 2-4 weeks. Please let me know if either of you require some more time. We can also use editorialbot (our bot) to set automatic reminders if you know you'll be away for a known period of time.

Please feel free to ping me (@danielskatz) if you have any questions/concerns.

@danielskatz
Copy link

reminder to self: @skadio said when accepting this review "I might take some time (~8 weeks)."

@jgFages
Copy link

jgFages commented Jul 13, 2023

Review checklist for @jgFages

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://gitlab.com/chaver/data-mining?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@ChaVer) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@jgFages
Copy link

jgFages commented Jul 13, 2023

Data Mining with Constraint Programming is indeed an interesting topic of Research.
The paper is well written, and well illustrated. The literature review is good and the tool is well motivated.

I have however a few remarks regarding both the paper and the software :

  • I recommend to follow Choco Solver implementation standards, by :
    -- Prefixing propagators by Prop, as it is done in Choco Solver (CoverSize -> PropCoverSize) to emphasize the difference between a constraint and a propagator
    -- Regrouping these constraints within a Factory, that would be the main entry point of the library
    -- Keeping the post() instruction at the end of the line : model.arithm(...).post() is more common than model.post(model.arithm(...))
  • More generally, as the software name includes Choco and therefore sounds "official" from the chocoteam (see https://github.com/chocoteam/), I would recommend to have to some kind of code review with @cprudhom. If he is a co-worker, I guess it would be easy to organize. Maybe the project should be hosted in that repo.
  • What is the software license ?

Minor :
data mining to Constraint Programming -> Data Mining to Constraint Programming

@skadio
Copy link

skadio commented Jul 15, 2023

Review checklist for @skadio

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://gitlab.com/chaver/data-mining?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@ChaVer) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@skadio
Copy link

skadio commented Jul 15, 2023

@ChaVer congratulations on your IJCAI'22 paper and turning it into a library.

This submission is clearly relevant to JOSS and almost there in terms of publication, with a few suggestions that needs to be accounted for:

  • typo in summary: "task ," remove extra space

  • The readme needs a major update. Luckily you have all that information in the WIKI and the Paper

The current readme is not in sync with the wiki.

A user looking at the Readme would not understand that this is a "library" which was my main confusion initially. It almost seems like a standalone command line tool, which is not the case here, it is indeed a library. Even worse, it first looked like a repo to me to reproduce the experiments from the IJCAI'22 paper.

Compared to that; the Wiki does a much better job. https://gitlab.com/chaver/data-mining/-/wikis/home

My recommendation is creating a lean / subset of the Wiki to replace the current Readme. You can cite the IJCAI paper at top but push the commentary about reproducing experiments to the bottom (or better, leave in a section in the detailed Wiki).

My major concern about the paper is: I am not sure if an outsider would immediately understand what are these constraints are. Currently the in the Readme, the constraints are listed under "Installation" which is not right. My recommendation is: create a specific section in the README for this and mimic what's in the Wiki. I almost tempted to say use the Wiki as the Readme.

The paper does an adequate job of description the tasks (like, what is skypattern mining) but the Readme and Wiki don't do that.

My overall comment is:

  • We need to clearly describe the Constraints
  • We need to clearly describe the Tasks

where the ultimate goal is, once this is published in JOSS, an informed outsider (not a pattern mining expert) can leverage your library. You have all this material across the Paper, Readme, and Wiki but need to refresh the Readme and Wiki with a lens to cater to an outsider. The example in the paper is great so I would highly suggest adding a "Quick Start Example" to the very top of the README.

  • state-of-the-field + references: please also mention the Seq2Pat library which is immediately relevant for declarative (sequential) pattern mining cite its relevant references from AI Mag'23 and AAAI'22. You might also consider citing the dichotomic pattern mining framework from Frontiers'22. These are listed here https://github.com/fidelity/seq2pat#citation

  • I would also argue for taking that paper folder "outside" of this library. You can have your reproducibility repo in standalone and use your own library from there to show/reproduce the results. Then, you can link to that paper repo from the references here. As a "user" of the "library" I am not immediately interested in paper reproducing scripts. Notice also, down the road, your reproducibility scripts needs to stay identical whereas the library will move.

Hope this helps you improve your submission.

Serdar

@skadio
Copy link

skadio commented Jul 15, 2023

Happy to take another quick look once you update the library

@ChaVer
Copy link

ChaVer commented Jul 27, 2023

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @ChaVer, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@ChaVer
Copy link

ChaVer commented Jul 27, 2023

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-66158-2_34 is OK
- 10.1137/1.9781611975673.15 is OK
- 10.24963/ijcai.2019/149 is OK
- 10.1016/j.artint.2011.05.002 is OK
- 10.24963/ijcai.2022/261 is OK
- 10.21105/joss.04708 is OK
- 10.1007/978-3-030-67658-2_3 is OK
- 10.1093/bioinformatics/btn490 is OK
- 10.3390/e18050164 is OK
- 10.1016/j.artint.2015.04.003 is OK
- 10.1007/978-3-319-44953-1_22 is OK
- 10.1002/widm.1207 is OK
- 10.14257/ijhit.2013.6.6.30 is OK

MISSING DOIs

- 10.1609/aaai.v36i11.21542 may be a valid DOI for title: Seq2Pat: Sequence-to-Pattern Generation for Constraint-based Sequential Pattern Mining
- 10.3389/frai.2022.868085 may be a valid DOI for title: Dichotomic Pattern Mining Integrated with Constraint Reasoning for Digital Behaviour Analyses

INVALID DOIs

- https://doi.org/10.1002/aaai.12081 is INVALID because of 'https://doi.org/' prefix

@ChaVer
Copy link

ChaVer commented Jul 27, 2023

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-66158-2_34 is OK
- 10.1137/1.9781611975673.15 is OK
- 10.24963/ijcai.2019/149 is OK
- 10.1016/j.artint.2011.05.002 is OK
- 10.24963/ijcai.2022/261 is OK
- 10.21105/joss.04708 is OK
- 10.1007/978-3-030-67658-2_3 is OK
- 10.1093/bioinformatics/btn490 is OK
- 10.3390/e18050164 is OK
- 10.1016/j.artint.2015.04.003 is OK
- 10.1007/978-3-319-44953-1_22 is OK
- 10.1002/widm.1207 is OK
- 10.14257/ijhit.2013.6.6.30 is OK
- 10.1002/aaai.12081 is OK
- 10.1609/aaai.v36i11.21542 is OK
- 10.3389/frai.2022.868085 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@ChaVer
Copy link

ChaVer commented Jul 27, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@ChaVer
Copy link

ChaVer commented Jul 27, 2023

Dear reviewers,

Thank you for your valuable comments and suggestions for improving both the paper and the library.

@jgFages :

  • We have carefully considered your observations concerning the implementation standards of Choco Solver and made the necessary updates to the library accordingly.
  • The software license of the library is MIT, which can be verified at the following link: https://gitlab.com/chaver/data-mining/-/blob/master/LICENSE.txt.
  • As for the potential code review with Charles Prudhomme and the possibility of hosting the library in the Choco Solver repository, we will promptly discuss this matter with him.

@skadio :

  • We have made revisions to the README to accurately represent Choco-Mining as a library rather than a repository for reproducing IJCAI experiments.
  • A clear and comprehensive description of the constraints along with their associated tasks has been provided in the README.
  • We have included an illustrative example in the README to demonstrate the proper utilization of the library.
  • References to the Seq2Pat library have been included both in the README and the paper, specifically in the "CP and Pattern Mining" section.

@skadio
Copy link

skadio commented Jul 27, 2023

@ChaVer thank you for the updates! The readme is much improved now, and better reflects the power of the tool to an interested user now. Same for the manuscript.

My only final comment would the order of sections in the readme. Currently, it starts with the Architecture, Installation, and then the Illustrative Example, and Documents. Why not bring the Example to the top? So in my mind, you have the intro (as a reader I am thinking, what does this tool do?), the example (show me how it looks), installation (example is cool, how can I use this?), and documentation (where do I go to with questions and more details). Small change, but I think it would help you.

@danielskatz this is good to go from my side.

@danielskatz
Copy link

@jgFages - I look forward to your thoughts when you get a chance, and thanks to @skadio for yours

@danielskatz
Copy link

@ChaVer - https://doi.org/10.5281/zenodo.8263971 does seem to work. Can you share the URL to the archive so that I can take a look at it that way for now?

@ChaVer
Copy link

ChaVer commented Aug 18, 2023

@danielskatz the url of the archive is https://zenodo.org/record/8263971

@danielskatz
Copy link

I guess there's something slow in zenodo/datacite today - I'll check again in a few hours

@danielskatz
Copy link

@editorialbot set 10.5281/zenodo.8263971 as archive

@editorialbot
Copy link
Collaborator Author

Done! archive is now 10.5281/zenodo.8263971

@danielskatz
Copy link

@editorialbot recommend-accept

This will generate the version I'll proofread

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-66158-2_34 is OK
- 10.1137/1.9781611975673.15 is OK
- 10.24963/ijcai.2019/149 is OK
- 10.1016/j.artint.2011.05.002 is OK
- 10.24963/ijcai.2022/261 is OK
- 10.21105/joss.04708 is OK
- 10.1007/978-3-030-67658-2_3 is OK
- 10.1093/bioinformatics/btn490 is OK
- 10.3390/e18050164 is OK
- 10.1016/j.artint.2015.04.003 is OK
- 10.1007/978-3-319-44953-1_22 is OK
- 10.1002/widm.1207 is OK
- 10.14257/ijhit.2013.6.6.30 is OK
- 10.1002/aaai.12081 is OK
- 10.1609/aaai.v36i11.21542 is OK
- 10.3389/frai.2022.868085 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4495, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Aug 18, 2023
@danielskatz
Copy link

@ChaVer - I've suggested some minor changes in https://gitlab.com/chaver/choco-mining/-/merge_requests/4 - please merge this, or let me know what you disagree with.

Also, I'm unsure of the inconsistency between "Choco Solver" and "Choco-solver" as both are used in various places in the paper.

@ChaVer
Copy link

ChaVer commented Aug 18, 2023

@danielskatz I've just accepted the merge request.

I've also updated the paper to replace "Choco Solver" with "Choco-solver". Should I also update the title of the paper ?

@danielskatz
Copy link

I think that updating the title as well would make sense

@ChaVer
Copy link

ChaVer commented Aug 18, 2023

I've just updated the paper with the new title.

@danielskatz
Copy link

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-66158-2_34 is OK
- 10.1137/1.9781611975673.15 is OK
- 10.24963/ijcai.2019/149 is OK
- 10.1016/j.artint.2011.05.002 is OK
- 10.24963/ijcai.2022/261 is OK
- 10.21105/joss.04708 is OK
- 10.1007/978-3-030-67658-2_3 is OK
- 10.1093/bioinformatics/btn490 is OK
- 10.3390/e18050164 is OK
- 10.1016/j.artint.2015.04.003 is OK
- 10.1007/978-3-319-44953-1_22 is OK
- 10.1002/widm.1207 is OK
- 10.14257/ijhit.2013.6.6.30 is OK
- 10.1002/aaai.12081 is OK
- 10.1609/aaai.v36i11.21542 is OK
- 10.3389/frai.2022.868085 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4496, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@danielskatz danielskatz changed the title [REVIEW]: A Java Library for Itemset Mining with Choco Solver [REVIEW]: A Java Library for Itemset Mining with Choco-solver Aug 18, 2023
@danielskatz
Copy link

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Vernerey
  given-names: Charles
  orcid: "https://orcid.org/0000-0002-2922-2833"
- family-names: Loudni
  given-names: Samir
  orcid: "https://orcid.org/0000-0001-6245-7661"
contact:
- family-names: Vernerey
  given-names: Charles
  orcid: "https://orcid.org/0000-0002-2922-2833"
doi: 10.5281/zenodo.8263971
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Vernerey
    given-names: Charles
    orcid: "https://orcid.org/0000-0002-2922-2833"
  - family-names: Loudni
    given-names: Samir
    orcid: "https://orcid.org/0000-0001-6245-7661"
  date-published: 2023-08-18
  doi: 10.21105/joss.05654
  issn: 2475-9066
  issue: 88
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 5654
  title: A Java Library for Itemset Mining with Choco-solver
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.05654"
  volume: 8
title: A Java Library for Itemset Mining with Choco-solver

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.05654 joss-papers#4497
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05654
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Aug 18, 2023
@danielskatz
Copy link

Congratulations to @ChaVer (Charles Vernerey) and co-author on your publication!!

And thanks to @skadio and @jgFages for reviewing!
JOSS only succeeds because of volunteers, and we appreciate your work

@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05654/status.svg)](https://doi.org/10.21105/joss.05654)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05654">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05654/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05654/status.svg
   :target: https://doi.org/10.21105/joss.05654

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@ChaVer
Copy link

ChaVer commented Aug 19, 2023

Thank you @skadio and @jgFages for your reviews and @danielskatz for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Makefile published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review Shell TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

5 participants