Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: PyBADS: Fast and robust black-box optimization in Python #5694

Closed
editorialbot opened this issue Jul 26, 2023 · 115 comments
Closed

[REVIEW]: PyBADS: Fast and robust black-box optimization in Python #5694

editorialbot opened this issue Jul 26, 2023 · 115 comments
Assignees
Labels
accepted Batchfile Makefile published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 26, 2023

Submitting author: @GurjeetSinghSangra (Gurjeet Singh)
Repository: https://github.com/acerbilab/pybads
Branch with paper.md (empty if default branch): joss-submission
Version: 1.0.4
Editor: @rkurchin
Reviewers: @jungtaekkim, @vankesteren
Archive: 10.5281/zenodo.10696782

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bebd124ad9238299fc24d33973c675c8"><img src="https://joss.theoj.org/papers/bebd124ad9238299fc24d33973c675c8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bebd124ad9238299fc24d33973c675c8/status.svg)](https://joss.theoj.org/papers/bebd124ad9238299fc24d33973c675c8)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@max-little & @gaxler, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @rkurchin know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @jungtaekkim

📝 Checklist for @vankesteren

@editorialbot editorialbot added Batchfile Makefile review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Jul 26, 2023
@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.13 s (822.4 files/s, 94431.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          59           1244           1575           5501
TeX                              2             86             16            730
INI                              4             14              0            376
reStructuredText                21            188             96            308
YAML                             6             24              5            210
Markdown                         5             78              0            183
Jupyter Notebook                 5              0           1234            140
TOML                             1              9              3             56
DOS Batch                        1             10              1             39
make                             1              6             11             18
CSS                              1              1              0              9
-------------------------------------------------------------------------------
SUM:                           106           1660           2941           7570
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1580

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.05428 is OK
- 10.1145/3544489 is OK
- 10.23915/distill.00026 is OK
- 10.21105/joss.00024 is OK

MISSING DOIs

- 10.1007/s10898-012-9951-y may be a valid DOI for title: Derivative-free optimization: a review of algorithms and comparison of software implementations
- 10.1109/tte.2022.3218341 may be a valid DOI for title: Topology Comparison and Sensitivity Analysis of Fuel Cell Hybrid Systems for Electric Vehicles
- 10.1016/j.petsci.2022.06.016 may be a valid DOI for title: Well production optimization using streamline features-based objective function and Bayesian adaptive direct search algorithm
- 10.1101/2021.03.11.434913 may be a valid DOI for title: On the generality and cognitive basis of base-rate neglect
- 10.1016/j.jmapro.2021.02.052 may be a valid DOI for title: A novel energy partition model for belt grinding of Inconel 718
- 10.1016/j.jeem.2020.102317 may be a valid DOI for title: The impact of wildfires on the recreational value of heathland: A discrete factor approach with adjustment for on-site sampling
- 10.1137/040603371 may be a valid DOI for title: Mesh Adaptive Direct Search Algorithms for Constrained Optimization
- 10.1109/wsc.2006.323088 may be a valid DOI for title: Adaptation of the UOBYQA algorithm for noisy functions
- 10.1137/080716980 may be a valid DOI for title: OrthoMADS: A deterministic MADS instance with orthogonal directions
- 10.1007/s10589-020-00249-0 may be a valid DOI for title: Stochastic mesh adaptive direct search for blackbox optimization using probabilistic estimates
- 10.1038/s41586-023-06124-2 may be a valid DOI for title: Expertise increases planning depth in human gameplay
- 10.1101/500413 may be a valid DOI for title: Causal inference in the multisensory brain
- 10.1038/s41593-019-0453-9 may be a valid DOI for title: Optimal policy for multi-alternative decisions
- 10.1038/s41562-019-0804-2 may be a valid DOI for title: Quantum reinforcement learning during human decision-making
- 10.1016/j.cub.2019.04.067 may be a valid DOI for title: Simple Acoustic Features Can Explain Phoneme-Based Predictions of Cortical Responses to Speech
- 10.1016/j.jmapro.2020.07.018 may be a valid DOI for title: A new method to achieve dynamic heat input monitoring in robotic belt grinding of Inconel 718
- 10.3390/en14030626 may be a valid DOI for title: Interpretation of Gas/Water Relative Permeability of Coal Using the Hybrid Bayesian-Assisted History Matching: New Insights
- 10.1109/jproc.2015.2494218 may be a valid DOI for title: Taking the Human Out of the Loop: A Review of Bayesian Optimization
- 10.1016/j.anucene.2020.108046 may be a valid DOI for title: Application of Kriging and Variational Bayesian Monte Carlo method for improved prediction of doped UO2 fission gas release
- 10.1007/s40857-022-00277-2 may be a valid DOI for title: Application of Dual-Source Modal Dispersion and Variational Bayesian Monte Carlo Method for Local Geoacoustic Inversion in Weakly Range-Dependent Shallow Water
- 10.3390/pharmaceutics14040749 may be a valid DOI for title: Interrogating and Quantifying In Vitro Cancer Drug Pharmacodynamics via Agent-Based and Bayesian Monte Carlo Modelling
- 10.1162/neco_a_01127 may be a valid DOI for title: Adaptive Gaussian Process Approximation for Bayesian Inference with Expensive Likelihood Functions
- 10.1214/20-ba1200 may be a valid DOI for title: Parallel Gaussian Process Surrogate Bayesian Inference with Noisy Likelihood Evaluations
- 10.1016/0378-3758(91)90002-v may be a valid DOI for title: Bayes–Hermite quadrature

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@rkurchin
Copy link

rkurchin commented Aug 8, 2023

Reviewers @max-little and @gaxler, please let me know if you have any questions about how to get started on your reviews!

@GurjeetSinghSangra, at some point be sure to address those missing DOI's that got flagged above.

@GurjeetSinghSangra
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@GurjeetSinghSangra
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@rkurchin
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10898-012-9951-y is OK
- 10.1109/TTE.2022.3218341 is OK
- 10.1016/j.petsci.2022.06.016 is OK
- 10.1101/2021.03.11.434913 is OK
- 10.1016/j.jmapro.2021.02.052 is OK
- 10.1016/j.jeem.2020.102317 is OK
- 10.1137/040603371 is OK
- 10.1109/wsc.2006.323088 is OK
- 10.1137/080716980 is OK
- 10.1007/s10589-020-00249-0 is OK
- 10.21105/joss.05428 is OK
- 10.1145/3544489 is OK
- 10.1038/s41586-023-06124-2 is OK
- 10.1016/j.neuron.2019.03.043 is OK
- 10.1038/s41593-019-0453-9 is OK
- 10.1038/s41562-019-0804-2 is OK
- 10.1016/j.cub.2019.04.067 is OK
- 10.1016/j.jmapro.2020.07.018 is OK
- 10.3390/en14030626 is OK
- 10.1109/JPROC.2015.2494218 is OK
- 10.23915/distill.00026 is OK
- 10.1016/j.anucene.2020.108046 is OK
- 10.1007/s40857-022-00277-2 is OK
- 10.3390/pharmaceutics14040749 is OK
- 10.1162/neco_a_01127 is OK
- 10.1214/20-ba1200 is OK
- 10.1016/0378-3758(91)90002-V is OK
- 10.21105/joss.00024 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@rkurchin
Copy link

👋 Hi reviewers @max-little and @gaxler, just checking in again on this!

@rkurchin
Copy link

👋 Hi again @max-little and @gaxler, any updates on when you'll be able to start your reviews?

@rkurchin
Copy link

rkurchin commented Sep 5, 2023

@max-little and @gaxler, are you still able to review this submission to JOSS?

@gaxler
Copy link

gaxler commented Sep 5, 2023

Review checklist for @gaxler

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/acerbilab/pybads?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@GurjeetSinghSangra) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@rkurchin
Copy link

Thanks for getting things started here, @gaxler! Checking in with @max-little again... 🔔

@rkurchin
Copy link

rkurchin commented Sep 20, 2023

Sent an email to @max-little to check in; if I don't get a response in a few days I'll find a replacement reviewer.

(link to pre-review for my own reference here so I don't re-ask the same people who already said no: #5544 )

@rkurchin
Copy link

👋 @jungtaekkim, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@jungtaekkim
Copy link

Hi @rkurchin, I am willing to review this submission. Please add me as a reviewer.

@rkurchin
Copy link

@editorialbot add @jungtaekkim as reviewer

@editorialbot
Copy link
Collaborator Author

@jungtaekkim added to the reviewers list!

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10898-012-9951-y is OK
- 10.1109/TTE.2022.3218341 is OK
- 10.1016/j.petsci.2022.06.016 is OK
- 10.1101/2021.03.11.434913 is OK
- 10.1016/j.jeem.2020.102317 is OK
- 10.1016/j.jmapro.2021.02.052 is OK
- 10.1137/040603371 is OK
- 10.1109/wsc.2006.323088 is OK
- 10.1137/080716980 is OK
- 10.1007/s10589-020-00249-0 is OK
- 10.48550/ARXIV.2303.09519 is OK
- 10.1145/3544489 is OK
- 10.1038/s41586-023-06124-2 is OK
- 10.1016/j.neuron.2019.03.043 is OK
- 10.1038/s41593-019-0453-9 is OK
- 10.1038/s41562-019-0804-2 is OK
- 10.1016/j.cub.2019.04.067 is OK
- 10.1016/j.jmapro.2020.07.018 is OK
- 10.1109/JPROC.2015.2494218 is OK
- 10.23915/distill.00026 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@GurjeetSinghSangra
Copy link

I apologise for the missing DOIS, there was a bad copy-paste of the bibliography in the last commit.
@rkurchin, now the DOIS are all fine, with the right format. It should be good for acceptance.

@rkurchin
Copy link

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10898-012-9951-y is OK
- 10.1109/TTE.2022.3218341 is OK
- 10.1016/j.petsci.2022.06.016 is OK
- 10.1101/2021.03.11.434913 is OK
- 10.1016/j.jeem.2020.102317 is OK
- 10.1016/j.jmapro.2021.02.052 is OK
- 10.1137/040603371 is OK
- 10.1109/wsc.2006.323088 is OK
- 10.1137/080716980 is OK
- 10.1007/s10589-020-00249-0 is OK
- 10.48550/ARXIV.2303.09519 is OK
- 10.1145/3544489 is OK
- 10.1038/s41586-023-06124-2 is OK
- 10.1016/j.neuron.2019.03.043 is OK
- 10.1038/s41593-019-0453-9 is OK
- 10.1038/s41562-019-0804-2 is OK
- 10.1016/j.cub.2019.04.067 is OK
- 10.1016/j.jmapro.2020.07.018 is OK
- 10.1109/JPROC.2015.2494218 is OK
- 10.23915/distill.00026 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5053, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Feb 26, 2024
@GurjeetSinghSangra
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@GurjeetSinghSangra
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10898-012-9951-y is OK
- 10.1109/TTE.2022.3218341 is OK
- 10.1016/j.petsci.2022.06.016 is OK
- 10.1101/2021.03.11.434913 is OK
- 10.1016/j.jeem.2020.102317 is OK
- 10.1016/j.jmapro.2021.02.052 is OK
- 10.1137/040603371 is OK
- 10.1109/wsc.2006.323088 is OK
- 10.1137/080716980 is OK
- 10.1007/s10589-020-00249-0 is OK
- 10.48550/ARXIV.2303.09519 is OK
- 10.1145/3544489 is OK
- 10.1038/s41586-023-06124-2 is OK
- 10.1016/j.neuron.2019.03.043 is OK
- 10.1038/s41593-019-0453-9 is OK
- 10.1038/s41562-019-0804-2 is OK
- 10.1016/j.cub.2019.04.067 is OK
- 10.1016/j.jmapro.2020.07.018 is OK
- 10.1109/JPROC.2015.2494218 is OK
- 10.23915/distill.00026 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@GurjeetSinghSangra
Copy link

Dear @rkurchin, after a final review of the paper, we noticed that the acknowledgement of the paper was missing some grant information about the CSC computation resource. Consequently, we just did a small edit in the acknowledgement section and I pushed the changes in the repository branch.
The changed text read as follows:

We thank Bobby Huggins, Chengkun Li, Marlon Tobaben and Mikko Aarnos for helpful comments and feedback.
We also acknowledge support from CSC – IT Center for Science, Finland, for computational resources.
Work on the PyBADS package was supported by the Research Council of Finland Flagship programme: Finnish Center for Artificial Intelligence FCAI, and additionally by project grants 356498 and 358980.

Could you please rerun the acceptance command?
We truly apologise for the inconvenience, but this version should be the final one.

@rkurchin
Copy link

@editorialbot recommend-accept

(not sure if it's actually necessary for me to do it again, but will just in case)

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10898-012-9951-y is OK
- 10.1109/TTE.2022.3218341 is OK
- 10.1016/j.petsci.2022.06.016 is OK
- 10.1101/2021.03.11.434913 is OK
- 10.1016/j.jeem.2020.102317 is OK
- 10.1016/j.jmapro.2021.02.052 is OK
- 10.1137/040603371 is OK
- 10.1109/wsc.2006.323088 is OK
- 10.1137/080716980 is OK
- 10.1007/s10589-020-00249-0 is OK
- 10.48550/ARXIV.2303.09519 is OK
- 10.1145/3544489 is OK
- 10.1038/s41586-023-06124-2 is OK
- 10.1016/j.neuron.2019.03.043 is OK
- 10.1038/s41593-019-0453-9 is OK
- 10.1038/s41562-019-0804-2 is OK
- 10.1016/j.cub.2019.04.067 is OK
- 10.1016/j.jmapro.2020.07.018 is OK
- 10.1109/JPROC.2015.2494218 is OK
- 10.23915/distill.00026 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5056, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@GurjeetSinghSangra
Copy link

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

I'm sorry @GurjeetSinghSangra, I'm afraid I can't do that. That's something only eics are allowed to do.

@arfon
Copy link
Member

arfon commented Feb 29, 2024

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Singh
  given-names: Gurjeet Sangra
  orcid: "https://orcid.org/0009-0008-2340-5867"
- family-names: Acerbi
  given-names: Luigi
  orcid: "https://orcid.org/0000-0001-7471-7336"
contact:
- family-names: Singh
  given-names: Gurjeet Sangra
  orcid: "https://orcid.org/0009-0008-2340-5867"
- family-names: Acerbi
  given-names: Luigi
  orcid: "https://orcid.org/0000-0001-7471-7336"
doi: 10.5281/zenodo.10696782
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Singh
    given-names: Gurjeet Sangra
    orcid: "https://orcid.org/0009-0008-2340-5867"
  - family-names: Acerbi
    given-names: Luigi
    orcid: "https://orcid.org/0000-0001-7471-7336"
  date-published: 2024-02-29
  doi: 10.21105/joss.05694
  issn: 2475-9066
  issue: 94
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 5694
  title: "PyBADS: Fast and robust black-box optimization in Python"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.05694"
  volume: 9
title: "PyBADS: Fast and robust black-box optimization in Python"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.05694 joss-papers#5073
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05694
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Feb 29, 2024
@arfon
Copy link
Member

arfon commented Feb 29, 2024

@jungtaekkim, @vankesteren – many thanks for your reviews here and to @rkurchin for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@GurjeetSinghSangra – your paper is now accepted and published in JOSS ⚡🚀💥

@arfon arfon closed this as completed Feb 29, 2024
@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05694/status.svg)](https://doi.org/10.21105/joss.05694)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05694">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05694/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05694/status.svg
   :target: https://doi.org/10.21105/joss.05694

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@jungtaekkim
Copy link

Congratulations to all authors @GurjeetSinghSangra! Also, thank you @rkurchin, @vankesteren, and @arfon.

@GurjeetSinghSangra
Copy link

We want to thank all the reviewers, editors and the people involved in this review procedure! Finally, we officially published this work in JOSS, expanding the reach of PyBADS to a broader audience of researchers.
Thanks again @rkurchin @vankesteren @jungtaekkim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Batchfile Makefile published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests