Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SPICY: A python toolbox for meshless assimilation from image velocimetry using radial basis functions #5699

Closed
editorialbot opened this issue Jul 27, 2023 · 30 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 27, 2023

Submitting author: @mendezVKI (Miguel Alfonso Mendez)
Repository: https://github.com/mendezVKI/SPICY_VKI
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @philipcardiff
Reviewers: @nolankucd, @MatthewFlamm, @ctdegroot
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ca453152e765cab3bab8a8b57f6aa400"><img src="https://joss.theoj.org/papers/ca453152e765cab3bab8a8b57f6aa400/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ca453152e765cab3bab8a8b57f6aa400/status.svg)](https://joss.theoj.org/papers/ca453152e765cab3bab8a8b57f6aa400)

Author instructions

Thanks for submitting your paper to JOSS @mendezVKI. Currently, there isn't a JOSS editor assigned to your paper.

@mendezVKI if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Jul 27, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=1.52 s (52.0 files/s, 89906.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      24          10477          24993          76426
HTML                            15            911             38           6885
Python                           5            811           2072           3048
SVG                              1              0              0           2671
CSS                              9            341            300           2503
Jupyter Notebook                 8              0           3411           1127
YAML                             2             26             43            205
reStructuredText                10             59             34             98
TeX                              1              8              0             81
Markdown                         2             35              0             59
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            79          12680          30899          93138
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1088/1361-6501/ac70a9 is OK
- 10.1017/s0962492914000130 is OK
- 10.1007/s00348-016-2133-9 is OK
- 10.1007/s00348-021-03172-0 is OK

MISSING DOIs

- 10.18409/ispiv.v1i1.198 may be a valid DOI for title: Main results of the first Data Assimilation Challenge

INVALID DOIs

- https://doi.org/10.1016/j.taml.2020.01.039 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 748

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

@editorialbot invite @philipcardiff as editor

Hi @philipcardiff, could you edit this submission instead?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@philipcardiff
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @philipcardiff is now the editor

@philipcardiff
Copy link

Hi @mendezVKI, see a few minor English edits at mendezVKI/SPICY_VKI#1, which you may like to merge.

We will use this pre-review issue to find reviewers. Feel free to suggest suitable reviewers.

@philipcardiff
Copy link

Hi @nolankucd, would you be interested in reviewing this submission?

The submission under consideration is SPICY: A python toolbox for meshless assimilation from image velocimetry using radial basis functions (https://github.com/mendezVKI/SPICY_VKI).

If you are unfamiliar with JOSS, the review process is unique: it takes place in a GitHub issue, is open, and encourages author-reviewer-editor conversations. You can have a look at our review criteria and review checklist to get an idea of what is expected.

Philip

@nolankucd
Copy link

nolankucd commented Aug 1, 2023 via email

@mendezVKI
Copy link

mendezVKI commented Aug 1, 2023

Hello Philip,

Thank you for handling my submission. I am completely new to JOSS and its review process, so I might mess up in various ways.

I agree with all your English edits, of course. As for the reviewers, using the review checklist with (1) Python programming language, (2) Physics and Engineering as areas of expertise and (3) machine learning + fluid dynamics I get :

Sven Berger
akaptano

Miguel

@philipcardiff
Copy link

@editorialbot add @nolankucd as reviewer

@editorialbot
Copy link
Collaborator Author

@nolankucd added to the reviewers list!

@philipcardiff
Copy link

Dear Philip, This sounds very interesting. I am happy to review. Kevin

Great, thanks Kevin!

@philipcardiff
Copy link

Hello @akaptano, is this submission something you would be interested in reviewing?

@philipcardiff
Copy link

Hi @ctdegroot, would you be interested in reviewing this submission?

The submission under consideration is SPICY: A python toolbox for meshless assimilation from image velocimetry using radial basis functions (https://github.com/mendezVKI/SPICY_VKI).

@philipcardiff
Copy link

Hi @MatthewFlamm, would you be interested in reviewing this submission?

The submission under consideration is SPICY: A python toolbox for meshless assimilation from image velocimetry using radial basis functions (https://github.com/mendezVKI/SPICY_VKI).

@MatthewFlamm
Copy link

I can review this. What is the general timeline for review?

@philipcardiff
Copy link

Thanks, @MatthewFlamm.

Typically, you would post your initial comments within a few weeks, but longer is fine, too, if you are confident you can allocate the time.

For convenience, you can have a look at our review criteria and review checklist.

@philipcardiff
Copy link

@editorialbot add @MatthewFlamm as reviewer

@editorialbot
Copy link
Collaborator Author

@MatthewFlamm added to the reviewers list!

@ctdegroot
Copy link

Yes, I would be happy to review this.

@philipcardiff
Copy link

Yes, I would be happy to review this.

Great, thanks Chris!

@philipcardiff
Copy link

@editorialbot add @ctdegroot as reviewer

@editorialbot
Copy link
Collaborator Author

@ctdegroot added to the reviewers list!

@philipcardiff
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5749.

@philipcardiff
Copy link

Hi all, we can continue at the review issue #5749.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants