-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: pactus: A Python framework for trajectory classification #5738
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
@JustinShenk, @miladmzdh – This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. Please create your checklist typing:
As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Review checklist for @miladmzdhConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Friendly reminder to start your review soon please @JustinShenk. |
Review checklist for @JustinShenkConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Good work @gvieralopez and team! Very cool that you included several feature vectorization methods, datasets and models. Some potential improvements:
Other than these small points, the package and paper look like significant contributions to trajectory analysis. |
Hello @gvieralopez, Impressive effort. I appreciate the structured code and thorough documentation; it's evident that a lot of care went into this. Reviewing your code was a pleasant experience. However, I do have a couple of concerns that I'd like to address:
from yupi.graphics import plot_2d So users can explore the trajectories better and have a sense of what they are working with (both visually and the data attributes). I know your package is not about the exploration of the data but when we have several datasets, better to have some tools to explore or at least have examples to explore the data. You might even have a completely separate example code to explore the datasets a bit.
Good luck and let me know when these issues are taken care of so I can check those points in my "review checklist". |
@JustinShenk @miladmzdh thank you very much for the fast and constructive feedback. @JustinShenk @miladmzdh Best, Gustavo, in the name of all authors. |
@editorialbot generate pdf |
Dear @JustinShenk, Following your suggestions, we have made the following updates to the project:
We appreciate all the effort you put into your response and recommendations, and we are very grateful for your review. |
Dear @miladmzdh, According to your recommendations, we have made the following changes to the project:
Regarding the installation issue you reported, we have been unable to reproduce it. If possible, could you provide a detailed description of the exact error and your system details? You can open an issue in the software repository, and we will ensure to find a solution. We would like to express our gratitude for the time you dedicated to reviewing our work and for providing suggestions to improve it. |
@gvieralopez – many thanks for your detailed responses here. @JustinShenk, @miladmzdh – could I ask that you both review the response from @gvieralopez and check if these changes meet your expectations (and update your checklists accordingly?). |
@editorialbot commands |
Hello @JustinShenk, here are the things you can ask me to do:
|
Good work guys! Accepting this. |
Friendly reminder to check in on this submission again when you have a moment @miladmzdh. We're almost ready to proceed to accept but want to be sure you agree. |
I appreciate your patience. I was attending a conference. I attempted to replicate the error that I used to encounter. However, it appears that the issue has been resolved, as I did not encounter it again. I have accepted all the items on the checklist and I agree to accept this package. If I happen to come across the error in the future, I will reach out to the authors accordingly. |
Thanks @miladmzdh! @JustinShenk – looks like we're very close to being done here. I will circle back here next week, but in the meantime, please give your own paper a final read to check for any potential typos etc. After that, could you make a new release of this software that includes the changes that have resulted from this review. Then, please make an archive of the software in Zenodo/figshare/other service and update this thread with the DOI of the archive? For the Zenodo/figshare archive, please make sure that:
I can then move forward with accepting the submission. |
Dear @arfon, We deeply appreciate your guidance throughout the revision of our manuscript. We have reviewed the paper one more time and all appears to be correct. Furthermore, a new version of the software, which integrates all modifications issued from this review, has been released. We have prepared and uploaded an archive of this software on Zenodo. The archive mirrors the title and authors of the JOSS paper, maintaining consistency. The archive is accessible via the following link: https://zenodo.org/record/8352324. The corresponding DOI is: 10.5281/zenodo.8352324. We are thankful for your assistance, and the insights provided during this process by all the reviewers. We look forward to any further steps that may be necessary. Best Regards, Gustavo, on behalf of all the authors |
@editorialbot set 10.5281/zenodo.8352324 as archive |
Done! archive is now 10.5281/zenodo.8352324 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4598, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@JustinShenk, @miladmzdh – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @gvieralopez – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks @arfon. We really enjoyed the process. Many thanks to the reviewers @JustinShenk and @miladmzdh for their fast and precise comments. We just included the citation as recommended. We are all very happy with the publication. Thanks again! |
Submitting author: @gvieralopez (Gustavo Viera-López)
Repository: https://github.com/yupidevs/pactus
Branch with paper.md (empty if default branch):
Version: v0.4.0
Editor: @arfon
Reviewers: @JustinShenk, @miladmzdh
Archive: 10.5281/zenodo.8352324
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@JustinShenk & @miladmzdh, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @miladmzdh
📝 Checklist for @JustinShenk
The text was updated successfully, but these errors were encountered: