New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Phasik: a Python package to identify system states in partially temporal networks #5872
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋🏼 @maximelucas, @GiulioRossetti, @alexbovet - this is the review thread for the submission. All of our communications will happen here from now on. Please check the post at the top of the issue for instructions on how to generate your own review checklist. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues directly in the software repository. If you do so, please mention this thread so that a link is created (and I can keep an eye on what is happening). Please also feel free to comment and ask questions in this thread. It is often easier to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. Please feel free to ping me (@csoneson) if you have any questions or concerns. Thanks! |
Five most similar historical JOSS papers: pyscal: A python module for structural analysis of atomic environments PyTeNet: A concise Python implementation of quantum tensor network algorithms Sinaps: A Python library to simulate voltage dynamics and ionic electrodiffusion in neurons Pycrostates: a Python library to study EEG microstates phasespace: n-body phase space generation in Python |
Review checklist for @GiulioRossettiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @alexbovetConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @csoneson, as you asked, just linking an issue raised by @alexbovet (thanks!). I have fixed it since then. |
👋🏻 Just wanted to check in on the reviews here. |
I'm happy with the current state of the submission. Everything looks good to me! |
👋🏻 @GiulioRossetti - could you provide a quick update on the status of your review here? Thanks! |
Sorry for the delay. A few deadlines have blocked me during the last two weeks. I'll complete the review by next Monday at the latest! |
Thank you for the suggestion @GiulioRossetti, good catch, I'll get right to it. |
@csoneson I've now answered @GiulioRossetti's suggestions with two PRs. Once he is happy with the changes I'll make a new release of the library. |
@csoneson @maximelucas I checked the PRs: they are perfect! Everything looks good to me! |
Thanks a lot @GiulioRossetti! I now released v1.3.4. |
Thanks @GiulioRossetti and @alexbovet for confirming that you are happy with the state of this submission. @maximelucas - I will take a quick look as well, and get back to you with the next steps. |
@editorialbot generate pdf |
@editorialbot check references |
|
Thanks @maximelucas - only one abbreviated journal left (Masuda & Holme). Apart from that, looks good. You don't need to bump the version again (also since the paper anyway is not in the main branch). |
@editorialbot generate pdf |
Thank you, good catch! |
@editorialbot set 10.5281/zenodo.10113244 as archive |
Done! archive is now 10.5281/zenodo.10113244 |
@editorialbot set v1.3.4 as version |
Done! version is now v1.3.4 |
Thanks @maximelucas - one final thing: the license in your GitLab repo is 'GPL 3.0 or later', while the one in Zenodo is 'GPL v3.0 only'. Could you make these consistent please? |
Thank you @csoneson, I didn't know this difference existed. Done. |
Great! I think we're pretty much ready - I'll hand over to the track Associate EiC for the last steps. Thanks for submitting to JOSS! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4776, then you can now move forward with accepting the submission by compiling again with the command |
@maximelucas as AEiC I will now help to process the final steps for this submission. I have checked this review, the software repository, the paper, and the archive link. Most looks in order, however, the below point needs your attention:
|
Thank you! |
@maximelucas thanks. All looks good now so we'll proceed to process this for acceptance. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@maximelucas congratulations on this JOSS publication! Thanks for editing @csoneson! And a special thanks to the reviewers: @GiulioRossetti, @alexbovet ! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Great, thank you @Kevin-Mattheus-Moerman, @csoneson, @GiulioRossetti, and @alexbovet for your time with this! |
Submitting author: @maximelucas (Maxime Lucas)
Repository: https://gitlab.com/habermann_lab/phasik
Branch with paper.md (empty if default branch): joss-paper
Version: v1.3.4
Editor: @csoneson
Reviewers: @GiulioRossetti, @alexbovet
Archive: 10.5281/zenodo.10113244
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@GiulioRossetti & @alexbovet, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @csoneson know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @GiulioRossetti
📝 Checklist for @alexbovet
The text was updated successfully, but these errors were encountered: