Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SODA: Software to Support the Curation and Sharing of FAIR Autonomic Nervous System Data #5952

Closed
editorialbot opened this issue Oct 15, 2023 · 36 comments
Assignees
Labels
CSS JavaScript pre-review Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 15, 2023

Submitting author: @bvhpatel (Bhavesh Patel)
Repository: https://github.com/fairdataihub/SODA-for-SPARC
Branch with paper.md (empty if default branch): paper
Version: v12.3.1
Editor: @AJQuinn
Reviewers: @mattsouth, @yarikoptic, @abhishektiwari
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/898e78fe847cd31dea1ff40bdab62f48"><img src="https://joss.theoj.org/papers/898e78fe847cd31dea1ff40bdab62f48/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/898e78fe847cd31dea1ff40bdab62f48/status.svg)](https://joss.theoj.org/papers/898e78fe847cd31dea1ff40bdab62f48)

Author instructions

Thanks for submitting your paper to JOSS @bvhpatel. Currently, there isn't a JOSS editor assigned to your paper.

@bvhpatel if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Oct 15, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.72 s (358.1 files/s, 369609.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      73           5206           4766         141225
JSON                             8              0              0          38595
HTML                            23            641            276          25454
CSS                             27           3360            376          22457
Python                          81           2873           1970           9478
SVG                             13              4              4           3095
Jupyter Notebook                 2              0           1607           1656
Markdown                         8            429              0           1068
YAML                            13             67             47            414
TeX                              1             10              0             95
XML                              4              0              0             55
Bourne Shell                     4              4              0             12
-------------------------------------------------------------------------------
SUM:                           257          12594           9046         243604
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1435

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1101/2021.04.01.438136 may be a valid DOI for title: The SPARC DRC: building a resource for the autonomic nervous system community
- 10.1101/2022.04.18.488694 may be a valid DOI for title: Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool
- 10.1101/2021.08.08.455581 may be a valid DOI for title: KnowMore: an automated knowledge discovery tool for the FAIR SPARC datasets
- 10.1101/2021.02.10.430563 may be a valid DOI for title: Sparc data structure: Rationale and design of a fair standard for biomedical research data
- 10.1096/fasebj.2020.34.s1.02483 may be a valid DOI for title: SPARC: SODA, an interactive software for curating SPARC datasets
- 10.1101/2021.10.22.465507 may be a valid DOI for title: SPARClink: an interactive tool to visualize the impact of the SPARC program

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

DataLad: distributed system for joint management of code, data, and their relationship
Submitting author: @yarikoptic
Handling editor: @arokem (Retired)
Reviewers: @szorowi1, @jkanche
Similarity score: 0.8441

DASF: A data analytics software framework for distributed environments
Submitting author: @d-eggert
Handling editor: @martinfleis (Active)
Reviewers: @cjwu, @pritchardn
Similarity score: 0.8325

The AutoActive Research Environment
Submitting author: @kasbot
Handling editor: @prashjha (Active)
Reviewers: @AustinTSchaffer, @erik-whiting
Similarity score: 0.8273

DARE Platform: a Developer-Friendly and Self-Optimising Workflows-as-a-Service Framework for e-Science on the Cloud
Submitting author: @iaklampanos
Handling editor: @danielskatz (Active)
Reviewers: @rafaelfsilva, @Himscipy
Similarity score: 0.8246

DoSOCS: A System for SPDX 2.0 Document Creation and Storage
Submitting author: @germonprez
Handling editor: @arfon (Active)
Reviewers: @mlinksva
Similarity score: 0.8180

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman changed the title [PRE REVIEW]: SODA: Software to Support the Curation and Sharing 1 of FAIR Autonomic Nervous System Data [PRE REVIEW]: SODA: Software to Support the Curation and Sharing of FAIR Autonomic Nervous System Data Oct 16, 2023
@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @AJQuinn as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@AJQuinn
Copy link

AJQuinn commented Oct 17, 2023

Hello @Kevin-Mattheus-Moerman - happy to take this one. Thanks

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign @AJQuinn as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @AJQuinn is now the editor

@AJQuinn
Copy link

AJQuinn commented Nov 1, 2023

Hi @bvhpatel - apologies for the delay getting started on this. Will start finding reviewers over the next few days.

In the meantime, could you double check the DOIs in your paper draft. You have valid bibtex on your branch https://github.com/fairdataihub/SODA-for-SPARC/blob/paper/paper/paper.bib but it looks like the entries don't have a doi key or a url. For example - from a quick glance, the Wilkinson et al 2016 ref should include the following lines

  doi = {10.1038/sdata.2016.18},
  url = {https://doi.org/10.1038/sdata.2016.18},

Could you review the bibtex and let me know when you have an update?

@AJQuinn
Copy link

AJQuinn commented Nov 2, 2023

@editorialbot add @mattsouth as reviewer

@editorialbot
Copy link
Collaborator Author

@mattsouth added to the reviewers list!

@bvhpatel
Copy link

bvhpatel commented Nov 5, 2023

@AJQuinn Thanks! I have added the DOIs.

@AJQuinn
Copy link

AJQuinn commented Nov 6, 2023

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/sdata.2016.18 is OK
- 10.3389/fphys.2021.693735 is OK
- 10.1038/s41597-023-02463-x is OK
- 10.12688/f1000research.73492.1 is OK
- 10.1101/2021.02.10.430563 is OK
- 10.1096/fasebj.2020.34.s1.02483 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.12688/f1000research.75071.1) is INVALID

@AJQuinn
Copy link

AJQuinn commented Nov 6, 2023

Thank you @bvhpatel - looking good though one final tweak is needed, details in the issue linked above.

@AJQuinn
Copy link

AJQuinn commented Nov 6, 2023

👋 Hello - @yarikoptic would you be willing to review this submission for JOSS? The code repository and paper details are further up in this thread.

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html - please check them out for more information and please feel free to ask questions in this thread.

@yarikoptic
Copy link

cool, will do. Looking forward to familiarize myself with SODA more!

@AJQuinn
Copy link

AJQuinn commented Nov 7, 2023

Thanks @yarikoptic - much appreciated

@AJQuinn
Copy link

AJQuinn commented Nov 7, 2023

@editorialbot add @yarikoptic as reviewer

@editorialbot
Copy link
Collaborator Author

@yarikoptic added to the reviewers list!

@AJQuinn
Copy link

AJQuinn commented Nov 8, 2023

👋 Hello - @ixjlyons would you be willing to review this submission for JOSS? The code repository and paper details are further up in this thread.

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html - please check them out for more information and please feel free to ask questions in this thread.

Cheers!

@AJQuinn
Copy link

AJQuinn commented Nov 8, 2023

Hi @bvhpatel - Given the size of your code base I'll try to find one additional reviewer, there is a lot to cover for two. Hopefully we can get started in the next few days.

@ixjlyons
Copy link

@AJQuinn my web app experience is rather limited - I think I should decline this one.

@abhishektiwari
Copy link

@AJQuinn I will be happy to assist with review of this paper.

@Kevin-Mattheus-Moerman
Copy link
Member

@AJQuinn please pick up the reviewer searching/assigning process and proceed to review when possible.

@yarikoptic
Copy link

sorry for the delay - was traveling/sick/traveling. Will provide review within 2-3 days.

@Kevin-Mattheus-Moerman
Copy link
Member

@yarikoptic no worries, the review actually has not started yet, since this is the pre-review issue. Once @AJQuinn has assigned the right amount of reviewers they'll trigger the actually review issue.

@AJQuinn
Copy link

AJQuinn commented Dec 11, 2023

Hi @bvhpatel @Kevin-Mattheus-Moerman - sincere apologies for letting this drift. I'm back in normal business this week.

@AJQuinn
Copy link

AJQuinn commented Dec 11, 2023

@editorialbot add @abhishektiwari as reviewer

@editorialbot
Copy link
Collaborator Author

@abhishektiwari added to the reviewers list!

@AJQuinn
Copy link

AJQuinn commented Dec 11, 2023

Thanks @abhishektiwari - much appreciated!

@AJQuinn
Copy link

AJQuinn commented Dec 11, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS JavaScript pre-review Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

7 participants