Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ETHOS.FINE: A Framework for Integrated Energy System Assessment #5965

Closed
editorialbot opened this issue Oct 20, 2023 · 37 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 20, 2023

Submitting author: @t-gross (Theresa Gross)
Repository: https://github.com/FZJ-IEK3-VSA/FINE
Branch with paper.md (empty if default branch): paper
Version: v2.3.0
Editor: @arfon
Reviewers: @GregorBecker, @olejandro, @leonardgoeke
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c4c62e14f2273e97606b1eb96d58bec6"><img src="https://joss.theoj.org/papers/c4c62e14f2273e97606b1eb96d58bec6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c4c62e14f2273e97606b1eb96d58bec6/status.svg)](https://joss.theoj.org/papers/c4c62e14f2273e97606b1eb96d58bec6)

Author instructions

Thanks for submitting your paper to JOSS @t-gross. Currently, there isn't a JOSS editor assigned to your paper.

@t-gross if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Oct 20, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.41 s (383.4 files/s, 135741.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          92           4996           8228          24874
Jupyter Notebook                12              0          12442           2506
HTML                             2            165              4            605
TeX                              1             31              0            479
reStructuredText                34            317            265            378
YAML                             6             21             37            205
Markdown                         5             70              0            167
DOS Batch                        3             21              1             46
TOML                             1              5              8             38
make                             1              4              7             10
Dockerfile                       1              5              1              8
-------------------------------------------------------------------------------
SUM:                           158           5635          20993          29316
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for FINE-paper.md is 1532

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ijhydene.2019.08.032 is OK
- 10.1016/j.ijhydene.2020.12.197 is OK
- 10.3390/en12142825 is OK
- 10.1016/j.energy.2018.05.059 is OK
- 10.1016/j.ijhydene.2018.11.194 is OK
- 10.3390/en13030641 is OK
- 10.1016/j.apenergy.2022.119029 is OK
- 10.1016/j.ijhydene.2021.04.036 is OK
- 10.1016/j.apenergy.2018.01.023 is OK
- 10.1016/j.rser.2018.11.020 is OK
- 10.1016/j.enbuild.2022.112480 is OK
- 10.1016/j.ijhydene.2021.04.036 is OK
- 10.3390/en15103801 is OK
- 10.3390/en15249517 is OK
- 10.1007/s11590-021-01826-w is OK
- 10.1016/j.adapen.2021.100063 is OK
- 10.1016/j.ijhydene.2023.05.308 is OK
- 10.1016/j.adapen.2023.100148 is OK
- 10.1016/j.ijhydene.2023.05.012 is OK
- 10.1016/j.rset.2023.100059 is OK
- 10.18154/RWTH-2023-01485 is OK
- 10.18154/RWTH-2023-01465 is OK

MISSING DOIs

- 10.1007/s12532-011-0026-8 may be a valid DOI for title: Pyomo: modeling and solving mathematical programs in Python

INVALID DOIs

- arXiv:2103.16657 is INVALID (failed connection)

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Paper file not found.

@kyleniemeyer
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Paper file not found.

@kyleniemeyer
Copy link

Hi @openjournals/dev, it seems the wordcount function can find the paper, but something with generating the PDF is failing. Any ideas?

@kyleniemeyer
Copy link

Hi @t-gross, we'll try to figure out what's going on with your paper, but unfortunately we don't have an editor in this area available to take on another submission right now, and so I have to place yours on the waitlist until someone can take it.

@kyleniemeyer kyleniemeyer added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Oct 24, 2023
@xuanxu
Copy link
Member

xuanxu commented Oct 25, 2023

For the PDF to compile the source file should be named paper.md

@t-gross
Copy link

t-gross commented Oct 30, 2023

Thanks for the comments. I just changed the filename to paper.md and also added/changed the missing and invalid dois.

@kyleniemeyer
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems
Submitting author: @DCoppitters
Handling editor: @fraukewiese (Active)
Reviewers: @andr1976, @ClaraBuettner
Similarity score: 0.8453

besos: Building and Energy Simulation, Optimization and Surrogate Modelling
Submitting author: @TheoChristiaanse
Handling editor: @sjpfenninger (Retired)
Reviewers: @fneum, @willu47
Similarity score: 0.8345

FAME-Core: An open Framework for distributed Agent-based Modelling of Energy systems
Submitting author: @KriNiTi
Handling editor: @fraukewiese (Active)
Reviewers: @xtruan, @pgranato
Similarity score: 0.8310

TESPy: Thermal Engineering Systems in Python
Submitting author: @fwitte
Handling editor: @kyleniemeyer (Active)
Reviewers: @arosen93, @corentin-dev
Similarity score: 0.8245

Utopia: A Comprehensive and Collaborative Modeling Framework for Complex and Evolving Systems
Submitting author: @peanutfun
Handling editor: @arfon (Active)
Reviewers: @platipodium, @Shibabrat, @szhorvat
Similarity score: 0.8244

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ijhydene.2019.08.032 is OK
- 10.1016/j.ijhydene.2020.12.197 is OK
- 10.3390/en12142825 is OK
- 10.1016/j.energy.2018.05.059 is OK
- 10.1016/j.ijhydene.2018.11.194 is OK
- 10.1007/s12532-011-0026-8 is OK
- 10.3390/en13030641 is OK
- 10.1016/j.apenergy.2021.117825 is OK
- 10.1016/j.apenergy.2022.119029 is OK
- 10.1016/j.ijhydene.2021.04.036 is OK
- 10.1016/j.apenergy.2018.01.023 is OK
- 10.1016/j.rser.2018.11.020 is OK
- 10.1016/j.enbuild.2022.112480 is OK
- 10.1016/j.ijhydene.2021.04.036 is OK
- 10.3390/en15103801 is OK
- 10.3390/en15249517 is OK
- 10.1007/s11590-021-01826-w is OK
- 10.1016/j.adapen.2021.100063 is OK
- 10.1016/j.ijhydene.2023.05.308 is OK
- 10.1016/j.adapen.2023.100148 is OK
- 10.1016/j.ijhydene.2023.05.012 is OK
- 10.1016/j.rset.2023.100059 is OK
- 10.18154/RWTH-2023-01485 is OK
- 10.18154/RWTH-2023-01465 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@kyleniemeyer
Copy link

@editorialbot invite @fraukewiese as editor

Hi @fraukewiese, could you edit this submission? It's been in our waitlist for a little while now.

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@fraukewiese
Copy link

I am very sorry. I looks really interesting, but I am fully overbooked currently.

@arfon
Copy link
Member

arfon commented Jan 20, 2024

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @arfon is now the editor

@arfon arfon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 20, 2024
@arfon
Copy link
Member

arfon commented Jan 20, 2024

👋 @t-gross, thanks for your submission to JOSS. I'll be your handling editor for this submission. As I start to look for good reviewers for this submission, I'd appreciate any suggestions for reviewers you think might be a good fit here. Thank you!

@t-gross
Copy link

t-gross commented Jan 22, 2024

👋 @t-gross, thanks for your submission to JOSS. I'll be your handling editor for this submission. As I start to look for good reviewers for this submission, I'd appreciate any suggestions for reviewers you think might be a good fit here. Thank you!

Thank you for taking over as editor. As suggestions for reviewers, we could imagine leonardgoeke being a good candidate. From searching in the list of people that have already agreed to review, olejandro and GregorBecker might fit.

@arfon
Copy link
Member

arfon commented Jan 22, 2024

👋 @olejandro @GregorBecker @leonardgoeke @KriNiTi – would any of you be willing to review this submission for JOSS? The submission under consideration is ETHOS.FINE: A Framework for Integrated Energy System Assessment

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can learn more about the process in these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

Based on your experience, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out!

Many thanks
Arfon

@GregorBecker
Copy link

@arfon I would be happy to review the software. Due to my busy schedule I can't guarantee to finish it before mid-February. If that is enough, you are free to add me as a reviewer.

@olejandro
Copy link

@arfon similar here. Most likely I won't be able to finish the review before end of February. If that's okay, I am happy to review the submission.

@leonardgoeke
Copy link

@arfon My situation is similar. I could review the submission by the end of February.

@arfon
Copy link
Member

arfon commented Jan 24, 2024

Thanks @olejandro @GregorBecker and @leonardgoeke. The end of February would be completely acceptable. I'm going to go ahead and add you as reviewers and start the review now...

@arfon
Copy link
Member

arfon commented Jan 24, 2024

@editorialbot add @GregorBecker as reviewer

@editorialbot
Copy link
Collaborator Author

@GregorBecker added to the reviewers list!

@arfon
Copy link
Member

arfon commented Jan 24, 2024

@editorialbot add @olejandro as reviewer

@editorialbot
Copy link
Collaborator Author

@olejandro added to the reviewers list!

@arfon
Copy link
Member

arfon commented Jan 24, 2024

@editorialbot add @leonardgoeke as reviewer

@editorialbot
Copy link
Collaborator Author

@leonardgoeke added to the reviewers list!

@arfon
Copy link
Member

arfon commented Jan 24, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6274.

@arfon
Copy link
Member

arfon commented Jan 24, 2024

@GregorBecker, @olejandro, @leonardgoeke, @t-gross – see you over in #6274 where the actual review will take place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants