New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: mei-friend: An Interactive Web-based Editor for Digital Music Encodings #6002
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@editorialbot generate pdf |
@wergo happy to announce that we found two reviewers so quickly. While the reviewers are getting started, maybe you can already go ahead and try to fix the invalid DOI error? |
Review checklist for @stefan-balkeConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @rlskoeserConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Thanks for reviewing! DOI error is fixed (superfluous https://doi.org/ removed). |
Hi @wergo, thanks for your contribution. I think the I would propose the following additions:
Keep up the great work. Since JOSS is focused on the Software aspect, please include the above mentioned, mainly docs, issues. |
As requested by the editor, I added issues to the software's repo. |
Dear @stefan-balke, many thanks for the valuable comments and suggestions which we will be carefully including into our submission. |
@wergo to keep this review issue clean, please discuss unit test alternative in the respective issue |
Hi, @wergo, some feedback for you on the software paper. Your statement of need is clear, but I think a couple of aspects could be stated more explicitly:
|
I've now worked through the installation instructions and was able to get mei-friend working locally - very cool to see the musical notation and the xml linked and editable. This seems like a really powerful and elegant interface, and I found myself wishing there was a tutorial to give me a little more of an orientation to the kinds of things I might be able to do, but I was able to poke around and try a few things out. When you update the installation documentation, you should make sure you link to the documentation you have on github pages about how to use it. A tutorial is a nice-to-have, not essential - you have thorough usage documentation already. installationMy feedback on the installation has significant overlap with what Stefan has already pointed out.
I second Stefan's comments about the code organization, developer documentation, and tests. community guidelinesI'm glad to see you're seeing issue templates, that's great. You might think about revamping your public repertoire submission template so that it looks more like a form with sections, and documentation with each section instead of all at the top. (Basically, structure them a bit more like the bug and feature request templates). GitHub has documentation and examples for making a contributing guidelines document: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors |
@rlskoeser Thanks for your in depth review. Can you please open issues in the mei-friend repository and link back to this issue here so that we can better track down the progress. As I understand, some of your review points are just suggestions, so feel free to only convert "mandatory" points issues. 🙏 |
@faroit thanks for the reminder, I'll create issues to document these (at least the essentials) when I'm able to do so. @faroit question for you: how much of the functionality should I test? Should I try everything covered in the readme? I think the major points I haven't tried are the portions using github auth and annotation. |
I've created issues on mei-friend based on my review. |
Dear @rlskoeser thank you so much for your input. We will work through them thoroughly in the next weeks. Best, Werner |
👋 @wergo – how are you getting on with your edits? |
We are on our way, but need some time to implement a comprehensive test framework. We are implementing this using Playwright. We are aiming to have the re-submission ready by early March. |
@wergo great to hear about the progress. Just to clarify, you don't need to do a resubmission just updating the code or create a PR and triggering a notification here is enough for us to review the changes. |
@editorialbot remind @wergo in seven days |
Reminder set for @wergo in seven days |
👋 @wergo, please update us on how things are progressing here (this is an automated reminder). |
We have responded to almost all issues raised by the reviewers. We are still working on a solid first set of tests to be merged. We hopefully will be able to notify you on the completed revision very soon. |
@editorialbot remind @wergo in 6 days |
Reminder set for @wergo in 6 days |
👋 @wergo, please update us on how things are progressing here (this is an automated reminder). |
@wergo can you please update us on the status of the revisions? I see that there are lots of changes outside of the |
@faroit Thank you for your patience! We have now responded to all of the issues raised by the reviewers and have pushed our update code including the PlayWright test suite to our staging environment (staging branch). We plan to release the update code to production (https://mei-friend.mdw.ac.at) in the coming few days as version 1.0.12. Regarding @rlskoeser's suggestion about a tutorial, please note that tutorial slides exist at https://tinyurl.com/mei-friend-workshop. These make extensive use of mei-friend's URL parameter remote control feature to guide users through a simple encoding session. We would be grateful for your feedback and whether further changes are required. |
Dear @faroit, a quick update regarding our playwright tests: they are now automatically launched by a pre-push git-hook which executes on the 'testing', 'staging', and 'main' branches (i.e., those that are served by the publicly-visible *.mei-friend.mdw.ac.at service). The hook is supplied in the repository under a new |
May I ask for a brief update on the review process? Is any further information or action required from our side at this stage? |
Hey @musicog, thanks for the efforts. I commented on the respective issues. Thanks for all the work and sorry for the delay, I was pretty busy in the last months, but I hope, that this review process was also a little help for you to make this tool better. It's starting to get used by the community so this is a big win! From my side, I would be happy to proceed to publication. |
@stefan-balke No need to apologise! Thank you very much (also to @rlskoeser!) for your in-depth feedback, this was very helpful to put mei-friend on a more sustainable footing. We'll continue to work further in this direction in future work. |
@stefan-balke Thank you so much for your detailed feedback! This helped a lot to improve the project! All the best, Werner |
@rlskoeser can you please update us on the status of your review? The authors have made recent changes, so please check back on the open issues and your checklist |
Thanks for pinging me, I'll try to take a look this week and see if I can sign off the remaining items on my checklist. |
Submitting author: @wergo (Werner Goebl)
Repository: https://github.com/mei-friend/mei-friend
Branch with paper.md (empty if default branch): joss2023
Version: v1.0.0
Editor: @faroit
Reviewers: @stefan-balke, @rlskoeser
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@stefan-balke & @rlskoeser, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @faroit know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @stefan-balke
📝 Checklist for @rlskoeser
The text was updated successfully, but these errors were encountered: