New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Shapelets: A Python package implementing shapelet functions and their applications #6058
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @tbmiller-astroConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@AoifeHughes Could this software report be rerun, I am relatively sure it was using the publications branch of the repository, which did not have up-to-date code, I just merged it with the main branch and if the report is run now it will reflect the actual number of source files, lines of code, comments, etc. |
@editorialbot check repository |
|
Wordcount for |
@tbmiller-astro, @Anshuman5 how are the reviews coming along? |
Review checklist for @Anshuman5Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@AoifeHughes reviews will take another 2-3 weeks. |
@AoifeHughes I have some time the next few days and hope to be done the initial review by the end of the week |
Hi, I was actually able to get my initial review done this afternoon. The package overall looks great, well done @nasserma and the other authors. There are a few issues I found. Two major ones to do with missing |
Hi @tbmiller-astro - thanks for the comments. I closed one issue regarding the unit testing and |
@mptino I re-opened this issue, once @tbmiller-astro is satisfied we can close it. |
@tbmiller-astro @Anshuman5 We are working through these issues this week and should have most of the issues address by the end of the year, sorry for the wait! |
@tbmiller-astro @Anshuman5 We have addressed all of the issues that you have brought-up with the package, please see more detailed descriptions in the responses to those issues. Is there anything else we should address as part of the first round of review comments? |
@nasserma thank you for fixing the issues. I do not have any additional comments. Also, I have updated the review checklist above. |
@Anshuman5 thanks for your efforts! |
Well done @nasserma and the other authors, my checklist is completed now too and I have no further issues. |
Thanks @tbmiller-astro ! @AoifeHughes I think we addressed all of the reviewer comments, please let us know if anything else is needed, thanks. |
@AoifeHughes just checking in, are there any further actions on our part regarding the review? |
|
@nasserma it does look like DOIs might be available for two of those references, can you add?
No need to update the archive, just the paper. |
@editorialbot check references |
|
@kyleniemeyer sorry for the oversights, they are corrected. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5141, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot recommend-accept |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5142, then you can now move forward with accepting the submission by compiling again with the command |
@kyleniemeyer could we have the rest of the day to go through the manuscript, just one last proof? |
@nasserma sure thing. I'll plan to finalize tomorrow |
@kyleniemeyer thanks, we have made many minor typographical and grammatical corrections, we think the manuscript is finalized. |
@editorialbot generate pdf |
looks good to me! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @nasserma on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already. Many thanks to @tbmiller-astro and @Anshuman5 for reviewing this. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @nasserma (Nasser Mohieddin Abukhdeir)
Repository: https://github.com/uw-comphys/shapelets
Branch with paper.md (empty if default branch): publications
Version: v1.0
Editor: @kyleniemeyer
Reviewers: @tbmiller-astro, @Anshuman5
Archive: 10.5281/zenodo.10819578
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@tbmiller-astro & @Anshuman5, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @AoifeHughes know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @tbmiller-astro
📝 Checklist for @Anshuman5
The text was updated successfully, but these errors were encountered: