Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: hillmaker: A Python package for occupancy analysis in discrete entity flow systems #6088

Closed
editorialbot opened this issue Nov 24, 2023 · 25 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 24, 2023

Submitting author: @misken (Mark Isken)
Repository: https://github.com/misken/hillmaker
Branch with paper.md (empty if default branch):
Version: v0.8.0
Editor: @mstimberg
Reviewers: @rerickson-usgs, @HLasse
Managing EiC: Olivia Guest

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cd579f0843aedb47cea2ddc6cd2be666"><img src="https://joss.theoj.org/papers/cd579f0843aedb47cea2ddc6cd2be666/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cd579f0843aedb47cea2ddc6cd2be666/status.svg)](https://joss.theoj.org/papers/cd579f0843aedb47cea2ddc6cd2be666)

Author instructions

Thanks for submitting your paper to JOSS @misken. Currently, there isn't a JOSS editor assigned to your paper.

@misken if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences labels Nov 24, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.13 s (434.9 files/s, 171945.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          14           1049           1708           2364
Markdown                         7            179              0            427
Jupyter Notebook                11              0          14767            406
TOML                            11             71            102            196
TeX                              2             13              0            144
YAML                             7             30             40            139
reStructuredText                 2             28              6             58
Bourne Shell                     1              0             10             10
-------------------------------------------------------------------------------
SUM:                            55           1370          16633           3744
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 897

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.3509134 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.21105/joss.03021 is OK

MISSING DOIs

- 10.1142/s0219622002000439 may be a valid DOI for title: Modeling and analysis of occupancy data: A healthcare capacity planning application
- 10.1007/s10729-010-9141-8 may be a valid DOI for title: An open source software project for obstetrical procedure scheduling and occupancy analysis
- 10.2139/ssrn.2437936 may be a valid DOI for title: Design and optimization methods for elective hospital admissions
- 10.1016/j.ejor.2010.06.021 may be a valid DOI for title: A statistical Markov chain approximation of transient hospital inpatient inventory
- 10.1177/03611981221115086 may be a valid DOI for title: Enabling Factors and Durations Data Analytics for Dynamic Freight Parking Limits
- 10.4018/978-1-60960-872-9.ch019 may be a valid DOI for title: Using Patient Flow to Examine Hospital Operations

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

timeseriesflattener: A Python package for summarizing features from (medical) time series
Submitting author: @MartinBernstorff
Handling editor: @mstimberg (Active)
Reviewers: @yarikoptic, @Ebedthan
Similarity score: 0.7880

epipack: An infectious disease modeling package for Python
Submitting author: @benmaier
Handling editor: @fboehm (Active)
Reviewers: @chrisvoncsefalvay, @esteinig
Similarity score: 0.7877

skedm: Empirical Dynamic Modeling
Submitting author: @nickc1
Handling editor: @jakevdp (Retired)
Reviewers: @johnh2o2
Similarity score: 0.7861

PyGDH: Python Grid Discretization Helper
Submitting author: @kfhiga
Handling editor: @melissawm (Retired)
Reviewers: @JamieJQuinn, @zhaowei0566
Similarity score: 0.7816

Wakeflow: A Python package for semi-analytic models of planetary wakes
Submitting author: @TomHilder
Handling editor: @dfm (Active)
Reviewers: @richteague, @andizq
Similarity score: 0.7816

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@misken
Copy link

misken commented Nov 25, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

hmis: A python tool to visualize and analyze HMIS data
Submitting author: @mattbellis
Handling editor: @leeper (Retired)
Reviewers: @alexhanna
Similarity score: 0.7906

epipack: An infectious disease modeling package for Python
Submitting author: @benmaier
Handling editor: @fboehm (Active)
Reviewers: @chrisvoncsefalvay, @esteinig
Similarity score: 0.7845

skedm: Empirical Dynamic Modeling
Submitting author: @nickc1
Handling editor: @jakevdp (Retired)
Reviewers: @johnh2o2
Similarity score: 0.7831

Computer-Aided Generation of N-shift RWS
Submitting author: @benjaminbolling
Handling editor: @majensen (Active)
Reviewers: @ShantanuDash, @magedhelmy1
Similarity score: 0.7805

Wakeflow: A Python package for semi-analytic models of planetary wakes
Submitting author: @TomHilder
Handling editor: @dfm (Active)
Reviewers: @richteague, @andizq
Similarity score: 0.7781

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@misken
Copy link

misken commented Nov 25, 2023

I added the missing doi values. All of the ones suggested by the bot were indeed correct. There's one proceedings paper that doesn't appear to have a doi.

@editorialbot
Copy link
Collaborator Author

Hello @markur4, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@markur4
Copy link

markur4 commented Dec 6, 2023

please excuse the confusion, I hastily asked editorialbot for commands without realizing I was in the wrong thread (I'm new to this)!

@misken
Copy link

misken commented Dec 6, 2023

No worries :)

@oliviaguest
Copy link
Member

@mstimberg do you have capacity for this?

@mstimberg
Copy link

@oliviaguest Yes, I'd be happy to edit this.

@mstimberg
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @mstimberg is now the editor

@mstimberg
Copy link

👋 @misken I will edit your submission and do my best to facilitate the review process. I've started contacting reviewers over mail, and hopefully we can start the actual review soon. If you have any suggestions for potential reviewers, please let me know here in this thread (without tagging them with an @).

@mstimberg
Copy link

@editorialbot add @rerickson-usgs as reviewer

Thanks again for helping out with this review 🙏

@editorialbot
Copy link
Collaborator Author

@rerickson-usgs added to the reviewers list!

@misken
Copy link

misken commented Dec 15, 2023

Thank you. This is my first submission to JOSS and don't have any reviewer suggestions. It's a pretty straightforward application and reviewers wouldn't need any special background beyond basic applied statistics.

@mstimberg
Copy link

@editorialbot add @HLasse as reviewer

Thanks again for agreeing to review 🙏

@editorialbot
Copy link
Collaborator Author

@HLasse added to the reviewers list!

@mstimberg
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants