-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Project RACCOON: Automated construction of PDB files for polymers and polymer peptide conjugates #6293
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋🏼 @moritzobenauer @taoliu032 @lorenzo-rovigatti, this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@jromanowska) if you have any questions/concerns. |
Review checklist for @taoliu032Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @lorenzo-rovigattiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@moritzobenauer Hi Moritz, firstly thanks for putting together such a package! Before getting into the paper and codebase, I want to clarify what seems like a small issue in the list of authors. In the article proof, one author is tagged with *, indicating co-authorship. I guess at least one more author should also be labeled with * ? |
Hey taoliu032, You're absolutely right. I thought my corresponding authorship would imply an equal contribution. I updated the paper. Thank you for the hint and sorry for the oversight. |
👋 @lorenzo-rovigatti , @taoliu032 - how is the review process going? It has been 3 weeks since the process started, so I just wanted to check on you. Let me know if you are able to complete the review process and how long time do you need. |
Hi @jromanowska thanks for checking in! I crossed out some items on the to-do list and will continue to do more this weekend :) I plan to fully go through the list by next weekend (or sooner). |
Hey @jromanowska ! I have started my review process (as you can see from the issue above, which was promptly solved). I hope I'll be done by the weekend. |
First of all, thanks to @moritzobenauer (and the other authors) for this nice piece of software. I have added three issues to the repo, with one of them which has been already closed. While the authors work on the the other issues, I have a couple of comments on some specific items that can be more easily discussed here:
|
Hi, We are testing the module against the example sequence. We have noticed that the actions sometimes abort due to a runtime error, i.e. that the tests exceed the 6h limit. This is the case with almost every fourth test. You can run the tests via python -m unittest I attribute this to the fact that the generation of the sequence by the self-avoiding-random walk is in a continuous loop because no displacement vector is found that fulfills the minimum distance condition. The polymer is generated in |
I had some comments on the documentation and testing as well, and have added to the already opened issue above. Hope they are helpful! |
Following [this discussion](moritzobenauer#11), linked to the [JOSS review](openjournals/joss-reviews#6293), this is a commit showing an example of how to strengthen the parsing of the sequence file by raising exceptions containing why and where the parsing fails.
I'm not familiar with the inner workings of the code, but I have written codes to generate my fair share of polymer configurations before, and what is perhaps happening here is that sometimes the code gets "trapped" in a configuration where the |
That works outrageously well. Thank you @lorenzo-rovigatti |
@moritzobenauer - I've noticed that one of the references lacks a DOI (https://onlinelibrary.wiley.com/doi/10.1002/0471721204.ch8) - could you fix that and re-create the PDF? |
@editorialbot check references |
|
@editorialbot check references |
|
I added the DOI @jromanowska and checked the references. |
@editorialbot generate pdf |
@editorialbot set 10.5281/zenodo.10776652 as archive |
Done! archive is now 10.5281/zenodo.10776652 |
@editorialbot set v1.0.2 as version |
Done! version is now v1.0.2 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5103, then you can now move forward with accepting the submission by compiling again with the command |
@lorenzo-rovigatti @taoliu032 @moritzobenauer @kainszs - thank you all once more. I've read the paper once more and checked the meta data on zenodo. One of the Chief Editors will now go through all and if all's fine, we will accept the paper. The proofs has just been generated, so you may always double-check it and write in the comment here if you noticed any mistakes. |
@moritzobenauer I have checked your paper, this archive, your repository, and the archive link. Most seems in order. I only have the below points that require your attention:
|
Hello @Kevin-Mattheus-Moerman , I worked on your suggestions:
Order is now MLO, KNS, PB, and FS matching the paper.
Version tag is set to v1.0.2.
Added contributing.md and codeofconduct.md to the project and created a link in the README.md under 'Supported Building Blocks' where we explain contributions to the project. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Everything looks great to me. Thank you @lorenzo-rovigatti , @taoliu032 , and @jromanowska for the smooth reviewing process. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @moritzobenauer (Moritz Obenauer)
Repository: https://github.com/moritzobenauer/ProjectRaccoon
Branch with paper.md (empty if default branch):
Version: v1.0.2
Editor: @jromanowska
Reviewers: @taoliu032, @lorenzo-rovigatti
Archive: 10.5281/zenodo.10776652
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@taoliu032 & @lorenzo-rovigatti, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jromanowska know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @taoliu032
📝 Checklist for @lorenzo-rovigatti
The text was updated successfully, but these errors were encountered: