Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: TelescopeML -- I. An End-to-End Python Package for Interpreting Telescope Datasets through Training Machine Learning Models, Generating Statistical Reports, and Visualizing Results #6346

Closed
editorialbot opened this issue Feb 12, 2024 · 83 comments
Assignees
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 12, 2024

Submitting author: @EhsanGharibNezhad (Ehsan Gharib-Nezhad)
Repository: https://github.com/EhsanGharibNezhad/TelescopeML
Branch with paper.md (empty if default branch): joss
Version: 0.0.5
Editor: @plaplant
Reviewers: @oparisot, @mwalmsley
Archive: 10.5281/zenodo.11553655

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/341c09d394beb3918d85a6b176eb9b83"><img src="https://joss.theoj.org/papers/341c09d394beb3918d85a6b176eb9b83/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/341c09d394beb3918d85a6b176eb9b83/status.svg)](https://joss.theoj.org/papers/341c09d394beb3918d85a6b176eb9b83)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@oparisot, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @plaplant know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @oparisot

📝 Checklist for @mwalmsley

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.13 s (258.7 files/s, 137169.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          11            952           1486           2122
Jupyter Notebook                 4              0          10305            755
YAML                             6             10              9            753
TeX                              1             35              0            384
Markdown                         2             60              0            228
reStructuredText                 7            135             79            127
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            33           1204          11887           4404
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1153

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-3881/aae77c is OK
- 10.3847/2041-8213/acb04a is OK
- 10.1038/s41586-022-05591-3 is OK
- 10.1088/1538-3873/acd1b5 is OK
- 10.48550/arXiv.1705.05165 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.03021 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.3509134 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1146/annurev-astro-082214-122522 is OK
- 10.3847/1538-4357/acabc2 is OK
- 10.21105/joss.04873 is OK
- 10.3847/1538-4357/ace530 is OK

MISSING DOIs

- 10.1088/0004-637x/783/2/70 may be a valid DOI for title: A systematic retrieval analysis of secondary eclipse spectra. II. A uniform analysis of nine planets and their C to O ratios
- 10.3847/1538-4357/ab1b51 may be a valid DOI for title: Exoplanet reflected-light spectroscopy with PICASO
- 10.3847/1538-4357/ac4399 may be a valid DOI for title: ExoMiner: A Highly Accurate and Explainable Deep Learning Classifier that Validates 301 New Exoplanets

INVALID DOIs

- https://doi.org/10.1016/j.ymssp.2020.107398 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@plaplant
Copy link

@oparisot thanks for agreeing to review! To generate your reviewer checklist, in this thread please comment:

@editorialbot generate my checklist

Then when you get a chance, please begin making your way through the checklist. Let me know if you have any questions!

@oparisot
Copy link

oparisot commented Feb 12, 2024

Review checklist for @oparisot

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/EhsanGharibNezhad/TelescopeML?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@EhsanGharibNezhad) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@EhsanGharibNezhad
Copy link

@plaplant, thanks again for assigning a reviewer, and @oparisot, thank you for dedicating your time to review this package!

@oparisot I'll make sure to check and address all your comments, but please don't hesitate to reach out if you have any questions or share any instructions, as this is my first JOSS submission and experience with this process.

@oparisot
Copy link

oparisot commented Feb 15, 2024

Hello @EhsanGharibNezhad,

I will go deeply into the review, but before, you should add a short summary in the paper, as required in JOSS guidelines: "A summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience."

Moreover, you should clarifiy the 'Functionality and Key Features'. The current paper proposes a high-level list of features, but it is too vague. You should describe the inputs and outputs (files formats? time series?), you should present the goal of AI models (what do you mean by 'predicting atmospheric parameters'?),you should describe the type of CNN, etc.

Finally, you should position and compare your software to existing tools (ex https://github.com/MartianColonist/POSEIDON, if it not appropriate then please list tools that are 'comparable' to your software.

I will test the software in few days.

Thank you,

Olivier

@EhsanGharibNezhad
Copy link

Hi @oparisot, Thanks for the feedback. I'll make sure to address your comments within the next few days and find the softwares that I could compare my package with.

@plaplant
Copy link

@editorialbot add @mwalmsley as reviewer

@editorialbot
Copy link
Collaborator Author

@mwalmsley added to the reviewers list!

@EhsanGharibNezhad
Copy link

EhsanGharibNezhad commented Mar 1, 2024

Hi Oliver @oparisot:

To address your comments, I added the following sections:

  • Summary
  • Details on the synthetic dataset
  • Details on the CNN methodology for Multi-output Regression problem : to briefly talk about the CNN method
  • Similar Tools

I also modified the Functionality and Key Features section to clearly list the tasks. Besides, I updated the DOIs suggested earlier. Please let me know if it still looks vague. Thank you!

@EhsanGharibNezhad
Copy link

Hi Paul @plaplant, Just making sure I'm not missing anything, all the comments will be listed here in the GitHub thread, right?

@plaplant
Copy link

@EhsanGharibNezhad for comments on the submission, we leave that up to the reviewers' preference. Some will make comments in this review thread, and others will make issues on the software repository and reference them as part of this thread, especially if the comments are more involved or there are several issues that need to be addressed. Either way, at least a reference should appear in this thread.

@oparisot thanks very much for your initial review! When you get a chance, please provide any additional feedback you have, either as a comment on this thread or by making an issue on the software repository. Thanks!

@mwalmsley when you get a chance, please make the following comment in this thread:

@editorialbot generate my checklist

Then please start going through the review elements contained in the checklist. Let me know if you have any questions!

@oparisot
Copy link

oparisot commented Apr 5, 2024

Hi @EhsanGharibNezhad,

Thank you for the update of the paper.
Now, I'm testing the software -- I will give you my feedback.

Ideas to improve the repository: can you add a short 'contribution guide' (ex: https://contributing.md/example/)?

Olivier

@oparisot
Copy link

oparisot commented Apr 5, 2024

The software is easy to use by following the instructions, and the use-cases are well explained. I'm in favour of accepting the paper, if guidelines (even slight ones) for contribution / support are added in the git repository.

Olivier

@EhsanGharibNezhad
Copy link

Hi @EhsanGharibNezhad,

Thank you for the update of the paper. Now, I'm testing the software -- I will give you my feedback.

Ideas to improve the repository: can you add a short 'contribution guide' (ex: https://contributing.md/example/)?

Olivier

Hi Oliver @oparisot, This is a great comment. Thanks for sharing this link. I added two docs to the main branch to address that:

  1. CODE_OF_CONDUCT.md: https://github.com/EhsanGharibNezhad/TelescopeML/blob/main/CODE_OF_CONDUCT.md
  2. CONTRIBUTING.md: https://github.com/EhsanGharibNezhad/TelescopeML/blob/main/CONTRIBUTING.md

@oparisot
Copy link

oparisot commented Apr 7, 2024

@EhsanGharibNezhad I've tested the software and it works well - the use cases are well described in the documentation and run efficiently. Great job!
@plaplant It's ok for me -- I am in favour of acceptance.

@plaplant
Copy link

plaplant commented Apr 8, 2024

@oparisot thanks for your review! If you have completed all components of the reviewer checklist, please tick the boxes so we can consider the review "complete".

@mwalmsley when you get a chance, please comment @editorialbot generate my checklist and begin working your way through the elements on the list. Thanks!

@EhsanGharibNezhad
Copy link

EhsanGharibNezhad commented Apr 8, 2024

@EhsanGharibNezhad I've tested the software and it works well - the use cases are well described in the documentation and run efficiently. Great job! @plaplant It's ok for me -- I am in favour of acceptance.

Great! Thank you Oliver for taking the time and testing the package.

@dfm dfm removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Apr 14, 2024
@mwalmsley
Copy link

mwalmsley commented Apr 19, 2024

Review checklist for @mwalmsley

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/EhsanGharibNezhad/TelescopeML?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@EhsanGharibNezhad) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@plaplant
Copy link

plaplant commented Jul 8, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ymssp.2020.107398 is OK
- 10.3847/1538-3881/aae77c is OK
- 10.3847/2041-8213/acb04a is OK
- 10.1038/s41586-022-05591-3 is OK
- 10.1088/1538-3873/acd1b5 is OK
- 10.48550/arXiv.1705.05165 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.03021 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.3509134 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1016/j.jqsrt.2007.11.006 is OK
- 10.1093/mnras/stab1405 is OK
- 10.1088/0004-637X/802/2/107 is OK
- 10.1088/1538-3873/aaf5ad is OK
- 10.1051/0004-6361/201935470 is OK
- 10.1088/0004-637X/775/2/137 is OK
- 10.21105/joss.04873 is OK
- 10.1038/s41550-018-0504-2 is OK
- 10.1088/0004-637X/812/2/128 is OK
- 10.3847/1538-4357/ac141d is OK
- 10.1146/annurev-astro-082214-122522 is OK
- 10.1088/0004-637x/783/2/70 is OK
- 10.3847/1538-4357/acabc2 is OK
- 10.3847/1538-4357/ab1b51 is OK
- 10.3847/1538-4357/ac4399 is OK
- 10.3847/1538-4357/ace530 is OK

MISSING DOIs

- No DOI given, and none found for title: Deep Learning
- No DOI given, and none found for title: Bokeh: Python library for interactive visualizatio...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python

INVALID DOIs

- None

@plaplant
Copy link

plaplant commented Jul 8, 2024

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ymssp.2020.107398 is OK
- 10.3847/1538-3881/aae77c is OK
- 10.3847/2041-8213/acb04a is OK
- 10.1038/s41586-022-05591-3 is OK
- 10.1088/1538-3873/acd1b5 is OK
- 10.48550/arXiv.1705.05165 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.03021 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.3509134 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1016/j.jqsrt.2007.11.006 is OK
- 10.1093/mnras/stab1405 is OK
- 10.1088/0004-637X/802/2/107 is OK
- 10.1088/1538-3873/aaf5ad is OK
- 10.1051/0004-6361/201935470 is OK
- 10.1088/0004-637X/775/2/137 is OK
- 10.21105/joss.04873 is OK
- 10.1038/s41550-018-0504-2 is OK
- 10.1088/0004-637X/812/2/128 is OK
- 10.3847/1538-4357/ac141d is OK
- 10.1146/annurev-astro-082214-122522 is OK
- 10.1088/0004-637x/783/2/70 is OK
- 10.3847/1538-4357/acabc2 is OK
- 10.3847/1538-4357/ab1b51 is OK
- 10.3847/1538-4357/ac4399 is OK
- 10.3847/1538-4357/ace530 is OK

MISSING DOIs

- No DOI given, and none found for title: Deep Learning
- No DOI given, and none found for title: Bokeh: Python library for interactive visualizatio...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5587, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Jul 8, 2024
@EhsanGharibNezhad
Copy link

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

I'm sorry @EhsanGharibNezhad, I'm afraid I can't do that. That's something only eics are allowed to do.

@EhsanGharibNezhad
Copy link

👋 @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5587, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@plaplant I'm not sure if I need to compile that command?

@plaplant
Copy link

@EhsanGharibNezhad apologies for the confusion. I don't personally have the authority to officially accept a publication, as that can only be done by one of the Editors-in-Chief (eics). I have recommended its acceptance, so now it goes to them to officially accept. This process usually happens within a few days, but I will follow up early next week if it hasn't happened by then.

@EhsanGharibNezhad
Copy link

No problem! Thank you! :)

@dfm
Copy link

dfm commented Jul 13, 2024

@EhsanGharibNezhad — I've opened a small PR with some typographic edits. Once you merge that I can proceed with acceptance.

@EhsanGharibNezhad
Copy link

@dfm Done! Thanks!

@dfm
Copy link

dfm commented Jul 18, 2024

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ymssp.2020.107398 is OK
- 10.3847/1538-3881/aae77c is OK
- 10.3847/2041-8213/acb04a is OK
- 10.1038/s41586-022-05591-3 is OK
- 10.1088/1538-3873/acd1b5 is OK
- 10.48550/arXiv.1705.05165 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.03021 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.3509134 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1016/j.jqsrt.2007.11.006 is OK
- 10.1093/mnras/stab1405 is OK
- 10.1088/0004-637X/802/2/107 is OK
- 10.1088/1538-3873/aaf5ad is OK
- 10.1051/0004-6361/201935470 is OK
- 10.1088/0004-637X/775/2/137 is OK
- 10.21105/joss.04873 is OK
- 10.1038/s41550-018-0504-2 is OK
- 10.1088/0004-637X/812/2/128 is OK
- 10.3847/1538-4357/ac141d is OK
- 10.1146/annurev-astro-082214-122522 is OK
- 10.1088/0004-637x/783/2/70 is OK
- 10.3847/1538-4357/acabc2 is OK
- 10.3847/1538-4357/ab1b51 is OK
- 10.3847/1538-4357/ac4399 is OK
- 10.3847/1538-4357/ace530 is OK

MISSING DOIs

- No DOI given, and none found for title: Deep Learning
- No DOI given, and none found for title: Bokeh: Python library for interactive visualizatio...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5649, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@dfm
Copy link

dfm commented Jul 18, 2024

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Gharib-Nezhad
  given-names: Ehsan (Sam)
  orcid: "https://orcid.org/0000-0002-4088-7262"
- family-names: Batalha
  given-names: Natasha E.
  orcid: "https://orcid.org/0000-0003-1240-6844"
- family-names: Valizadegan
  given-names: Hamed
  orcid: "https://orcid.org/0000-0001-6732-0840"
- family-names: Martinho
  given-names: Miguel J. S.
  orcid: "https://orcid.org/0000-0002-2188-0807"
- family-names: Habibi
  given-names: Mahdi
  orcid: "https://orcid.org/0000-0001-8530-7746"
- family-names: Nookula
  given-names: Gopal
doi: 10.5281/zenodo.11553655
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Gharib-Nezhad
    given-names: Ehsan (Sam)
    orcid: "https://orcid.org/0000-0002-4088-7262"
  - family-names: Batalha
    given-names: Natasha E.
    orcid: "https://orcid.org/0000-0003-1240-6844"
  - family-names: Valizadegan
    given-names: Hamed
    orcid: "https://orcid.org/0000-0001-6732-0840"
  - family-names: Martinho
    given-names: Miguel J. S.
    orcid: "https://orcid.org/0000-0002-2188-0807"
  - family-names: Habibi
    given-names: Mahdi
    orcid: "https://orcid.org/0000-0001-8530-7746"
  - family-names: Nookula
    given-names: Gopal
  date-published: 2024-07-18
  doi: 10.21105/joss.06346
  issn: 2475-9066
  issue: 99
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 6346
  title: TelescopeML -- I. An End-to-End Python Package for Interpreting
    Telescope Datasets through Training Machine Learning Models,
    Generating Statistical Reports, and Visualizing Results
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.06346"
  volume: 9
title: TelescopeML -- I. An End-to-End Python Package for Interpreting
  Telescope Datasets through Training Machine Learning Models,
  Generating Statistical Reports, and Visualizing Results

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.06346 joss-papers#5650
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06346
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Jul 18, 2024
@dfm
Copy link

dfm commented Jul 18, 2024

Many thanks to @oparisot and @mwalmsley for reviewing and to @plaplant for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@EhsanGharibNezhad — Your paper is now accepted and published in JOSS! ⚡🚀💥

Note: I'm currently seeing that the PDF isn't appearing on the DOI page. This sometimes happens for a few hours because of some caching issues on the back end. If this doesn't resolve itself by tomorrow, let me know and I'll look into it!

@dfm dfm closed this as completed Jul 18, 2024
@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06346/status.svg)](https://doi.org/10.21105/joss.06346)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06346">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06346/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06346/status.svg
   :target: https://doi.org/10.21105/joss.06346

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@EhsanGharibNezhad
Copy link

Many thanks to @oparisot and @mwalmsley for reviewing and to @plaplant for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@EhsanGharibNezhad — Your paper is now accepted and published in JOSS! ⚡🚀💥

Note: I'm currently seeing that the PDF isn't appearing on the DOI page. This sometimes happens for a few hours because of some caching issues on the back end. If this doesn't resolve itself by tomorrow, let me know and I'll look into it!

Thank you all! It was a wonderful experience going through all steps! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

6 participants