-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: QSOnic: fast quasar continuum fitting #6373
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@gcalderone, @corentinravoux thank you for agreeing to review this submission! Please review the guidelines above: #6373 (comment) Comments and recommendations for changes should ideally be in issues opened on the code repo but comments in this thread are also welcome. When you are finished, please let us know in the comments here. We are looking for reviews in 3-4 weeks, so let's aim for March 18th at the latest for the first round of comments. Let me know if you have questions! |
@ivastar Thank you, I will try to do my best to provide those comments quickly |
Review checklist for @corentinravouxConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I have a COI with this review, I work in the same collaboration than the main author (DESI), and we are co-author of some papers (Karaçaylı et al. 2024, Ravoux et al. 2023). I am contributing and using the picca code mentioned in the paper. |
Comments on the joss-paper (I used the download version):
|
@corentinravoux The COI can be waived for this specific case. Thank you declaring your relation to the author and this work. |
The review process is quite faster than I expected. I summarized my comments in the following issue: p-slash/qsonic#92. |
Review checklist for @gcalderoneConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I provided my comments in p-slash/qsonic#93 |
@p-slash I believe we have both sets of comments now. The ball is in your court. Please review the comments and respond to them here or in the review issues that have been opened. I would appreciate it if you could do this in the next 3-4 weeks. |
My other responses can be found at p-slash/qsonic#93 (comment) and p-slash/qsonic#92 (comment). The updated documentation can be accessed here: https://qsonic.readthedocs.io/en/paper/index.html. Thanks @corentinravoux for the feedback. This is the second part of my response.
Added.
Paper now says:
We are still fitting for ln lambda for DESI. There was a version of picca that performed the continuum fitting on lambda, but that was eventually removed before EDR analyses took off.
Paper now says:
Paper now says: |
Thank you for the fast turn-around on the comments, @p-slash!!! @gcalderone and @corentinravoux, could you please review the responses and let me know if you believe all points have been addressed? If no, please add additional comments. If yes, please recommend publications. |
@editorialbot generate pdf |
Thanks @p-slash for the updates! |
Thanks @p-slash, you answered all my comments. I have checked all the items of my checklist, and I recommend this package for publication. I have a minor comment which is very technical and does not interfere at all with the review:
On this aspect, I was sure that it was in lambda in picca, but after double checking it is indeed in log_lambda. I do not understand why this is the case for DESI data which are linearly binned, did you test on QSOnic the difference in term of continuum fitting with different term in the polynomial term (lambda vs log lambda) ? |
Thanks. I addressed @gcalderone's comments under the issue. @corentinravoux, re: ln lambda: Yes, DESI is linearly spaced, but this term is related to the quasar continuum model, so it does not need to be tied to the observational grid. If I remember correctly, ln lambda is the better of the two for the quasar continuum model theoretically, but I do not have a document to point you to. I had the comparison with picca, and the difference was small, but I did not code within qsonic. Furthermore, changing this model then propagates to the distortion matrix calculation. It complicates the entire analysis, so it may be that we simplified it to a single choice in the end. |
Thanks @p-slash ! |
@editorialbot check references |
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5301, then you can now move forward with accepting the submission by compiling again with the command |
I've opened a small PR and I can proceed with publication after that has been merged. Thanks! |
Merged. Thanks for fixing the references! |
@editorialbot generate pdf |
@dfm I found another error in the references. It is the first reference. |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5324, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Many thanks to @gcalderone and @corentinravoux for reviewing and to @ivastar for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!! @p-slash — Your paper is now accepted and published in JOSS! ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @p-slash (Naim Göksel Karaçaylı)
Repository: https://github.com/p-slash/qsonic
Branch with paper.md (empty if default branch): main
Version: v1.0.0
Editor: @ivastar
Reviewers: @gcalderone, @corentinravoux
Archive: 10.5281/zenodo.11105006
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gcalderone & @corentinravoux, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ivastar know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @corentinravoux
📝 Checklist for @gcalderone
The text was updated successfully, but these errors were encountered: