Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: EchemFEM: A Firedrake-based Python package for electrochemical transport #6444

Closed
editorialbot opened this issue Mar 5, 2024 · 31 comments
Closed

[PRE REVIEW]: EchemFEM: A Firedrake-based Python package for electrochemical transport #6444

editorialbot opened this issue Mar 5, 2024 · 31 comments
Assignees
@TomTranter @RMeli @sudarshanv01 @alizma
Labels
Makefile pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 5, 2024 •
edited

Submitting author: @tlroy (Thomas Roy)
Repository: https://github.com/LLNL/echemfem
Branch with paper.md (empty if default branch): joss
Version: v0.0.1
Editor: @RMeli
Reviewers: @sudarshanv01, @alizma, @TomTranter
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/24fc67bb5ebbf43af1db08488741cb06"><img src="https://joss.theoj.org/papers/24fc67bb5ebbf43af1db08488741cb06/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/24fc67bb5ebbf43af1db08488741cb06/status.svg)](https://joss.theoj.org/papers/24fc67bb5ebbf43af1db08488741cb06)

Author instructions

Thanks for submitting your paper to JOSS @tlroy. Currently, there isn't a JOSS editor assigned to your paper.

@tlroy if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Mar 5, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (1034.5 files/s, 153081.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          43           1245            645           6828
GLSL                             7             74             35            445
reStructuredText                 9            173             86            297
Markdown                         5             54              0            205
TeX                              1             15              0            160
Perl                             2             24             18            100
YAML                             1              0              0             43
DOS Batch                        1              8              1             26
make                             2              5              7             12
-------------------------------------------------------------------------------
SUM:                            71           1598            792           8116
-------------------------------------------------------------------------------

Commit count by author:

    97	Thomas Roy
     6	Jack Guo
     4	ehlinger
     2	Nitish Govindarajan
     2	Tiras Lin
     2	Victoria Ehlinger

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1495

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.jcp.2022.111859 is OK
- 10.1103/PRXEnergy.2.033010 is OK
- 10.25561/104839 is OK
- 10.2172/1968587 is OK
- 10.1007/s10562-015-1495-6 is OK
- 10.1021/jp402181e is OK
- 10.1149/2754-2734/acff0b is OK
- 10.1137/17M1133208 is OK
- 10.21105/joss.01292 is OK
- 10.1007/s00158-022-03249-2 is OK
- 10.1016/j.carbon.2023.01.044 is OK

MISSING DOIs

- 10.1149/osf.io/67ckj may be a valid DOI for title: Python battery mathematical modelling (PyBaMM)

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@tlroy
Copy link

tlroy commented Mar 6, 2024

Here are some suggested reviewers: sudarshanv01, tomtranter, mefuller, ericaegg.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @RMeli as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@RMeli
Copy link

RMeli commented Mar 13, 2024

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @RMeli is now the editor

@RMeli
Copy link

RMeli commented Mar 13, 2024

Hi @sudarshanv01 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #6444.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@RMeli
Copy link

RMeli commented Mar 13, 2024

Hi @TomTranter 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #6444.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@RMeli
Copy link

RMeli commented Mar 13, 2024

Hi @mefuller 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #6444.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@sudarshanv01
Copy link

Thanks, I would be happy to review!

@RMeli
Copy link

RMeli commented Mar 14, 2024 •
edited

@editorialbot add @sudarshanv01 as reviewer

Great, thanks!

@editorialbot
Copy link
Collaborator Author

@sudarshanv01 added to the reviewers list!

@RMeli
Copy link

RMeli commented Mar 15, 2024

Hi @EricaEgg 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #6444.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@RMeli
Copy link

RMeli commented Mar 20, 2024

Hi @alizma 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #6444.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@RMeli
Copy link

RMeli commented Mar 20, 2024

Hi @mscroggs 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #6444.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@RMeli
Copy link

RMeli commented Mar 20, 2024

Hi @schruste 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #6444.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@alizma
Copy link

alizma commented Mar 20, 2024

Happy to review! Thank you.

@RMeli
Copy link

RMeli commented Mar 20, 2024

@editorialbot add @alizma as reviewer

Fantastic, thank you!

@editorialbot
Copy link
Collaborator Author

@alizma added to the reviewers list!

@TomTranter
Copy link

@RMeli - happy to review

@RMeli
Copy link

RMeli commented Mar 22, 2024

@editorialbot add @TomTranter as reviewer

Great, thank you!

@editorialbot
Copy link
Collaborator Author

@TomTranter added to the reviewers list!

@RMeli
Copy link

RMeli commented Mar 22, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6531.

@schruste
Copy link

OK, I think you've found enough reviewer. Thanks for inviting me, but I am more than happy to skip this one.

@RMeli
Copy link

RMeli commented Mar 26, 2024

@schruste, indeed. But thank you anyways for the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomTranter TomTranter

@RMeli RMeli

@sudarshanv01 sudarshanv01

@alizma alizma

Labels
Makefile pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@TomTranter @Kevin-Mattheus-Moerman @schruste @RMeli @tlroy @sudarshanv01 @alizma @editorialbot