Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GATree: Evolutionary decision tree classifier in Python #6456

Closed
editorialbot opened this issue Mar 9, 2024 · 33 comments
Closed
Assignees
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 9, 2024

Submitting author: @lahovniktadej (Tadej Lahovnik)
Repository: https://github.com/lahovniktadej/gatree
Branch with paper.md (empty if default branch):
Version: 0.1.4
Editor: @kellyrowland
Reviewers: @FlyingPumba, @WeakCha
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b3deeed0f75fedff6e284569bdd97ef8"><img src="https://joss.theoj.org/papers/b3deeed0f75fedff6e284569bdd97ef8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b3deeed0f75fedff6e284569bdd97ef8/status.svg)](https://joss.theoj.org/papers/b3deeed0f75fedff6e284569bdd97ef8)

Author instructions

Thanks for submitting your paper to JOSS @lahovniktadej. Currently, there isn't a JOSS editor assigned to your paper.

@lahovniktadej if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Mar 9, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: A survey of evolutionary algorithms for decision-t...
- 10.1007/978-3-540-46239-2_18 may be a valid DOI for title: Application of genetic programming to induction of...
- 10.1007/bfb0029742 may be a valid DOI for title: Concept formation and decision tree induction usin...
- 10.1145/3205651.3205774 may be a valid DOI for title: Building boosted classification tree ensemble with...
- 10.1007/978-3-030-72699-7_48 may be a valid DOI for title: TensorGP – Genetic Programming Engine in TensorFlo...
- No DOI given, and none found for title: Tiny Genetic Programming in Python
- No DOI given, and none found for title: gplearn

INVALID DOIs

- https://doi.org/10.1016/j.swevo.2021.101006 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (1765.1 files/s, 124613.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          15            280            632            648
XML                              1              0              0            467
Markdown                         7             99              0            226
reStructuredText                12             75             73            107
YAML                             3              9             21             86
TeX                              1              7              0             69
TOML                             1              4              0             21
-------------------------------------------------------------------------------
SUM:                            40            474            726           1624
-------------------------------------------------------------------------------

Commit count by author:

   104	Tadej Lahovnik
     1	karakatic

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1382

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Mar 10, 2024

@editorialbot query scope

@lahovniktadej – due to the relatively small size of this code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. We should get back to you sometime next week. If you want to fix the DOIs (noting that @editorialbot's suggestions are not always right), you can, then use the following commands (one at a time, as the first line of a new comment) to regenerate the PDF and check the references.

@editorialbot generate pdf
@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Mar 10, 2024
@lahovniktadej
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@lahovniktadej
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TSMCC.2011.2157494 is OK
- 10.1016/j.swevo.2021.101006 is OK
- 10.1007/978-3-540-46239-2_18 is OK
- 10.1007/BFb0029742 is OK
- 10.1145/3205651.3205774 is OK
- 10.1007/978-3-030-72699-7_48 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@arfon arfon removed the query-scope Submissions of uncertain scope for JOSS label Apr 3, 2024
@arfon
Copy link
Member

arfon commented Apr 3, 2024

@lahovniktadej – this submission has passed the scope review stage, even though there are some concerns about the size/level of effort associated with this package.

At this point I'm putting it into the backlog of submissions that are awaiting an editor to be assigned. This will likely take a few weeks as we have a number of submissions in the queue ahead of this one. Thanks in advance for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Apr 3, 2024
@arfon
Copy link
Member

arfon commented Apr 5, 2024

@editorialbot invite @kellyrowland as editor

👋 @kellyrowland – would you be willing to edit this submission for JOSS?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@kellyrowland
Copy link

hi @arfon I can take this on 👍

@kellyrowland
Copy link

@editorialbot assign @kellyrowland as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @kellyrowland is now the editor

@kellyrowland
Copy link

hi @TimKam @FlyingPumba 👋 would you be interested in and available for reviewing this JOSS submission?

@FlyingPumba
Copy link

Hi @kellyrowland thanks for considering me for review of this submission! I'm interested. What is the timeline for the review?

@kellyrowland
Copy link

@FlyingPumba thanks for your interest - ideally we wrap the reviews up in 6 weeks or so, but the process is flexible around the reviewers' and authors' schedules.

@FlyingPumba
Copy link

@kellyrowland great! In that case I'll gladly accept to review the submission.

@kellyrowland
Copy link

thanks! I'll add you as a reviewer here and will start the review process once we have a second reviewer lined up as well.

@kellyrowland
Copy link

@editorialbot add @FlyingPumba to reviewers

@editorialbot
Copy link
Collaborator Author

@FlyingPumba added to the reviewers list!

@kellyrowland
Copy link

hi @lwu9 @TahiriNadia 👋 would either of you be interested in and available for reviewing this JOSS submission?

@lwu9
Copy link

lwu9 commented May 2, 2024 via email

@kellyrowland
Copy link

hello @mkerin @WeakCha 👋 would either of you be interested in and available for reviewing this JOSS submission?

@WeakCha
Copy link

WeakCha commented May 13, 2024 via email

@kellyrowland
Copy link

@editorialbot add @WeakCha to reviewers

@editorialbot
Copy link
Collaborator Author

@WeakCha added to the reviewers list!

@kellyrowland
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6748.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

7 participants