Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: VineCopulas: an open-source Python package for vine copula modelling #6559

Closed
editorialbot opened this issue Mar 30, 2024 · 35 comments
Assignees
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 30, 2024

Submitting author: @judithclaassen (Judith Claassen)
Repository: https://github.com/VU-IVM/VineCopulas
Branch with paper.md (empty if default branch):
Version: v0.2.5
Editor: @ymzayek
Reviewers: @haozcbnu, @couasnonanais
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/5118d62bcc8a3621ebdd2955f8e88405"><img src="https://joss.theoj.org/papers/5118d62bcc8a3621ebdd2955f8e88405/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/5118d62bcc8a3621ebdd2955f8e88405/status.svg)](https://joss.theoj.org/papers/5118d62bcc8a3621ebdd2955f8e88405)

Author instructions

Thanks for submitting your paper to JOSS @judithclaassen. Currently, there isn't a JOSS editor assigned to your paper.

@judithclaassen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Mar 30, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (343.4 files/s, 147090.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           7            718            556           5284
CSV                              2              0              0           1408
Jupyter Notebook                 2              0           1742            264
Markdown                         5            103              0            261
TeX                              1             17              0            126
YAML                             6             18             20            119
TOML                             1              5              0             37
reStructuredText                 1             11              7             11
-------------------------------------------------------------------------------
SUM:                            25            872           2325           7510
-------------------------------------------------------------------------------

Commit count by author:

   109	Claassen
    47	Judith Claassen
     9	Jäger
     6	Elco Koks
     1	Koks

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1016

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3389/fnins.2022.910122 is OK
- 10.1146/annurev-statistics-040220-101153 is OK
- 10.5281/ZENODO.10435751 is OK
- 10.1214/aos/1031689016 is OK
- 10.5194/nhess-23-2251-2023 is OK
- 10.5194/hess-21-2701-2017 is OK

MISSING DOIs

- No DOI given, and none found for title: copula: Multivariate Dependence with Copulas
- No DOI given, and none found for title: VineCopula: Statistical Inference of Vine Copulas
- No DOI given, and none found for title: CDVineCopulaConditional: Sampling from Conditional...
- No DOI given, and none found for title: copulas: Create tabular synthetic data using copul...
- No DOI given, and none found for title: Monte Carlo simulation of vine dependent random va...
- 10.1201/9780367803896 may be a valid DOI for title: Multivariate models and multivariate dependence co...

INVALID DOIs

- https://doi.org/10.1201/b17116 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Mar 30, 2024

@judithclaassen - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Mar 30, 2024
@crvernon
Copy link

👋 @ymzayek - would you be willing to edit this submission?

@crvernon
Copy link

@editorialbot invite @ymzayek as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@ymzayek
Copy link

ymzayek commented Apr 22, 2024

@crvernon yes I can edit this submission

@crvernon
Copy link

@editorialbot assign @ymzayek as editor

Thanks @ymzayek!

@editorialbot
Copy link
Collaborator Author

Assigned! @ymzayek is now the editor

@crvernon crvernon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Apr 22, 2024
@ymzayek
Copy link

ymzayek commented Apr 25, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@ymzayek
Copy link

ymzayek commented Apr 25, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3389/fnins.2022.910122 is OK
- 10.1146/annurev-statistics-040220-101153 is OK
- 10.5281/ZENODO.10435751 is OK
- 10.1214/aos/1031689016 is OK
- 10.5194/nhess-23-2251-2023 is OK
- 10.5194/hess-21-2701-2017 is OK

MISSING DOIs

- No DOI given, and none found for title: copula: Multivariate Dependence with Copulas
- No DOI given, and none found for title: VineCopula: Statistical Inference of Vine Copulas
- No DOI given, and none found for title: CDVineCopulaConditional: Sampling from Conditional...
- No DOI given, and none found for title: copulas: Create tabular synthetic data using copul...
- No DOI given, and none found for title: Monte Carlo simulation of vine dependent random va...
- 10.1201/9780367803896 may be a valid DOI for title: Multivariate models and multivariate dependence co...

INVALID DOIs

- https://doi.org/10.1201/b17116 is INVALID because of 'https://doi.org/' prefix

@ymzayek
Copy link

ymzayek commented Apr 25, 2024

Hi @judithclaassen, thank you for submitting your work to JOSS. I am the handling editor. Do you have any suggestion for reviewers? You can use the potential reviewers list provided at the top of this issue. I think people interested in statistics and dependency modeling as well as Python would be a good fit. If you have suggestions, please provide a list of potential reviewers here but do not use the @ character to avoid receiving unwanted notifications. Thank you in advance.

@ymzayek
Copy link

ymzayek commented Apr 25, 2024

@judithclaassen are you also able to address the missing and invalid DOIs in the reference check summary?

@judithclaassen
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3389/fnins.2022.910122 is OK
- 10.1146/annurev-statistics-040220-101153 is OK
- 10.5281/ZENODO.10435751 is OK
- 10.1214/aos/1031689016 is OK
- 10.1201/9780367803896 is OK
- 10.5194/nhess-23-2251-2023 is OK
- 10.5194/hess-21-2701-2017 is OK

MISSING DOIs

- No DOI given, and none found for title: copula: Multivariate Dependence with Copulas
- No DOI given, and none found for title: VineCopula: Statistical Inference of Vine Copulas
- No DOI given, and none found for title: CDVineCopulaConditional: Sampling from Conditional...
- No DOI given, and none found for title: copulas: Create tabular synthetic data using copul...
- No DOI given, and none found for title: Monte Carlo simulation of vine dependent random va...

INVALID DOIs

- https://doi.org/10.1201/b17116 is INVALID because of 'https://doi.org/' prefix

@judithclaassen
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3389/fnins.2022.910122 is OK
- 10.1201/b17116 is OK
- 10.1146/annurev-statistics-040220-101153 is OK
- 10.5281/ZENODO.10435751 is OK
- 10.1214/aos/1031689016 is OK
- 10.1201/9780367803896 is OK
- 10.5194/nhess-23-2251-2023 is OK
- 10.5194/hess-21-2701-2017 is OK

MISSING DOIs

- No DOI given, and none found for title: copula: Multivariate Dependence with Copulas
- No DOI given, and none found for title: VineCopula: Statistical Inference of Vine Copulas
- No DOI given, and none found for title: CDVineCopulaConditional: Sampling from Conditional...
- No DOI given, and none found for title: copulas: Create tabular synthetic data using copul...
- No DOI given, and none found for title: Monte Carlo simulation of vine dependent random va...

INVALID DOIs

- None

@judithclaassen
Copy link

@ymzayek , Thank you so much for agreeing to be the editor for our paper. We would like to suggest two reviewers that are not on the list of people that have already agreed to review JOSS, however, their expertise are very relevant to this package:

  • Anais Couasnon (couasnonanais)
  • Zengchao Hao (haozcbnu)

As for the missing and invalid DOI's, I addressed one invalid DOI and added one missing DOI. the other 'missing' DOI's are sources that do not have a DOI, such as other packages.

Thank you very much in advance

@ymzayek
Copy link

ymzayek commented May 6, 2024

Hello @couasnonanais and @haozcbnu,

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

VineCopulas: an open-source Python package for vine copula modelling

You can find more information at the top of this Github issue (#6559).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

@haozcbnu
Copy link

haozcbnu commented May 6, 2024

I'm happy to review this.

@ymzayek
Copy link

ymzayek commented May 6, 2024

@editorialbot add @haozcbnu as reviewer

@editorialbot
Copy link
Collaborator Author

@haozcbnu added to the reviewers list!

@ymzayek
Copy link

ymzayek commented May 6, 2024

@haozcbnu thanks! Once I find at least one other reviewer, the review process will start in a separate thread and I'll help you get started

@couasnonanais
Copy link

couasnonanais commented May 7, 2024 via email

@ymzayek
Copy link

ymzayek commented May 7, 2024

@editorialbot add @couasnonanais as reviewer

@editorialbot
Copy link
Collaborator Author

@couasnonanais added to the reviewers list!

@ymzayek
Copy link

ymzayek commented May 7, 2024

Thanks @haozcbnu and @couasnonanaisfor agreeing to review this paper.

The review will start in a separate thread.

@judithclaassen you can follow the review in the review issue that will be opened.

@ymzayek
Copy link

ymzayek commented May 7, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6728.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

7 participants