Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: RobotDART: a versatile robot simulator for robotics and machine learning researchers #6721

Closed
editorialbot opened this issue May 3, 2024 · 24 comments
Assignees
Labels
C++ C pre-review Python Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 3, 2024

Submitting author: @costashatz (Konstantinos Chatzilygeroudis)
Repository: https://github.com/NOSALRO/robot_dart
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @boisgera
Reviewers: @c-joly, @bstanciulescu
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e13ef9a388c2a9adbfc174fabbeddfce"><img src="https://joss.theoj.org/papers/e13ef9a388c2a9adbfc174fabbeddfce/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e13ef9a388c2a9adbfc174fabbeddfce/status.svg)](https://joss.theoj.org/papers/e13ef9a388c2a9adbfc174fabbeddfce)

Author instructions

Thanks for submitting your paper to JOSS @costashatz. Currently, there isn't a JOSS editor assigned to your paper.

@costashatz if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels May 3, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=1.35 s (851.2 files/s, 430263.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                           296         206671              7         190230
XML                            313           1207           2803          91984
Markdown                       297          27955              1          27897
C++                             80           1938            884           9577
JavaScript                      36           1017           1334           4921
C/C++ Header                    59            958            452           3900
Python                          32            724            661           3104
XSD                              4            131             14           1636
GLSL                            10            128             77            578
YAML                             5             18              9            381
Bourne Shell                     6             51             23            313
TeX                              1             35              0            289
CMake                            8             56            130            205
XSLT                             1              0              5             10
sed                              1              0              2              4
CSS                              2              0              0              2
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                          1152         240889           6402         335032
-------------------------------------------------------------------------------

Commit count by author:

   907	Konstantinos Chatzilygeroudis
   222	Jean-Baptiste Mouret
    61	DionisTotsila
    18	Vaios Papaspyros
    14	Ivan Bergonzani
    14	dinies
     7	Antoine Cully
     6	Dorian Goepp
     6	eloise
     6	kostastsing
     5	DALIN Eloise
     5	aneoshun
     3	Dionis Totsila
     3	Eloise Dalin
     3	eloise dalin
     3	jspitz
     2	Aneoshun
     2	Matthias Mayr
     2	Olivier Rochel
     2	Pierre Desreumaux
     1	Erick Kramer
     1	Vassilis Vassiliades
     1	artificialsimon
     1	itUserName
     1	kounelisagis

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 2323

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 2-Clause "Simplified" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: Black-box data-efficient policy search for robotic...
- 10.1109/iros.2004.1389727 may be a valid DOI for title: Design and use paradigms for gazebo, an open-sourc...
- No DOI given, and none found for title: Gazebo Simulator
- 10.1109/iros.2012.6386109 may be a valid DOI for title: Mujoco: A physics engine for model-based control
- No DOI given, and none found for title: PyBullet, a Python module for physics simulation f...
- No DOI given, and none found for title: Open Dynamics Engine
- 10.21105/joss.00500 may be a valid DOI for title: Dart: Dynamic animation and robotics toolkit
- 10.1126/scirobotics.aau5872 may be a valid DOI for title: Learning agile and dynamic motor skills for legged...
- No DOI given, and none found for title: Learning quadrupedal locomotion over challenging t...
- 10.1109/iros.2017.8202133 may be a valid DOI for title: Domain randomization for transferring deep neural ...
- No DOI given, and none found for title: A review of robot learning for manipulation: Chall...
- 10.1007/s10846-017-0468-y may be a valid DOI for title: Survey of model-based reinforcement learning: Appl...
- No DOI given, and none found for title: Recent advances in robot learning from demonstrati...
- 10.1109/tro.2019.2958211 may be a valid DOI for title: A survey on policy search algorithms for learning ...
- 10.1109/tevc.2017.2735550 may be a valid DOI for title: Using centroidal voronoi tessellations to scale up...
- 10.1016/j.robot.2017.11.010 may be a valid DOI for title: Reset-free trial-and-error learning for robot dama...
- No DOI given, and none found for title: 20 years of reality gap: a few thoughts about simu...
- 10.1109/icra.2018.8463197 may be a valid DOI for title: Bayesian optimization with automatic prior selecti...
- 10.1109/icra.2018.8461083 may be a valid DOI for title: Using parameterized black-box priors to scale up m...
- 10.1609/aaai.v32i1.11687 may be a valid DOI for title: Alternating optimisation and quadrature for robust...
- No DOI given, and none found for title: Multi-objective model-based policy search for data...
- 10.1109/robio55434.2022.10011996 may be a valid DOI for title: Skill-based multi-objective reinforcement learning...
- 10.1109/iros51168.2021.9636292 may be a valid DOI for title: Learning of parameters in behavior trees for movem...
- 10.1109/case49997.2022.9926713 may be a valid DOI for title: Learning skill-based industrial robot tasks with u...
- 10.1145/3512290.3528751 may be a valid DOI for title: Hierarchical quality-diversity for online damage r...
- No DOI given, and none found for title: Safety-aware robot damage recovery using constrain...
- No DOI given, and none found for title: Combining planning, reasoning and reinforcement le...
- 10.1145/3596912 may be a valid DOI for title: Online damage recovery for physical robots with hi...
- No DOI given, and none found for title: Towards semi-episodic learning for robot damage re...
- 10.1109/tsmc.2023.3262954 may be a valid DOI for title: Self-correcting quadratic programming-based robot ...
- 10.3389/frobt.2022.974537 may be a valid DOI for title: Behavior policy learning: Learning multi-stage tas...
- 10.1109/iisa59645.2023.10345937 may be a valid DOI for title: Evolving Dynamic Locomotion Policies in Minutes
- 10.1109/iisa59645.2023.10345879 may be a valid DOI for title: Effective Skill Learning via Autonomous Goal Repre...
- No DOI given, and none found for title: End-to-End Stable Imitation Learning via Autonomou...
- No DOI given, and none found for title: Robust reinforcement learning with Bayesian optimi...
- 10.1109/humanoids.2017.8246947 may be a valid DOI for title: TALOS: A new humanoid research platform targeted f...

INVALID DOIs

- None

@crvernon
Copy link

crvernon commented May 4, 2024

👋 @costashatz - thanks for your submission to JOSS. We are currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

In the meantime, you will need to get your paper length down to <= 1000 words. Thanks!

@crvernon crvernon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 4, 2024
@crvernon
Copy link

crvernon commented May 4, 2024

@editorialbot invite @boisgera as editor

@boisgera - are you able to take this one on as editor? Looks like it would fit your skillset nicely.

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@boisgera
Copy link

boisgera commented May 5, 2024

@editorialbot invite @boisgera as editor

@boisgera - are you able to take this one on as editor? Looks like it would fit your skillset nicely.

Sure! 👍

@crvernon
Copy link

crvernon commented May 6, 2024

@editorialbot assign @boisgera as editor

Great, thank you!

@editorialbot
Copy link
Collaborator Author

Assigned! @boisgera is now the editor

@crvernon crvernon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 6, 2024
@boisgera
Copy link

@editorialbot add @c-joly as reviewer

@editorialbot
Copy link
Collaborator Author

@c-joly added to the reviewers list!

@boisgera
Copy link

Hi @abreheret, would you like to review this paper and project? I'll send you some details about JOSS journal and the reviewing process by e-mail.

@costashatz
Copy link

👋 @costashatz - thanks for your submission to JOSS. We are currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

In the meantime, you will need to get your paper length down to <= 1000 words. Thanks!

@boisgera @crvernon Thank you for handling the process.

I see that the count of words is done through wc -w paper.md. We need to get this to <= 1000 words? Or just the actual content?

@boisgera
Copy link

boisgera commented May 13, 2024

👋 @costashatz - I see (using an online tool) that the final pdf has 2152 words, which is quite similar to the number produced by wc -w paper.md, when the target is 250 to 1000 words (see JOSS paper format).

I am not sure that I understand what you mean by "actual content"? What would you exclude from the count?

In your case, I see that ~1000 words (as counted by wc -w) come from the (very impressive!) list of scientific publications using RobotDART (31 items). Would you consider replacing it with a few statistics & examples instead? (e.g. number of authors, publications, a few journal/conferences, etc.) and maybe add a hyperlink to the full list hosted on the project website?

That would bring you much closer to the 1000 words threshold.

@costashatz
Copy link

@boisgera thanks for the super fast reply! I see! By "actual content" I meant summary + statement of need, but I see that the list of projects + publications is part of the word count. I'll try to make it more concise. Thanks a lot!

@boisgera
Copy link

@editorialbot add @c-joly as reviewer

@editorialbot
Copy link
Collaborator Author

@c-joly is already included in the reviewers list

@boisgera
Copy link

@editorialbot add @bstanciulescu as reviewer

@editorialbot
Copy link
Collaborator Author

@bstanciulescu added to the reviewers list!

@boisgera
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ C pre-review Python Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

4 participants