Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GRBoondi: A code for evolving Generalized Proca theories on arbitrary backgrounds #6727

Open
editorialbot opened this issue May 7, 2024 · 29 comments
Assignees
Labels
C++ Mathematica pre-review Python Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 7, 2024

Submitting author: @ShaunFell (Shaun D. B. Fell)
Repository: https://github.com/ShaunFell/GRBoondi
Branch with paper.md (empty if default branch): paper
Version: v1.0.0
Editor: @xuanxu
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9565689c5c5d5da3c39adb87a4e7d255"><img src="https://joss.theoj.org/papers/9565689c5c5d5da3c39adb87a4e7d255/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9565689c5c5d5da3c39adb87a4e7d255/status.svg)](https://joss.theoj.org/papers/9565689c5c5d5da3c39adb87a4e7d255)

Author instructions

Thanks for submitting your paper to JOSS @ShaunFell. Currently, there isn't a JOSS editor assigned to your paper.

@ShaunFell if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels May 7, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.16 s (2235.2 files/s, 298306.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                   271           5246           5229          23500
C++                             35           1184           1003           7366
Python                           3            181            140            621
TeX                              1              0              0            591
make                            29            224            143            376
YAML                             5             51              7            316
INI                              3             53             65            165
Markdown                         2             39              0             77
-------------------------------------------------------------------------------
SUM:                           349           6978           6587          33012
-------------------------------------------------------------------------------

Commit count by author:

   165	ShaunFell
    39	Dina Traykova
    22	Shaun Fell
    15	SamuelBrady
     7	KAClough
     6	dinatraykova
     5	Josu C. Aurrekoetxea
     1	Warrick Ball
     1	Zipeng Wang
     1	sbrady00

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1810

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.physrep.2018.11.006 is OK
- 10.1088/1475-7516/2014/05/015 is OK
- 10.21105/joss.03703 is OK
- 10.1088/1475-7516/2022/11/050 is OK
- 10.1103/physrevlett.129.151102 is OK
- 10.1103/physrevlett.129.151103 is OK
- 10.1103/PhysRevD.107.104036 is OK
- 10.1103/physrevd.108.044022 is OK
- 10.1103/PhysRevD.107.123535 is OK
- 10.1088/1475-7516/2022/03/053 is OK
- 10.1088/0264-9381/32/23/234003 is OK
- 10.1088/0264-9381/32/24/245011 is OK
- 10.21105/joss.05956 is OK
- 10.5281/zenodo.10380404 is OK
- 10.1103/PhysRevD.76.104015 is OK
- 10.5281/zenodo.3565474 is OK
- 10.1103/PhysRevD.77.024027 is OK
- 10.1103/PhysRevD.82.024005 is OK
- 10.1103/PhysRevD.85.124010 is OK
- 10.1142/9789812834300_0200 is OK
- 10.1016/S0010-4655(02)00847-0 is OK
- 10.1103/PhysRevD.93.063006 is OK
- 10.5281/zenodo.4734670 is OK
- 10.1016/j.jcp.2016.12.059 is OK
- 10.1142/S0218271819500147 is OK
- 10.1103/PhysRevD.97.064036 is OK
- 10.1103/PhysRevD.93.124059 is OK
- 10.1088/1475-7516/2020/01/007 is OK
- 10.1088/1361-6382/aad7f6 is OK
- 10.3847/1538-4365/ac157b is OK
- 10.1201/b12985 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1016/j.physletb.2016.07.052 is OK
- 10.1016/j.physletb.2016.04.017 is OK
- 10.1088/1475-7516/2016/02/004 is OK
- 10.1007/JHEP04(2014)067 is OK
- 10.1088/1475-7516/2016/06/048 is OK
- 10.1103/PhysRevD.94.044024 is OK
- 10.1103/PhysRevD.93.104016 is OK
- 10.1088/1475-7516/2017/08/024 is OK
- 10.1103/PhysRevD.96.084049 is OK
- 10.1103/PhysRevD.95.123540 is OK

MISSING DOIs

- 10.1103/physrevd.106.084022 may be a valid DOI for title: Resolving the pathologies of self-interacting Proc...
- No DOI given, and none found for title: 3+1 Formalism in General Relativity
- No DOI given, and none found for title: Chombo software package for AMR applications - des...
- 10.1007/3-540-36569-9_13 may be a valid DOI for title: The Cactus Framework and Toolkit: Design and Appli...
- No DOI given, and none found for title: Kranc: Kranc Assembles Numerical Code
- No DOI given, and none found for title: The intrinsic pathology of self-interacting vector...

INVALID DOIs

- https://doi.org/10.1016/j.dark.2021.100819 is INVALID because of 'https://doi.org/' prefix

@ShaunFell
Copy link

I would like to suggest Katy Clough to be the reviewer. We've talked in privately and she has expressed her desire to be the reviewer. Thanks!

@danielskatz
Copy link

@ShaunFell - I think this ended up in the wrong track, so it will likely be moved, which is the next step. Then, once an editor is chosen, they will need to find at least 2 reviewers, so your suggestions on perhaps 4 or 5 would be welcome. Please see the first comment in this issue for a little guidance on this

@ShaunFell
Copy link

Ah, you're right. This should probably be in track 1. Thanks for the help.

@editorialbot editorialbot added Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences and removed Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels May 7, 2024
@ShaunFell
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.15 s (2260.3 files/s, 301688.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                   271           5246           5229          23500
C++                             35           1184           1003           7366
Python                           3            181            140            621
TeX                              1              0              0            593
make                            29            224            143            376
YAML                             5             51              7            316
INI                              3             53             65            165
Markdown                         2             40              0             78
-------------------------------------------------------------------------------
SUM:                           349           6979           6587          33015
-------------------------------------------------------------------------------

Commit count by author:

     2	Shaun-F
     1	ShaunFell

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1810

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@ShaunFell

This comment was marked as duplicate.

1 similar comment
@ShaunFell
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.physrep.2018.11.006 is OK
- 10.1088/1475-7516/2014/05/015 is OK
- 10.21105/joss.03703 is OK
- 10.1088/1475-7516/2022/11/050 is OK
- 10.1103/physrevlett.129.151102 is OK
- 10.1103/physrevlett.129.151103 is OK
- 10.1103/PhysRevD.107.104036 is OK
- 10.1103/physrevd.108.044022 is OK
- 10.1016/j.dark.2021.100819 is OK
- 10.1103/PhysRevD.107.123535 is OK
- 10.1088/1475-7516/2022/03/053 is OK
- 10.1088/0264-9381/32/23/234003 is OK
- 10.1007/978-3-642-24525-1 is OK
- 10.1088/0264-9381/32/24/245011 is OK
- 10.21105/joss.05956 is OK
- 10.5281/zenodo.10380404 is OK
- 10.1103/PhysRevD.76.104015 is OK
- 10.5281/zenodo.3565474 is OK
- 10.1103/PhysRevD.77.024027 is OK
- 10.1103/PhysRevD.82.024005 is OK
- 10.1103/PhysRevD.85.124010 is OK
- 10.1142/9789812834300_0200 is OK
- 10.1016/S0010-4655(02)00847-0 is OK
- 10.1103/PhysRevD.93.063006 is OK
- 10.5281/zenodo.4734670 is OK
- 10.1016/j.jcp.2016.12.059 is OK
- 10.1142/S0218271819500147 is OK
- 10.1103/PhysRevD.97.064036 is OK
- 10.1103/PhysRevD.93.124059 is OK
- 10.1088/1475-7516/2020/01/007 is OK
- 10.1088/1361-6382/aad7f6 is OK
- 10.3847/1538-4365/ac157b is OK
- 10.1201/b12985 is OK
- 10.48550/arXiv.2205.07784 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1016/j.physletb.2016.07.052 is OK
- 10.1016/j.physletb.2016.04.017 is OK
- 10.1088/1475-7516/2016/02/004 is OK
- 10.1007/JHEP04(2014)067 is OK
- 10.1088/1475-7516/2016/06/048 is OK
- 10.1103/PhysRevD.94.044024 is OK
- 10.1103/PhysRevD.93.104016 is OK
- 10.1088/1475-7516/2017/08/024 is OK
- 10.1103/PhysRevD.96.084049 is OK
- 10.1103/PhysRevD.95.123540 is OK

MISSING DOIs

- 10.1103/physrevd.106.084022 may be a valid DOI for title: Resolving the pathologies of self-interacting Proc...
- Errored finding suggestions for "Chombo software package for AMR applications - des...", please try later
- 10.1007/3-540-36569-9_13 may be a valid DOI for title: The Cactus Framework and Toolkit: Design and Appli...
- No DOI given, and none found for title: Kranc: Kranc Assembles Numerical Code

INVALID DOIs

- None

@ShaunFell
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.physrep.2018.11.006 is OK
- 10.1088/1475-7516/2014/05/015 is OK
- 10.48550/arXiv.2206.14320 is OK
- 10.21105/joss.03703 is OK
- 10.1088/1475-7516/2022/11/050 is OK
- 10.1103/physrevlett.129.151102 is OK
- 10.1103/physrevlett.129.151103 is OK
- 10.1103/PhysRevD.107.104036 is OK
- 10.1103/physrevd.108.044022 is OK
- 10.1016/j.dark.2021.100819 is OK
- 10.1103/PhysRevD.107.123535 is OK
- 10.1088/1475-7516/2022/03/053 is OK
- 10.1088/0264-9381/32/23/234003 is OK
- 10.1007/978-3-642-24525-1 is OK
- 10.1088/0264-9381/32/24/245011 is OK
- 10.21105/joss.05956 is OK
- 10.5281/zenodo.10380404 is OK
- 10.1007/3-540-36569-9_13 is OK
- 10.1016/j.cpc.2006.02.002 is OK
- 10.1103/PhysRevD.76.104015 is OK
- 10.5281/zenodo.3565474 is OK
- 10.1103/PhysRevD.77.024027 is OK
- 10.1103/PhysRevD.82.024005 is OK
- 10.1103/PhysRevD.85.124010 is OK
- 10.1142/9789812834300_0200 is OK
- 10.1016/S0010-4655(02)00847-0 is OK
- 10.1103/PhysRevD.93.063006 is OK
- 10.5281/zenodo.4734670 is OK
- 10.1016/j.jcp.2016.12.059 is OK
- 10.1142/S0218271819500147 is OK
- 10.1103/PhysRevD.97.064036 is OK
- 10.1103/PhysRevD.93.124059 is OK
- 10.1088/1475-7516/2020/01/007 is OK
- 10.1088/1361-6382/aad7f6 is OK
- 10.3847/1538-4365/ac157b is OK
- 10.1201/b12985 is OK
- 10.48550/arXiv.2205.07784 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1016/j.physletb.2016.07.052 is OK
- 10.1016/j.physletb.2016.04.017 is OK
- 10.1088/1475-7516/2016/02/004 is OK
- 10.1007/JHEP04(2014)067 is OK
- 10.1088/1475-7516/2016/06/048 is OK
- 10.1103/PhysRevD.94.044024 is OK
- 10.1103/PhysRevD.93.104016 is OK
- 10.1088/1475-7516/2017/08/024 is OK
- 10.1103/PhysRevD.96.084049 is OK
- 10.1103/PhysRevD.95.123540 is OK

MISSING DOIs

- No DOI given, and none found for title: Chombo software package for AMR applications - des...

INVALID DOIs

- None

@ShaunFell
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@dfm
Copy link

dfm commented May 8, 2024

@ShaunFell — Thank you for your submission! It seems like a large fraction of the code included in this repo is a copy of GRChombo which was previously published in JOSS. Could you clarify which parts of the project are new to this submission?

In the meantime, all suitable editors are working at full capacity so I will "waitlist" this submission until someone is available. Thanks for your patience!

@dfm dfm added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 8, 2024
@ShaunFell
Copy link

ShaunFell commented May 8, 2024

@dfm Everything is new besides the folder Source/GRChombo. I included the GRChombo source code in the repo to ensure updates to the GRChombo source code don't break the functionality of GRBoondi. Besides that, everything else in the Source/ directory is my own, as well as the everything in PostProcessing/, Tests/, InstallNotes/, and Examples/.

That is to say, everything besides Source/GRChombo was built by myself.

Ok, thank you for letting me know! Would you happen to know approximately how long the wait is?

@ShaunFell
Copy link

ShaunFell commented May 9, 2024

For future reviewers, to gauge the size of GRBoondi itself without the GRChombo source code, I run
cloc --exclude-dir=GRChombo GRBoondi
which produces:

       202 text files.
     161 unique files.                                          
      78 files ignored.

 github.com/AlDanial/cloc v 1.90  T=3.89 s (32.4 files/s, 3947.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                    95           1747           1762           7258
C++                              9            349            261           2030
Python                           3            181            140            621
YAML                             5             51              7            316
make                            10             83             51            198
INI                              3             53             65            165
Markdown                         1             11              0             16
-------------------------------------------------------------------------------
SUM:                           126           2475           2286          10604
-------------------------------------------------------------------------------

@dfm
Copy link

dfm commented May 9, 2024

Thanks for the info, @ShaunFell!

@dfm
Copy link

dfm commented Jun 1, 2024

@editorialbot invite @xuanxu as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@dfm
Copy link

dfm commented Jun 1, 2024

I note that @kaclough has been recommended as a reviewer.

@xuanxu
Copy link
Member

xuanxu commented Jun 3, 2024

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @xuanxu is now the editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Mathematica pre-review Python Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

5 participants