-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: servir-aces: A Python Package for Training Machine Learning Models for Remote Sensing Applications #6729
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
@biplovbhandari , @jtagusari, @nagellette , This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. For @nagellette and @jtagusari - Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. As you are probably already aware, The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #6729 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. Thanks in advance and let me know if you have any questions!! |
@editorialbot remind @nagellette in 2 weeks |
Reminder set for @nagellette in 2 weeks |
@editorialbot remind @jtagusari in 2 weeks |
Reminder set for @jtagusari in 2 weeks |
Review checklist for @jtagusariConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @nagelletteConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@biplovbhandari although there are multiple applications with GEE and Tensorflow in the context of agricultural applications that are mentioned in statement of need section I couldn't find anything actually referring to similar software and comparing yours against to them. One example I can think of is torchgeo which is providing access to different sources (incl. Sentinel and Landsat which I think are also available via GEE) while providing processing and training capabilities in Pytorch. Another example would be raster-vision. I am not aware anything in Tensorflow sourcing from GEE though I suggest looking in to similar software, referring to them while emphasizing servir-aces's contribution.
|
@jtagusari @nagellette Thanks for your comments and review. I am currently on work travel, hence the delay. I will get back to you soon. Thank you for your patience :) |
👋 @nagellette, please update us on how your review is going (this is an automated reminder). |
👋 @jtagusari, please update us on how your review is going (this is an automated reminder). |
@biplovbhandari It seems both reviewers have posted some issues and comments regarding the paper and the code. Could you take a pass at the same over the next couple of weeks. Thanks! After that, I can ask the reviewers to take another pass. @jtagusari and @nagellette - Let me know if this sounds right to you wanted to add something to the above. |
@editorialbot remind @biplovbhandari in 2 weeks |
Reminder set for @biplovbhandari in 2 weeks |
While the author responds, @jtagusari could you provide a quick update on your review. I saw that you had checked off a few items on your checklist. Is it that you will check off the remaining once the author makes the adjustments you suggested? Do let me know if you need anything at all from me or the author. Thank you again ! |
@biplovbhandari l. 14-19 l. 27-28 |
👋 @biplovbhandari, please update us on how things are progressing here (this is an automated reminder). |
@jtagusari I attempt to address the point in the new version. Please check! There is also an updated README for running the package. Thanks! |
Submitting author: @biplovbhandari (Biplov Bhandari)
Repository: https://github.com/SERVIR/servir-aces
Branch with paper.md (empty if default branch):
Version: v0.0.16
Editor: @kanishkan91
Reviewers: @nagellette, @jtagusari
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@nagellette & @jtagusari, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kanishkan91 know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jtagusari
📝 Checklist for @nagellette
The text was updated successfully, but these errors were encountered: