-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: cottoncandy: scientific python package for easy cloud storage #890
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @vsoch it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
Hi, @vsoch, your review checklist is available here (above ^^). Please let me know if you have any questions about the process. |
I have posted my review and updated the boxes above thus far! Please see the linked issue for discussion on the submission. |
Thank you @vsoch for the very detailed review! |
Thanks for the review! I'll start working on the fixes to address your comments this weekend. |
Awesome! And I don't know the rules for this sort of thing, but please let me know if I can be of any help! 🍬 |
Feel free to continue the dialogue here or over there as needed and ping me if I can help on any procedural issues. |
Hello! I made a new branch containing all the changes requested here: https://github.com/gallantlab/cottoncandy/tree/joss_review Looking forward to your feedback! |
Great. Thanks, @anwarnunez. @vsoch, please take a look when you can. |
Yes thank you, already noted! |
@whedon generate pdf |
Here are some things you can ask me to do:
|
@whedon generate pdf |
|
Great job @anwarnunez and thank you @leeper and @whedon. My further comments are here: gallantlab/cottoncandy#63 (comment) Happy Monday! |
@whedon generate pdf |
|
@leeper my review is complete, I think we are good to go! @anwarnunez and @leeper we will need the release to be 0.1.0 to coincide with the rc versions, and the (updated) one in this issue board. Great work everyone! |
Great! |
@whedon generate pdf |
|
@whedon set 10.5281/zenodo.1402799 as archive |
OK. 10.5281/zenodo.1402799 is the archive. |
@anwarnunez Please merge this PR: gallantlab/cottoncandy#68 |
merged! |
@whedon generate pdf |
|
@arfon over to you |
@vsoch - many thanks for your review here and to @leeper for editing this submission ✨ @anwarnunez - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00890 ⚡ 🚀 💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @anwarnunez (Anwar Nunez-Elizalde)
Repository: https://github.com/gallantlab/cottoncandy
Version: 0.1.0
Editor: @leeper
Reviewer: @vsoch
Archive: 10.5281/zenodo.1402799
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@vsoch, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @leeper know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @vsoch
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: