-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Nashpy: A Python library for the computation of Nash equilibria #904
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @Fil, it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
👋 @Fil, @alex-konovalov — This is where the action happens. Feel free to ask any questions. |
On drvinceknight/Nashpy#45 @Fil pointed out that the version specified in the paper meta data ( Should I edit the first comment to change the version number ( |
Apart from the version issue, it's all good for me. Thank you @drvinceknight for submitting to JOSS. |
I've updated the version number in the review issue. |
👋 @alex-konovalov — will you be able to submit your review soon? Let me know! |
@labarba sorry for delay - should be there by Monday! |
@labarba review completed. Fixed two typos in drvinceknight/Nashpy#50 and pointed out a couple of issues with DOIs at drvinceknight/Nashpy#51. Otherwise, straightforward installation, proper testing and detailed documentation - @drvinceknight, thank you for submitting to JOSS! |
Thanks @alex-konovalov for your time (I believe I have fixed the issues you pointed out) and thanks again @Fil as well. @labarba please let me know if I can do anything further at this stage. |
@whedon generate pdf |
|
Small editorial fixes:
|
Also, DOI links in the reference list are broken. Please clean up the bib file so the links resolve. |
Thanks @labarba I'll make those changes over next couple of days. |
OK. Ping when done! |
@whedon generate pdf |
|
@whedon generate pdf |
|
@whedon generate pdf |
@labarba thank you very much for taking the time to point all those out. I've made all the changes (drvinceknight/Nashpy@67a27f3) and checked the proof. I believe it's all done now :) |
I bring you more editorial fixes! Page 1, par. 2: comma before “which” |
@whedon generate pdf |
|
@whedon generate pdf |
|
Thanks again @labarba, I believe drvinceknight/Nashpy@af30119 gets all these. If there's anything else let me know. I appreciate you taking the time. :) |
OK! Go ahead and make a deposit on Zenodo now (or your favorite archival repository) and do post the DOI here. |
@whedon generate pdf |
|
Thank you @labarba, here is the zenodo archive: https://zenodo.org/record/1453761 Let me know if I need to do anything further (and thanks again for all your time). |
The author list on the Zenodo entry does not match the author list on the paper. You may need to manually edit the author list on Zenodo (which grabs that automatically from commit history, I think.) |
@labarba: that's been updated now. |
👋 @arfon — this paper is accepted and ready to be published. Many thanks to @Fil and @alex-konovalov for reviewing for JOSS. Without your efforts, this adventure in new-wave publishing would not be possible! |
@whedon set 10.5281/zenodo.1453761 as archive |
OK. 10.5281/zenodo.1453761 is the archive. |
@drvinceknight - can you confirm that this maths looks OK? @whedon is giving me a warning when compiling the paper 10.21105.joss.00904.pdf
|
@arfon I confirm that that looks right. (I'd suggest that it looks like the compiler is just raising a warning before falling "up" to use a superset compiler with the amsmath library.) |
@Fil, @alex-konovalov - many thanks for your reviews here and to @labarba for editing this submission ✨ @drvinceknight - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00904 ⚡ 🚀 💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @drvinceknight (Vincent Knight)
Repository: https://github.com/drvinceknight/Nashpy
Version: v0.0.18
Editor: @labarba
Reviewer: @Fil, @alex-konovalov
Archive: 10.5281/zenodo.1453761
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@Fil & @alex-konovalov, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @labarba know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @Fil
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @alex-konovalov
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: