Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SeqTools: A python package for easy transformation, combination and evaluation of large datasets #998

Closed
whedon opened this issue Oct 5, 2018 · 19 comments
Assignees

Comments

@whedon
Copy link

whedon commented Oct 5, 2018

Submitting author: @nlgranger (Nicolas Granger)
Repository: https://github.com/nlgranger/SeqTools
Version: v0.9.0
Editor: @pjotrp
Reviewers: @Benjamin-Lee

Author instructions

Thanks for submitting your paper to JOSS @nlgranger. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@nlgranger if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@Benjamin-Lee
Copy link

This looks really cool! @arfon I'd be happy to help out in the review of this.

@arfon
Copy link
Member

arfon commented Oct 8, 2018

@mgymrek @pjotrp - would either if you be willing to edit this submission for JOSS?

@pjotrp
Copy link

pjotrp commented Oct 8, 2018

Yes, I am happy to help out. Unless Melissa feels she should do this one.

@pjotrp
Copy link

pjotrp commented Oct 9, 2018

@whedon assign @pjotrp as editor

@whedon
Copy link
Author

whedon commented Oct 9, 2018

OK, the editor is @pjotrp

@pjotrp
Copy link

pjotrp commented Oct 9, 2018

@whedon assign @Benjamin-Lee as reviewer

@whedon
Copy link
Author

whedon commented Oct 9, 2018

OK, the reviewer is @Benjamin-Lee

@pjotrp
Copy link

pjotrp commented Oct 9, 2018

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Oct 9, 2018

OK, I've started the review over in #1006. Feel free to close this issue now!

@pjotrp
Copy link

pjotrp commented Oct 9, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 9, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 9, 2018

PDF failed to compile for issue #998 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon.rb:83:in check_fields': Paper YAML header is missing expected fields: bibliography (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon.rb:69:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon/processor.rb:32:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/bin/whedon:37:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/bin/whedon:99:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@pjotrp
Copy link

pjotrp commented Oct 9, 2018

@nlgranger please fix the PDF. You can generate it yourself with `@whedon generate pdf'

@nlgranger
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 9, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 9, 2018

PDF failed to compile for issue #998 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon.rb:91:in block in check_orcids': Problem with ORCID (0000-0000-0000-0000) for Mounîm A. El Yacoubi (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon.rb:89:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon.rb:89:in check_orcids' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon.rb:70:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon/processor.rb:32:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/bin/whedon:37:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/bin/whedon:99:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@nlgranger
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 9, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 9, 2018

@arfon arfon closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants