Prepend @ on reviewer names

openjournals · Aug 20, 2018 · 6b4eab3 · 6b4eab3
1 parent fdf02d1
commit 6b4eab3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/models/paper.rb b/app/models/paper.rb
@@ -171,7 +171,7 @@ def create_review_issue(editor_handle, reviewers)
 
   # Update the paper with the reviewer GitHub handles
   def set_reviewers(reviewers)
-    reviewers = reviewers.split(',')
+    reviewers = reviewers.split(',').each {|r| r.prepend('@') unless r.start_with?('@') }
     self.update_attribute(:reviewers, reviewers)
   end
 

diff --git a/spec/controllers/papers_controller_spec.rb b/spec/controllers/papers_controller_spec.rb
@@ -109,7 +109,7 @@
 
       expect(response).to be_created
       expect(editor.papers.count).to eq(1)
-      expect(paper.reload.reviewers).to eq(['mickey'])
+      expect(paper.reload.reviewers).to eq(['@mickey'])
     end
 
     it "with the correct API key and multiple reviewers" do
@@ -125,7 +125,7 @@
       post :api_start_review, params: {:secret => "mooo", :id => 1234, :reviewers => "mickey,minnie", :editor => "mouse"}
       expect(response).to be_created
       expect(editor.papers.count).to eq(1)
-      expect(paper.reload.reviewers).to eq(['mickey', 'minnie'])
+      expect(paper.reload.reviewers).to eq(['@mickey', '@minnie'])
     end
   end