-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CADTools - Drawing Blocks throws NPEs #56
Comments
OpenJUMP-Portable-20220823-r5135[6899249]-PLUS Just a reminder to explain the bug and define the last test CadTools: the bug affects blocks made by polygons with holes (for instance bore_01 or geology_05. It does not ot affect blocks made by polygons without holes (for instance geology_01) or multipolygons (geology_03) Vertex Synbology the same: the bug affects shapes (symbols) made by polygons with holes (for instance bore_01 or geology_05. It does not ot affect blocks made by polygons without holes (for instance geology_01) or multipolygons (geology_03) Both CadTools and Vertex Synbology define the geometries/shapes reading WKT files in lib/ext/VertexImages folder |
Peppe, let me refer you to my answers on the sf.net ticket, also i explicitly asked you not to open another one here, guess you didn't see that. so again, works for me since rev5128 see if it still does not for you i will need more details. specifically
i will close the issue an sf.net assuming that we will stay here the for the issue being. |
Hi Ede, I started to test the errror with this java versions 1.8.0_311 and 1.8.0_341 This is the error stack from the log file when I try to load a project with ExtendedVertexSymbols (Vertex Image plugin)
|
I Ede, a) select the first icon to the left (Draw a block), select block bore_01 b) select the second icon to the left (Draw an oriented block)
Note that, with the older java version 1.8.0_311, both a) and b) were generating errors With OpenJUMP 1.16 no error were generating (I did this test just in case to have an history if there wers some changes) I still think that the bug in CadTools and the one in VertexImagesas are related as they share some code on how to read WKT symbols, rotate and transform into geometries. I will not open another issue, maybe solving CadTools solves also VertexImage Bets regards |
yes, this was fixed in my initial approach
right, didn't try that one. the fix is identical and i'll tackle that soonish
according to my debugging the cause lies in the upgraded jts 1.19 . for some reason some symbols fail the geometry validity test. as they are only symbols, deactivatiing the need for validity solves the issue.
wrt. VertexSymbols. please try to create a new project with VertexSymbol decorations in OJ2. we lost old OJ1.x project compatibility as it seems in that regard. |
openjump-gis/openjump#56 using new null safe execute() call in OJ2 now
hey @ma15569 pls test the next snapshot. the issue should be fixed now. if so pls close this issue . thx! |
The bug is solved for CADTools Blocks plugin. |
PlugIn: CADTools
Bug description: It is not possible to draw a good 50% of the embedded blocks this which throw null point exceptions.
It seems that blocks made by simple polygons or multipolygons with no holes can be drawn.
Blocks made by the previous geometries with holes not.
Blocks displayed by CADTools are stored into Lib/Ext/VertexImages folder (blocks are used by CadPlan Vertex Images plugin too) and they are simple WKT files
The text was updated successfully, but these errors were encountered: