Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New font PTSans for forms #60

Merged
merged 2 commits into from Nov 1, 2023

Conversation

dippeal
Copy link
Member

@dippeal dippeal commented Oct 30, 2023

No description provided.

MSchmalzl
MSchmalzl previously approved these changes Oct 30, 2023
Copy link

@NicoB77 NicoB77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das Encoding wurde in UTF8 geändert, Source-Encoding ist aber ISO-8859-1

@dippeal
Copy link
Member Author

dippeal commented Oct 30, 2023

Das Encoding wurde in UTF8 geändert, Source-Encoding ist aber ISO-8859-1

Angepasst in a876927

@MSchmalzl
Copy link

Ist das Encoding eine globale Eigenschaft? Bzw. was spricht gegen UTF-8?

@NicoB77
Copy link

NicoB77 commented Nov 1, 2023

Das Encoding ist global. Es wäre auch gar nicht wünschenswert, es pro Datei vorzugeben. Und weil global ISO-8859-1 eingestellt ist, werden für in UTF-8 kodierte Java-Dateien Sonderzeichen in der GUI falsch dargestellt. Natürlich könnte man das Encoding global in UTF-8 ändern, aber das wäre definitiv ein eigener Pull-Request.

@MSchmalzl MSchmalzl merged commit 0a8033f into openjverein:master Nov 1, 2023
@dippeal dippeal deleted the feature/font-ptsans branch November 1, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants