Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: add ecb fx currencies #1426

Merged
merged 1 commit into from
Aug 16, 2023
Merged

frontend: add ecb fx currencies #1426

merged 1 commit into from
Aug 16, 2023

Conversation

SamuelPull
Copy link
Collaborator

@SamuelPull SamuelPull commented Jul 26, 2023

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Discontinued national currencies that have been replaced by euro were not included so the UI will not be bloated. If there is a requirement to include discontinued currencies, they can be added later.

In several instances, currency symbols were changed in accordance with World Bank editiorial style guide. Codes stayed the same throughout. E.g. previously Danish crown was kr. in TB. With the addition of Norwegian and Swedish currencies, which also use crowns, it was necessary to change Danish crown from kr. to dkr, while the code remains DKK.

Additional currencies that were required do not have ECB FX in the existing api: KWD, QAR, SAR.
QAR and SAR have fixed exchange rate referencing US Dollar, these can be calculated based on USD FX.
KWD has been moved to follow up task #1440.

Closes #1154

@openkfwCI
Copy link

openkfwCI commented Jul 26, 2023

NotesTime
Note for Reviewer: E2E tests on remote server succeededMon, 14 Aug 2023 09:06:30 +0000

Generated by E2E-Test

@SamuelPull SamuelPull force-pushed the 1154-ecb-currencies branch 5 times, most recently from c340bf9 to b56bdea Compare July 27, 2023 11:40
@SamuelPull SamuelPull marked this pull request as ready for review July 27, 2023 12:58
@SamuelPull SamuelPull force-pushed the 1154-ecb-currencies branch 3 times, most recently from 0998c32 to 67fee80 Compare August 9, 2023 07:15
@SamuelPull SamuelPull changed the title frontend: add ecb fx currencies draft: frontend: add ecb fx currencies Aug 9, 2023
@SamuelPull SamuelPull changed the title draft: frontend: add ecb fx currencies frontend: add ecb fx currencies Aug 14, 2023
@andrea-smiesna andrea-smiesna merged commit 4ae1c52 into main Aug 16, 2023
29 checks passed
@andrea-smiesna andrea-smiesna deleted the 1154-ecb-currencies branch August 16, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding currencies - SP 3
3 participants