Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests due to function name changes #156

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix tests due to function name changes #156

merged 1 commit into from
Jan 29, 2024

Conversation

mjwen
Copy link
Collaborator

@mjwen mjwen commented Jan 29, 2024

No description provided.

@mjwen mjwen added the fix label Jan 29, 2024
@mjwen mjwen merged commit d33a117 into v1 Jan 29, 2024
8 checks passed
@mjwen
Copy link
Collaborator Author

mjwen commented Jan 29, 2024

@ipcamit

I've fixed the tests and merged into v1. Now #153 passes all tests.

For the next PR you have, we should make all tests pass, unless some major breaking changes are preventing us from doing that.

@ipcamit
Copy link

ipcamit commented Jan 29, 2024

No. With the last merge I think I can get all the tests up until the transformation modules pass. I am currently adding some functionality to libdescriptor, will then add tests to kliff for all the changes made till now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants