Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColabFit Changes #174

Merged
merged 3 commits into from Apr 1, 2024
Merged

ColabFit Changes #174

merged 3 commits into from Apr 1, 2024

Conversation

EFuem
Copy link

@EFuem EFuem commented Mar 28, 2024

Modified the way in which data is fetched from ColabFit. Additional logic needed to be built in, so this was done on the ColabFit side which resulted in a simplification on the KLIFF side.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 63.14%. Comparing base (33c9212) to head (4138e57).
Report is 1 commits behind head on v1.

Files Patch % Lines
kliff/dataset/dataset.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v1     #174      +/-   ##
==========================================
- Coverage   63.20%   63.14%   -0.07%     
==========================================
  Files          50       50              
  Lines        4713     4718       +5     
==========================================
  Hits         2979     2979              
- Misses       1734     1739       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjwen
Copy link
Collaborator

mjwen commented Mar 29, 2024

@EFuem Thanks !

There is some linting error as can be seen from the CI report below. Can you please do a quick pre-commit run to fix that? See https://kliff.readthedocs.io/en/latest/contributing_guide.html#code-style

Also, we need to think about how to test the from_colabfit method a bit to make sure everything works (maybe not this PR). It uses MongoDB and such, which make testing more involved and I don't have idea on how to effectively test that. You've got any idea?

@mjwen mjwen merged commit 9ee3ce8 into openkim:v1 Apr 1, 2024
4 of 6 checks passed
@mjwen
Copy link
Collaborator

mjwen commented Apr 1, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants