Merge pull request #1095 from openkraken/fix/textOverflow_is_null

Fix/text overflow is null
openkraken · Jan 13, 2022 · 04def9f · 04def9f
2 parents 6a3bbba + 843a1bc
commit 04def9f
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/integration_tests/snapshots/css/css-text/text-overflow.ts.8712487d1.png b/integration_tests/snapshots/css/css-text/text-overflow.ts.8712487d1.png
diff --git a/integration_tests/specs/css/css-text/text-overflow.ts b/integration_tests/specs/css/css-text/text-overflow.ts
@@ -81,6 +81,26 @@ describe('Text Overflow', () => {
     return snapshot();
   });
 
+  it('should work with empty string', () => {
+    const cont = createElementWithStyle(
+      'div',
+      {
+        width: '50px',
+        backgroundColor: '#f40',
+        overflow: 'hidden',
+        whiteSpace: 'nowrap',
+        textOverflow: ''
+      },
+      [
+        createText('text is cliped'),
+      ]
+    );
+
+    append(BODY, cont);
+
+    return snapshot();
+  });
+
   it('should not work with ellipsis when overflow visible', () => {
 
     const cont = createElementWithStyle(
@@ -161,7 +181,7 @@ describe('Text Overflow', () => {
     await snapshot();
   });
 
-  it('should works with ellipsis of one line and lineHeight exists',() => {
+  it('should works with ellipsis of one line and lineHeight exists', () => {
     const cont = createElementWithStyle(
       'div',
       {
@@ -181,7 +201,7 @@ describe('Text Overflow', () => {
     return snapshot();
   });
 
-  it('should works with ellipsis of two line and lineHeight exists',() => {
+  it('should works with ellipsis of two line and lineHeight exists', () => {
     const cont = createElementWithStyle(
       'div',
       {

diff --git a/kraken/lib/src/css/text.dart b/kraken/lib/src/css/text.dart
@@ -287,9 +287,9 @@ mixin CSSTextMixin on RenderStyle {
   TextOverflow get textOverflow {
     return _textOverflow;
   }
-  set textOverflow(TextOverflow value) {
+  set textOverflow(TextOverflow? value) {
     if (_textOverflow == value) return;
-    _textOverflow = value;
+    _textOverflow = value ?? TextOverflow.clip;
     // Non inheritable style change should only update text node in direct children.
     _markTextNeedsLayout();
   }