fix: fix integration crash at iframe tags.

openkraken · Jun 21, 2021 · 32fd37d · 32fd37d
1 parent ede04e6
commit 32fd37d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/integration_tests/pubspec.yaml b/integration_tests/pubspec.yaml
@@ -27,10 +27,10 @@ dependencies:
     sdk: flutter
   kraken: 0.8.0-dev.1
   image: ^3.0.2
-  kraken_video_player: ^0.4.0-dev.3
-  kraken_websocket: ^0.2.0-dev.2
-  kraken_animation_player: ^0.2.0-dev.1
-  kraken_webview: ^0.6.0-dev.1
+  kraken_video_player: ^0.4.0
+  kraken_websocket: ^0.2.0
+  kraken_animation_player: ^0.2.0
+  kraken_webview: ^0.6.0
 
 dev_dependencies:
   test: ^1.16.8

diff --git a/integration_tests/scripts/integration_starter.js b/integration_tests/scripts/integration_starter.js
@@ -5,7 +5,16 @@ const isPortReachable = require('is-port-reachable');
 
 // Dart null safety error didn't report in dist binaries. Should run integration test with flutter run directly.
 function startIntegrationTest() {
-  const tester = spawn('flutter', ['run', '-d', 'macos'], {
+  const shouldSkipBuild = /skip\-build/.test(process.argv);
+  if (!shouldSkipBuild) {
+    console.log('Building integration tests macOS application from "lib/main.dart"...');
+    spawnSync('flutter', ['build', 'macos', '--debug'], {
+      stdio: 'inherit'
+    });
+  }
+
+  const testExecutable = path.join(__dirname, '../build/macos/Build/Products/Debug/tests.app/Contents/MacOS/tests');
+  const tester = spawn(testExecutable, [], {
     env: {
       ...process.env,
       KRAKEN_ENABLE_TEST: 'true',