feat: modify document.createDocumentFragment

openkraken · Aug 31, 2021 · 3c0b25c · 3c0b25c
1 parent cd8263a
commit 3c0b25c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/bridge/bindings/jsc/DOM/document.cc b/bridge/bindings/jsc/DOM/document.cc
@@ -62,9 +62,8 @@ JSValueRef JSDocument::createEvent(JSContextRef ctx, JSObjectRef function, JSObj
 JSValueRef JSDocument::createDocumentFragment(JSContextRef ctx, JSObjectRef function, JSObjectRef thisObject,
                                               size_t argumentCount, const JSValueRef arguments[], JSValueRef *exception) {
   auto document = static_cast<DocumentInstance *>(JSObjectGetPrivate(thisObject));
-  std::string strDocumentFragment = "documentFragment";
-  auto element = JSElement::buildElementInstance(document->context, strDocumentFragment);
-  return element->object;
+  auto documentFragment = new JSDocumentFragment::DocumentFragmentInstance(JSDocumentFragment::instance(document->context));
+  return documentFragment->object;
 }
 
 JSValueRef JSDocument::createElement(JSContextRef ctx, JSObjectRef function, JSObjectRef thisObject,

diff --git a/bridge/bindings/jsc/DOM/elements/document_fragment.cc b/bridge/bindings/jsc/DOM/elements/document_fragment.cc
@@ -18,7 +18,7 @@ JSDocumentFragment::~JSDocumentFragment() {
   instanceMap.erase(context);
 }
 
-JSDocumentFragment::JSDocumentFragment(JSContext *context) : JSElement(context) {}
+JSDocumentFragment::JSDocumentFragment(JSContext *context) : JSNode(context) {}
 JSObjectRef JSDocumentFragment::instanceConstructor(JSContextRef ctx, JSObjectRef constructor, size_t argumentCount,
                                               const JSValueRef *arguments, JSValueRef *exception) {
   auto instance = new DocumentFragmentInstance(this);

diff --git a/bridge/bindings/jsc/DOM/elements/document_fragment.h b/bridge/bindings/jsc/DOM/elements/document_fragment.h
@@ -13,7 +13,7 @@ namespace kraken::binding::jsc {
 
 void bindDocumentFragment(std::unique_ptr<JSContext> &context);
 
-class JSDocumentFragment : public JSElement {
+class JSDocumentFragment : public JSNode {
 public:
   static std::unordered_map<JSContext *, JSDocumentFragment *> instanceMap;
   OBJECT_INSTANCE(JSDocumentFragment)