Merge pull request #612 from openkraken/fix/fix_window_open

fix: fix window open not working when bundleURL not exist.
openkraken · Aug 23, 2021 · 48e9355 · 48e9355
2 parents ad850f4 + c90680e
commit 48e9355
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/kraken/lib/src/dom/window.dart b/kraken/lib/src/dom/window.dart
@@ -9,6 +9,7 @@ import 'dart:ui';
 import 'package:kraken/bridge.dart';
 import 'package:kraken/dom.dart';
 import 'package:kraken/module.dart';
+import 'package:kraken/launcher.dart';
 
 const String WINDOW = 'WINDOW';
 
@@ -55,9 +56,8 @@ class Window extends EventTarget {
     String url = nativeStringToString(urlPtr);
 
     ElementManager elementManager = _nativeMap[nativeWindowPtr.address]!.elementManager;
-    String? sourceUrl = elementManager.controller.view.rootController.bundleURL;
-
-    if (sourceUrl == null) return;
+    KrakenController rootController = elementManager.controller.view.rootController;
+    String? sourceUrl = rootController.bundleURL ?? rootController.bundlePath;
 
     elementManager.controller.view.handleNavigationAction(sourceUrl, url, KrakenNavigationType.navigate);
   }