fix: transition should be disabled when duration is 0.

openkraken · Aug 4, 2021 · a588021 · a588021
1 parent 5497fbb
commit a588021
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/kraken/lib/src/css/style_declaration.dart b/kraken/lib/src/css/style_declaration.dart
@@ -144,8 +144,20 @@ class CSSStyleDeclaration {
     if ((prevValue == null && CSSLength.isAuto(CSSInitialValues[property])) || CSSLength.isAuto(prevValue) || CSSLength.isAuto(nextValue)) {
       return false;
     }
-    return CSSTransformHandlers[property] != null &&
-      (_transitions.containsKey(property) || _transitions.containsKey(ALL));
+
+    if (CSSTransformHandlers[property] != null &&
+      (_transitions.containsKey(property) || _transitions.containsKey(ALL))) {
+      bool shouldTransition = false;
+      // Transtion will be disabled when all transition has transitionDuration as 0.
+      _transitions.forEach((String transitionKey, List transitionOptions) {
+        double duration = CSSTime.parseTime(transitionOptions[0]).toDouble();
+        if (duration != 0) {
+          shouldTransition = true;
+        }
+      });
+      return shouldTransition;
+    }
+    return false;
   }
 
   EffectTiming? _getTransitionEffectTiming(String property) {