refactor: move _invokeMethodFromJavaScript to KrakenMethodChannel's s…

…tatic method
openkraken · May 8, 2021 · f4be5ce · f4be5ce
1 parent b835863
commit f4be5ce
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/kraken/lib/src/launcher/controller.dart b/kraken/lib/src/launcher/controller.dart
@@ -471,7 +471,7 @@ class KrakenController {
     }
 
     _methodChannel = methodChannel;
-    setJSMethodCallCallback(this);
+    KrakenMethodChannel.setJSMethodCallCallback(this);
 
     _view = KrakenViewController(viewportWidth, viewportHeight,
         background: background,

diff --git a/kraken/lib/src/module/method_channel.dart b/kraken/lib/src/module/method_channel.dart
@@ -38,14 +38,6 @@ class MethodChannelModule extends BaseModule {
   }
 }
 
-void setJSMethodCallCallback(KrakenController controller) {
-  if (controller.methodChannel == null) return;
-
-  controller.methodChannel._onJSMethodCall = (String method, dynamic arguments) async {
-    controller.module.moduleManager.emitModuleEvent(METHOD_CHANNEL_NAME, data: [method, arguments]);
-  };
-}
-
 class KrakenMethodChannel {
   MethodCallCallback _onJSMethodCallCallback;
 
@@ -55,6 +47,14 @@ class KrakenMethodChannel {
   }
 
   Future<dynamic> _invokeMethodFromJavaScript(String method, List arguments) async {}
+
+  static void setJSMethodCallCallback(KrakenController controller) {
+    if (controller.methodChannel == null) return;
+
+    controller.methodChannel._onJSMethodCall = (String method, dynamic arguments) async {
+      controller.module.moduleManager.emitModuleEvent(METHOD_CHANNEL_NAME, data: [method, arguments]);
+    };
+  }
 }
 
 class KrakenJavaScriptChannel extends KrakenMethodChannel {