Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Flutter 2.5.1 #703

Closed
kmaxion opened this issue Sep 24, 2021 · 2 comments
Closed

Support for Flutter 2.5.1 #703

kmaxion opened this issue Sep 24, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@kmaxion
Copy link

kmaxion commented Sep 24, 2021

Hello,
Is there a plan to support Flutter 2.5.1 (using Dart 2.14) in the near future? Currently it's not compiling due to a difference in function signatures for HttpClient.authenticate

https://api.dart.dev/stable/2.14.2/dart-io/HttpClient/authenticate.html
https://github.com/openkraken/kraken/blob/main/kraken/lib/src/foundation/http_client.dart#L66-L69

使用的 Kraken 版本 | What version of kraken are you using

Version 0.8.3+3

重现步骤 | Steps To Reproduce

Run Flutter build on version 2.5.0 and above with Kraken as a dependency

预期结果 | Expected results:
App should build and run

实际结果 | Actual results:
Flutter app doesn't compile. Here is the error message:

/Users/user/.pub-cache/hosted/pub.dartlang.o rg/kraken-0.8.3+3/lib/src/foundation/http_client.dar t:68:37: Error: A value of type 'Future<bool> Function(Uri, String, String)?' can't be assigned to a variable of type 'Future<bool> Function(Uri, String, String?)?' because 'String?' is nullable and 'String' isn't. - 'Future' is from 'dart:async'. - 'Uri' is from 'dart:core'. nativeHttpClient.authenticate

@kmaxion kmaxion added the bug Something isn't working label Sep 24, 2021
@cnryb
Copy link
Member

cnryb commented Sep 26, 2021

We are discussing how to support flutter 2.5.x .
Please pay attention to the detailed progress #700 .

@cnryb
Copy link
Member

cnryb commented Jan 6, 2022

Support flutter 2.5.x in #817

@cnryb cnryb closed this as completed Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants