fix: relayout boundary of flex item #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temper357
requested review from
yuanyan,
andycall,
answershuto and
wssgcg1213
yuanyan
approved these changes
Dec 28, 2021
andycall
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 中删除的代码会使 flex item 的 relayout boundary 失效，即使 flex item 上有设置宽高，还是会继续向上冒脏标识。
这段代码的原始含义是，flex item 的 size 变化时可能影响到 sibling 的 size，如果 flex item 自身是 relayout boundary 那么脏标识不会冒泡到 parent，重构过后的代码中这个逻辑已经在 css 属性的 setter 中处理过了，因此这段逻辑不是必需的。