Fix: event target string property leak. #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycall
force-pushed
the
fix/event_target
branch
from
f87f9bc
to
71c8c3a
Compare
andycall
force-pushed
the
fix/event_target
branch
from
9d5a37f
to
7034678
Compare
wssgcg1213
approved these changes
Dec 29, 2021
answershuto
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quickjs 的 GC tracker 可以有效捕获到对象类型的变量，但是无法捕获字符串类型的变量。
因此需要在对象释放的时候，手动调用 JSFreeValueRT 方法释放对象持有的字符串变量