fix: fix event type atom id changed when free. #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycall
force-pushed
the
fix/event_type_atom
branch
from
ce92647
to
e9fd5d7
Compare
wssgcg1213
force-pushed
the
fix/event_type_atom
branch
from
a6e4596
to
6a8bec3
Compare
answershuto
previously approved these changes
Dec 31, 2021
wssgcg1213
previously approved these changes
Jan 4, 2022
Feat/flutter 2.5.support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
对于相同的字符串，Quickjs 可以确保对应的 JSAtom 是同一个值，但是如果这个字符串的被释放了，再次重新创建 JSAtom，就会是一个新的值。从而导致 eventTarget 触发时间后，匹配的回调不一致。